waf: rename the heuristic list last, a name that said nothing
The list that runs tag_deny the second time was named last(). The bare word does not say what it holds or when it runs, a local variable in rulefiles.go shadows it, and its doc read "the heuristics of last run". It is now afterBesideLookup, beside the other lists named for when they run. Model: opus-5-5
This commit is contained in:
1 parent
0e5a5b468c
commit
b0a06aac63
2 files changed
+6
-6
No files matched your search
@@ -48,7 +48,7 @@ type besideLookupFindings struct {
|
|||||||
// once, and what the other found is dropped. besideLookup has
|
// once, and what the other found is dropped. besideLookup has
|
||||||
// besideLookupTimeLimit; past it, the request is refused as
|
// besideLookupTimeLimit; past it, the request is refused as
|
||||||
// ActionChecksTimedOut. Once both have let the request through, the heuristics
|
// ActionChecksTimedOut. Once both have let the request through, the heuristics
|
||||||
// of last run. ctx is the request's own context.
|
// of afterBesideLookup run. ctx is the request's own context.
|
||||||
func (rq *request) runBesideLookup(
|
func (rq *request) runBesideLookup(
|
||||||
ctx context.Context, lookedUp <-chan lookupResult,
|
ctx context.Context, lookedUp <-chan lookupResult,
|
||||||
) *verdict {
|
) *verdict {
|
||||||
@@ -92,7 +92,7 @@ func (rq *request) runBesideLookup(
|
|||||||
return v
|
return v
|
||||||
}
|
}
|
||||||
|
|
||||||
return rq.runHeuristics(ctx, last(), rq.h.now())
|
return rq.runHeuristics(ctx, afterBesideLookup(), rq.h.now())
|
||||||
}
|
}
|
||||||
|
|
||||||
// findBesideLookup does the work of the heuristics of besideLookup on the
|
// findBesideLookup does the work of the heuristics of besideLookup on the
|
||||||
|
|||||||
@@ -77,10 +77,10 @@ func besideLookup() []heuristic {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// last are the heuristics that run once both lists above have let the request
|
// afterBesideLookup are the heuristics that run once afterLookup and
|
||||||
// through. tag_deny runs a second time, on the tag rule_files and
|
// besideLookup have both let the request through. tag_deny runs a second time,
|
||||||
// core_rule_set can add.
|
// on the tag rule_files and core_rule_set can add.
|
||||||
func last() []heuristic {
|
func afterBesideLookup() []heuristic {
|
||||||
return []heuristic{
|
return []heuristic{
|
||||||
tagDeny{},
|
tagDeny{},
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in new issue
Block a user