Name log fields, metrics and the Core Rule Set package for what they are (closes #192)

Log field, metric, action and event names now say what they count
and, for timings, the unit. Package internal/waf is internal/coreruleset.

Model: opus-5-5

internal/lookup/lookup.go

@@ -198,7 +198,7 @@ func (g *GeoJS) LookUp(ctx context.Context, client netip.Prefix) Answer {
 
 	answer, found := g.kept(client)
 	if !found {
-		g.metrics.GeoJSUnanswered.Inc()
+		g.metrics.RequestsWithoutGeoJSAnswer.Inc()
 	}
 
 	w, waiting := g.waiting[client]
@@ -296,7 +296,7 @@ func (g *GeoJS) answerOrWait(
 	}
 
 	if w == nil {
-		g.metrics.GeoJSUnanswered.Inc()
+		g.metrics.RequestsWithoutGeoJSAnswer.Inc()
 
 		return Answer{}, nil // too many clients wait already
 	}
@@ -307,7 +307,7 @@ func (g *GeoJS) answerOrWait(
 	}
 
 	if w.late {
-		g.metrics.GeoJSUnanswered.Inc()
+		g.metrics.RequestsWithoutGeoJSAnswer.Inc()
 
 		return Answer{}, nil
 	}

internal/lookup/lookup_test.go

@@ -362,7 +362,7 @@ func TestWithoutWaitTheRequestGoesOnAtOnceAndTheAnswerIsGivenWhenItComes(
 		mu.Unlock()
 
 		wantCountry(t, g, client, germany)
-		wantUnanswered(t, m, 0)
+		wantRequestsWithoutGeoJSAnswer(t, m, 0)
 	})
 }
 
@@ -596,7 +596,7 @@ func TestClientsWithoutAnAnswerAreCounted(t *testing.T) {
 		// GeoJS fails, so the first client goes without an answer, and GeoJS
 		// is left alone for a second, which does not pass in this test.
 		wantCountry(t, g, clients(), "")
-		wantUnanswered(t, m, 1)
+		wantRequestsWithoutGeoJSAnswer(t, m, 1)
 
 		// Meanwhile each new client goes without one at once, while there is
 		// room for it among the 10,000 that may wait.
@@ -604,11 +604,11 @@ func TestClientsWithoutAnAnswerAreCounted(t *testing.T) {
 			wantCountry(t, g, clients(), "")
 		}
 
-		wantUnanswered(t, m, 10000)
+		wantRequestsWithoutGeoJSAnswer(t, m, 10000)
 
 		// One more, for which there is no room, goes without one too.
 		wantCountry(t, g, clients(), "")
-		wantUnanswered(t, m, 10001)
+		wantRequestsWithoutGeoJSAnswer(t, m, 10001)
 	})
 }
 
@@ -841,12 +841,12 @@ func wantAsked(t *testing.T, geojs *standIn, i int, want ...string) {
 	}
 }
 
-// wantUnanswered checks how many requests m counts as having gone without
-// an answer from GeoJS.
-func wantUnanswered(t *testing.T, m *metrics.Metrics, want float64) {
+// wantRequestsWithoutGeoJSAnswer checks how many requests m counts as having
+// gone without an answer from GeoJS.
+func wantRequestsWithoutGeoJSAnswer(t *testing.T, m *metrics.Metrics, want float64) {
 	t.Helper()
 
-	got := testutil.ToFloat64(m.GeoJSUnanswered)
+	got := testutil.ToFloat64(m.RequestsWithoutGeoJSAnswer)
 	if got != want {
 		t.Errorf("%v requests went without an answer, want %v", got, want)
 	}