Name log fields, metrics and the Core Rule Set package for what they are (closes #192)

Log field, metric, action and event names now say what they count
and, for timings, the unit. Package internal/waf is internal/coreruleset.

Model: opus-5-5

internal/bans/admin_test.go

@@ -13,7 +13,7 @@ func TestBanWithoutACauseIsAnAdmins(t *testing.T) {
 	t.Parallel()
 
 	netblock := netip.MustParsePrefix("203.0.113.0/24")
-	ledger := bans.New(defaultRules())
+	ledger := bans.New(defaultParams())
 	ledger.Load([]bans.Ban{{Netblock: netblock, Start: midnight()}})
 
 	if got := ledger.Bans(netblock)[0].Cause; got != bans.CauseAdmin {
@@ -24,9 +24,9 @@ func TestBanWithoutACauseIsAnAdmins(t *testing.T) {
 func TestAdminsBansAreNeverDroppedAndDoNotCountTowardMaxBans(t *testing.T) {
 	t.Parallel()
 
-	rules := defaultRules()
-	rules.MaxBans = 1
-	ledger := bans.New(rules)
+	params := defaultParams()
+	params.MaxBans = 1
+	ledger := bans.New(params)
 	adminsOnly := netip.MustParsePrefix("198.51.100.0/24")
 	both := netip.MustParsePrefix("203.0.113.1/32")
 	second := netip.MustParsePrefix("203.0.113.2/32")
@@ -64,9 +64,9 @@ func TestAdminsBansAreNeverDroppedAndDoNotCountTowardMaxBans(t *testing.T) {
 func TestEarlierBansCountABanDroppedAfterAnAdminsBan(t *testing.T) {
 	t.Parallel()
 
-	rules := defaultRules()
-	rules.MaxBans = 2
-	ledger := bans.New(rules)
+	params := defaultParams()
+	params.MaxBans = 2
+	ledger := bans.New(params)
 	netblock := netip.MustParsePrefix("203.0.113.1/32")
 	other := netip.MustParsePrefix("203.0.113.2/32")
 
@@ -93,7 +93,7 @@ func TestEarlierBansCountABanDroppedAfterAnAdminsBan(t *testing.T) {
 func TestEarlierBansCountABanAnAdminKeepsOnce(t *testing.T) {
 	t.Parallel()
 
-	ledger := bans.New(defaultRules())
+	ledger := bans.New(defaultParams())
 	netblock := netip.MustParsePrefix("203.0.113.1/32")
 
 	// The netblock breaks a limit twice, the second time after its first
@@ -117,7 +117,7 @@ func TestEarlierBansCountABanAnAdminKeepsOnce(t *testing.T) {
 func TestReasonOfTheBansSwwMakes(t *testing.T) {
 	t.Parallel()
 
-	ledger := bans.New(defaultRules())
+	ledger := bans.New(defaultParams())
 
 	limit, _ := ledger.BanForLimit(netip.MustParsePrefix("203.0.113.1/32"), midnight(),
 		bans.Notes{Kind: "requests", Limit: 1000, Window: "minute"})
@@ -150,7 +150,7 @@ func TestLiftedBanForALimitRefusesNothingAndMakesNoBanLonger(t *testing.T) {
 		Lifted:   midnight().Add(10 * time.Minute),
 	}
 
-	ledger := bans.New(defaultRules())
+	ledger := bans.New(defaultParams())
 	ledger.Load([]bans.Ban{lifted})
 
 	// While it would still last, it refuses nothing, and a limit broken
@@ -181,7 +181,7 @@ func TestLiftedBanForAnAttackRefusesNothingAndMakesNoBanLonger(t *testing.T) {
 
 	// A permanent ban for a clear sign of attack, lifted.
 	netblock := netip.MustParsePrefix("203.0.113.9/32")
-	ledger := bans.New(defaultRules())
+	ledger := bans.New(defaultParams())
 	ledger.Load([]bans.Ban{{
 		Netblock: netblock,
 		Start:    midnight(),
@@ -211,7 +211,7 @@ func TestLiftedBanForAnAttackRefusesNothingAndMakesNoBanLonger(t *testing.T) {
 func TestLoadEditCountsTheBansAnAdminMade(t *testing.T) {
 	t.Parallel()
 
-	ledger := bans.New(defaultRules())
+	ledger := bans.New(defaultParams())
 	made, _ := ledger.BanForLimit(netip.MustParsePrefix("203.0.113.1/32"), midnight(),
 		bans.Notes{})
 	atStart := bans.Ban{
@@ -246,7 +246,7 @@ func TestAdminsBanIsMadeWhileAnotherLasts(t *testing.T) {
 	t.Parallel()
 
 	netblock := netip.MustParsePrefix("203.0.113.0/24")
-	ledger := bans.New(defaultRules())
+	ledger := bans.New(defaultParams())
 
 	// An hour's ban for a broken limit.
 	ledger.BanForLimit(netblock, midnight(), bans.Notes{})
@@ -292,7 +292,7 @@ func TestLiftLiftsEveryActiveBanCoveringTheClient(t *testing.T) {
 	wide := netip.MustParsePrefix("203.0.113.0/24")
 	other := netip.MustParsePrefix("203.0.113.10/32")
 
-	ledger := bans.New(defaultRules())
+	ledger := bans.New(defaultParams())
 	ledger.Load([]bans.Ban{
 		// Ended an hour ago.
 		{
@@ -346,7 +346,7 @@ func TestPermanentBanOnAWiderNetblockIsReturnedOverATemporaryBan(t *testing.T) {
 	t.Parallel()
 
 	client := netip.MustParseAddr("203.0.113.9")
-	ledger := bans.New(defaultRules())
+	ledger := bans.New(defaultParams())
 
 	// The temporary ban is made first, so that its netblock is looked at first.
 	ledger.BanForLimit(netip.MustParsePrefix("203.0.113.9/32"), midnight(), bans.Notes{})
@@ -360,7 +360,7 @@ func TestOlderPermanentBanIsReturnedOverANewerTemporaryBan(t *testing.T) {
 	t.Parallel()
 
 	netblock := netip.MustParsePrefix("203.0.113.0/24")
-	ledger := bans.New(defaultRules())
+	ledger := bans.New(defaultParams())
 
 	ledger.BanForAdmin(netblock, midnight(), time.Time{}, "for good")
 	ledger.BanForAdmin(netblock, midnight().Add(time.Minute), midnight().Add(time.Hour),