From 0027a82522e044c02e928f8f9e852fcf110e70d9 Mon Sep 17 00:00:00 2001 From: sneak Date: Thu, 19 Nov 2026 09:46:26 +0000 Subject: [PATCH] waf: rename the method banNetblock to parseBanNetblock The new function banNetblock, the netblock a ban on a client covers, shared its name with this method, which parses an admin's netblock. The method's last line, return banNetblock(h.config, addr), read as a call of itself. Model: opus-5-5 --- internal/waf/admin.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/waf/admin.go b/internal/waf/admin.go index 1842b37..99ddec2 100644 --- a/internal/waf/admin.go +++ b/internal/waf/admin.go @@ -139,7 +139,7 @@ func (rq *request) addBan() { ) if err == nil { - netblock, err = rq.h.banNetblock(toAdd.Netblock) + netblock, err = rq.h.parseBanNetblock(toAdd.Netblock) } if err == nil { @@ -190,12 +190,12 @@ func (rq *request) readBanToAdd() (banToAdd, error) { return toAdd, nil } -// banNetblock reads value, a netblock such as 203.0.113.0/24, or a +// parseBanNetblock reads value, a netblock such as 203.0.113.0/24, or a // client's address, which stands for the netblock a ban on that client // covers. An IPv4-mapped netblock, such as ::ffff:203.0.113.0/120, is // refused, since a client's address is looked up as IPv4 and a ban on it // would refuse nothing, and so is a value with a zone. -func (h *handler) banNetblock(value string) (netip.Prefix, error) { +func (h *handler) parseBanNetblock(value string) (netip.Prefix, error) { netblock, err := netip.ParsePrefix(value) if err == nil { if netblock.Addr().Is4In6() {