Merge next into issue-16-exact-results-past-float64

Both sides added a line at the top of the Completed Steps in
docs/TODO.md; both are kept, this branch's first.

Model: opus-5-5

internal/bot/bot.go

@@ -54,12 +54,12 @@ const (
 
 var errExited = errors.New("simplex-chat exited")
 
-// Run starts the chat client with its database in cfg.DataDir, serving
-// its API on localhost at chatPort, connects to it, sets up the bot's
-// address, then answers messages and serves the bot's API until ctx is
-// cancelled — which is a clean stop and returns nil — or until the chat
-// client, the connection to it or the API's listener fails, which
-// returns the error.
+// Run reads the webhooks kept in cfg.DataDir, starts the chat client with
+// its database there, serving its API on localhost at chatPort, connects
+// to it, sets up the bot's address, then answers messages and serves the
+// bot's API until ctx is cancelled — which is a clean stop and returns
+// nil — or until the chat client, the connection to it or the API's
+// listener fails, which returns the error.
 func Run(
 	ctx context.Context, log *slog.Logger, cfg *config.Config, chatPort int,
 ) error {
@@ -68,6 +68,13 @@ func Run(
 		return fmt.Errorf("creating data directory: %w", err)
 	}
 
+	// Before the chat client starts, so that a file that cannot be read
+	// stops the bot as configuration that cannot be read does.
+	webhooks, err := api.ReadWebhooks(cfg.DataDir)
+	if err != nil {
+		return err
+	}
+
 	// Cancelling this stops the chat client; the deferred wait makes
 	// Run return only once it has exited, whatever path Run takes.
 	// Cancelling ctx does not reach it, so that the API, stopped first,
@@ -100,11 +107,12 @@ func Run(
 	}
 
 	srv := api.New(api.Params{
-		Log:    log,
-		Client: client,
-		UserID: user.UserID,
-		Port:   cfg.Port,
-		Token:  cfg.APIToken,
+		Log:      log,
+		Client:   client,
+		UserID:   user.UserID,
+		Port:     cfg.Port,
+		Token:    cfg.APIToken,
+		Webhooks: webhooks,
 	})
 
 	served := make(chan error, 1)

internal/bot/run_test.go

@@ -182,6 +182,25 @@ func TestStopDuringRequest(t *testing.T) {
 	}
 }
 
+// TestUnreadableWebhooks: a webhooks file that cannot be read stops Run
+// before it starts the chat client.
+func TestUnreadableWebhooks(t *testing.T) {
+	// No chat client on PATH: starting one would fail with another error.
+	t.Setenv("PATH", t.TempDir())
+
+	cfg := &config.Config{DataDir: t.TempDir(), Port: freePort(t)}
+
+	err := os.WriteFile(filepath.Join(cfg.DataDir, "webhooks.json"), []byte("{"), 0o600)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	err = bot.Run(t.Context(), slog.New(slog.DiscardHandler), cfg, freePort(t))
+	if err == nil || !strings.Contains(err.Error(), "webhooks.json") {
+		t.Errorf("Run = %v, want an error naming webhooks.json", err)
+	}
+}
+
 // freePort returns a TCP port that nothing listens on at the moment.
 func freePort(t *testing.T) int {
 	t.Helper()