1 Commits
Author SHA1 Message Date
sneak da79c587c0 Run the linter only in Docker (closes #20)
check / check (push) Successful in 38s
check / check (pull_request) Successful in 38s
script/lint now builds only the lint stage of the Dockerfile, without
the build cache, so every run executes the linter; the image is tagged
simplelog-lint. The lint stage calls golangci-lint directly, since make
lint is itself a docker build of that stage. script/cibuild and
script/docker also build without the cache, so their check steps always
run. script/fmt no longer runs golangci-lint --fix, and script/bootstrap
no longer installs it. golangci-lint config verify is left out, on the
owner's ruling. The README, TODO.md and the script/cibuild comment say
what now runs.

Model: opus-5-5
2026-10-06 04:34:31 +00:00
7 changed files with 26 additions and 31 deletions
+1 -1
View File
@@ -6,7 +6,7 @@ COPY go.mod go.sum ./
RUN go mod download RUN go mod download
COPY . . COPY . .
RUN make fmt-check RUN make fmt-check
# Called directly: make lint is itself a docker build (Dockerfile.lint). # Called directly: make lint is itself a docker build of this stage.
RUN golangci-lint run --config .golangci.yml ./... RUN golangci-lint run --config .golangci.yml ./...
# Test stage: run full test suite # Test stage: run full test suite
-13
View File
@@ -1,13 +0,0 @@
# Built by script/lint. The build runs golangci-lint, so a successful build
# is a clean lint.
#
# `golangci-lint config verify` is left out on purpose: it downloads its
# schema over the network on every run, unpinned.
#
# golangci/golangci-lint:v2.12.2 (Debian-based), 2026-08-07
FROM golangci/golangci-lint:v2.12.2@sha256:5cceeef04e53efe1470638d4b4b4f5ceefd574955ab3941b2d9a68a8c9ad5240
WORKDIR /src
COPY go.mod go.sum ./
RUN go mod download
COPY . .
RUN golangci-lint run --config .golangci.yml ./...
+7 -6
View File
@@ -121,17 +121,18 @@ alpine. We provide:
- `script/projectname` — output the project name (our own extension); used by - `script/projectname` — output the project name (our own extension); used by
`script/docker` for the image tag `script/docker` for the image tag
- `script/test` — run the test suite (`go test -v ./...`) - `script/test` — run the test suite (`go test -v ./...`)
- `script/lint` — run golangci-lint in Docker by building `Dockerfile.lint` - `script/lint` — run golangci-lint in Docker by building only the `lint`
without the build cache, so every run lints; keeps no image stage of the `Dockerfile` (which also runs the format check), without the
build cache, so every run lints; the image is tagged `simplelog-lint`
- `script/fmt` — format all files with goimports (writes) - `script/fmt` — format all files with goimports (writes)
- `script/fmt-check` — check formatting (read-only); fails if `gofmt -l` - `script/fmt-check` — check formatting (read-only); fails if `gofmt -l`
reports files reports files
- `script/check` — run all checks: `test`, `lint`, `fmt-check` (our own - `script/check` — run all checks: `test`, `lint`, `fmt-check` (our own
extension) extension)
- `script/docker` — build the Docker image, tagged via `script/projectname` - `script/docker` — build the Docker image without the build cache, tagged
(byte-identical across repos) via `script/projectname` (byte-identical across repos)
- `script/cibuild` — cd to the repo root and `docker build .` (what CI runs; - `script/cibuild` — cd to the repo root and `docker build --no-cache .` (what
the image build runs the checks) CI runs; the image build runs the checks)
- `script/precommit` — run by the git pre-commit hook (our own extension); - `script/precommit` — run by the git pre-commit hook (our own extension);
runs a `go mod tidy` guard, then `script/check` runs a `go mod tidy` guard, then `script/check`
- `script/install-precommit` — installs the git pre-commit hook (our own - `script/install-precommit` — installs the git pre-commit hook (our own
+4 -3
View File
@@ -24,9 +24,10 @@ files it depends on: .golangci.yml, REPO_POLICIES.md, .editorconfig,
# Completed Steps # Completed Steps
* 2026-10-06: the linter runs only in Docker: `script/lint` builds * 2026-10-06: the linter runs only in Docker: `script/lint` builds the
`Dockerfile.lint` without the build cache, and `script/bootstrap` no `lint` stage of the `Dockerfile`, every `docker build` in `script/`
longer installs golangci-lint runs without the build cache, and `script/bootstrap` no longer
installs golangci-lint
* 2026-08-10: fixed every handler discarding slog attributes: console, * 2026-08-10: fixed every handler discarding slog attributes: console,
JSON and webhook handlers now emit record attributes, accumulate JSON and webhook handlers now emit record attributes, accumulate
WithAttrs without mutating the receiver, and honour WithGroup; WithAttrs without mutating the receiver, and honour WithGroup;
+2 -1
View File
@@ -1,13 +1,14 @@
#!/bin/sh #!/bin/sh
# script/cibuild: run the CI build. The Dockerfile runs the format check, # script/cibuild: run the CI build. The Dockerfile runs the format check,
# the linter and the tests, so a successful build means they all pass. # the linter and the tests, so a successful build means they all pass.
# --no-cache because a cached check step is a check that did not run.
set -eu set -eu
ROOT="$(cd "$(dirname "$0")/.." && pwd -P)" ROOT="$(cd "$(dirname "$0")/.." && pwd -P)"
main() { main() {
cd "$ROOT" cd "$ROOT"
docker build . docker build --no-cache .
} }
main "$@" main "$@"
+2 -1
View File
@@ -1,6 +1,7 @@
#!/bin/sh #!/bin/sh
# script/docker: build the Docker image tagged with the project name. # script/docker: build the Docker image tagged with the project name.
# Identical in all repos; the tag comes from script/projectname. # Identical in all repos; the tag comes from script/projectname.
# --no-cache because a cached check step is a check that did not run.
set -eu set -eu
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd -P)" SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd -P)"
@@ -8,7 +9,7 @@ ROOT="$(cd "$SCRIPT_DIR/.." && pwd -P)"
main() { main() {
cd "$ROOT" cd "$ROOT"
docker build -t "$("$SCRIPT_DIR/projectname")" . docker build --no-cache -t "$("$SCRIPT_DIR/projectname")" .
} }
main "$@" main "$@"
+10 -6
View File
@@ -1,15 +1,19 @@
#!/bin/sh #!/bin/sh
# script/lint: run the linter, in docker only, by building Dockerfile.lint; # script/lint: run the linter, in docker only, by building the lint stage
# the build fails on any finding. --no-cache makes every run execute the # of the Dockerfile and nothing else; the build fails on any finding.
# linter: a cached build of an unchanged tree succeeds without linting # --no-cache makes every run execute the linter: a cached build of an
# anything. --output type=cacheonly keeps no image. # unchanged tree succeeds without linting anything. The tag makes each
# build replace the previous image instead of leaving an untagged one.
set -eu set -eu
ROOT="$(cd "$(dirname "$0")/.." && pwd -P)" SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd -P)"
ROOT="$(cd "$SCRIPT_DIR/.." && pwd -P)"
main() { main() {
cd "$ROOT" cd "$ROOT"
docker build --no-cache --output type=cacheonly -f Dockerfile.lint . docker build --no-cache \
--target lint \
-t "$("$SCRIPT_DIR/projectname")-lint" .
} }
main "$@" main "$@"