Replace the single-goroutine WalkDir traversal with a per-directory worker pool: workers read directories concurrently and lstat entries while each directory is fresh in cache, recording size and mtime during the walk. This folds the separate stat pass away (halving metadata I/O per run) and overlaps metadata latency, which dominated on busy pools — a sequential walk of a ~22M-file tree was observed taking over 4 hours. Each PATH operand now loads its scope, walks, hashes, and commits in its own transaction, so an interrupted scan keeps every operand completed so far; a later overlapping operand sees the records committed by earlier ones and reuses them unchanged.
4.4 KiB
Workflow
- branch (from
main) - do the work in Next Step
- move Next Step to the top of Completed Steps
- move the top item of Future Steps into Next Step
- commit (
TODO.mdchanges in the same commit as the work) - merge to
mainif the branch is not protected, otherwise open a PR - push
Status
- pre-1.0
Next Step
- convert Makefile targets to scripts-to-rule-them-all
script/entrypoints like the other managed repos
Completed Steps
-
parallel walk (2026-07-24, branch
parallel-walk): the walk pass was a single goroutine and took hours at ~20M files on a busy pool (observed: 22M files in 4h on a ZFS server); it is now a per-directory worker-pool traversal that records size/mtime during the walk (folding away the separate stat pass, halving metadata I/O), and eachPATHoperand commits in its own transaction so an interrupted scan keeps completed operands -
persistent scan database (2026-07-24, branch
persistent-database):scannow maintains a SQLite database (modernc.org/sqlite, pure Go, cgo stays disabled) keyed by absolute path that survives between runs — a rescan hashes only new or changed files (by mtime/size), deletes records for files vanished from under the scanned operands, and leaves records outside them untouched, soscancan be cronned daily;reportandtreesread the database (no positional arguments) instead of a scan stream. Database at/var/lib/sfdupes/db.sqlite, overridable viaSFDUPES_DATABASE; WAL journaling plus a single-transaction update keep a report run during a scan safe -
add the
originremote (git@git.eeqj.de:sneak/sfdupes.git), tagv0.0.1, and pushmainplus tags (2026-07-23) -
scanCLI rework (2026-07-23, branchscan-required-paths): requiredPATH...operands via cobra flags replacing the/srv-rootdefault; new-x/--one-file-systemflag (GNU convention) to stop at filesystem boundaries, which are crossed by default -
bring the repo into full policy compliance (2026-07-23, branch
repo-policy-compliance; checklist below) -
git initwith README-only first commit; code baseline committed onmain(2026-07-22) -
implement
scan,report, andtreessubcommands (pre-git history)
Future Steps
- possible later features (explicitly out of scope per README): full-content verification of candidates, removal-script helpers
Repo Policy Compliance
Audited 2026-07-22 against REPO_POLICIES.md (2026-07-06), the existing
repo checklist, and the Go styleguide. Code is already gofmt-clean, so no
standalone formatting commit is needed.
.gitignoremissing — the compiledsfdupesbinary andfiles.datsit untracked in the tree; needs OS/editor/Go artifacts plus secrets patterns.editorconfigmissingLICENSEmissing and README has no License section (MIT assumed from house convention — user to confirm)REPO_POLICIES.mdmissing from repo root.golangci.ymlmissing (install canonical copy); code must then passmake lint(150 findings fixed;make lintis clean)Makefilelacks required targetstest,lint,fmt,fmt-check,docker,hooks;checkcurrently depends onbuild, which writes the binary (make checkmust not modify files)- no tests —
go test ./...has nothing to run; policy requires real tests with a 30-second timeout and the conditional-vrerun pattern (suite covers parsing, grouping, digests, suppression, hashing, and the scan pipeline; 64% coverage) Dockerfilemissing — Go multistage with hash-pinned images: fail-fast lint stage, build stage runningmake check.dockerignoremissing.gitea/workflows/check.ymlmissing (docker build .on push, checkout action pinned by commit SHA)- README lacks required sections: Description first line (name/purpose/category/license/author), Getting Started, Rationale, TODO, License, Author
- README non-goal "no git repository setup and no CI" is stale now that the repo is under git with CI
- pre-commit hook not installed (
make hooksonce the target exists)
Accepted divergences (no action):
- flat single-package layout with
.gofiles in the repo root — fine for a small single-binary tool per the Go styleguide; the tracker audit agrees go testruns without-race— the repo mandatesCGO_ENABLED=0(pure-Go builds) and the race detector requires cgo