Re-vendor the canonical files from sneak/prompts at dd4027b #95

Open
opened 2026-10-06 01:30:36 +02:00 by clawbot · 2 comments
Collaborator

sneak/prompts#78: sneak/prompts has changed the canonical files this repository vendors. Re-vendor them once, from sneak/prompts commit dd4027b (dd4027b907), fetching each file from https://git.eeqj.de/sneak/prompts/raw/commit/dd4027b907ef99cdc3187c215cc4d610b7a11efc/<path>.

Files this repository vendors now: .dockerignore .editorconfig .gitea/workflows/check.yml .gitignore .golangci.yml .prettierignore .prettierrc REPO_POLICIES.md. REPO_POLICIES.md comes from prompts/REPO_POLICIES.md at that commit: the root REPO_POLICIES.md there is a symlink, and its raw URL returns only the link's target path. That repository's own .gitattributes and TODO.md are not canonical.

What changed that matters here:

  • golangci-lint is v2.14.0 (golangci/golangci-lint@sha256:ad862ba6b3798cbe0fd9fd7408d498fd74fbd2623a92406b2fd3898faf0bf98f). The lint phase digest and .golangci.yml change in one commit, since v2.12.2 rejects the new file; the go directive may name at most Go 1.27.
  • The Go Dockerfile example: the test phase uses the Debian Go image so -race works; the stage that compiles installs git, trusts /src with git config --system --add safe.directory /src, and fails when .git is present but no version comes out.
  • Host Go tools are installed with go install pinned to a commit, never as go.mod tool dependencies.
  • The image version comes from git describe inside the build: .dockerignore sends .git without its own or any submodule's config. CHECK_EPOCH is gone; every docker build in script/ passes --no-cache.
  • .gitignore and .dockerignore keep out more secret files, hardware-backed SSH keys included.
  • Agent guidance lives in one root AGENTS.md; a committed file or directory named for one agent tool has its content moved there and is deleted.

Definition of done

  1. Every vendored canonical file is its copy at that commit, fetched rather than hand-edited, plus only the entries item 3 keeps. A canonical file the policies require and this repository lacks is added the same way.
  2. Dockerfile, Makefile and script/ follow REPO_POLICIES.md as of that commit, including the gate phases and the version step.
  3. This repository's own entries are carried forward: the deny entries of the test-support depguard rule in .golangci.yml, anchored host-built artifacts in .dockerignore, and its language's entries in .gitignore and .editorconfig, kept after the canonical content. .gitignore is a base each repository extends for its language: a Go repository keeps at least *.log, *.out, *.test and its binaries (prompts/CODE_STYLEGUIDE_GO.md), and its .editorconfig keeps tabs for *.go. (Corrected 2026-10-06: the first version of this item dropped those entries.)
  4. Findings the new files raise are fixed in the code in the same PR; no vendored file is loosened.
  5. make lint runs with no deprecation warnings, and make check passes.
  6. One reviewed PR against next. Closing this issue ticks this repository on sneak/prompts#78.

Model: opus-5-5

https://git.eeqj.de/sneak/prompts/issues/78: `sneak/prompts` has changed the canonical files this repository vendors. Re-vendor them once, from `sneak/prompts` commit `dd4027b` (https://git.eeqj.de/sneak/prompts/commit/dd4027b907ef99cdc3187c215cc4d610b7a11efc), fetching each file from `https://git.eeqj.de/sneak/prompts/raw/commit/dd4027b907ef99cdc3187c215cc4d610b7a11efc/<path>`. Files this repository vendors now: `.dockerignore .editorconfig .gitea/workflows/check.yml .gitignore .golangci.yml .prettierignore .prettierrc REPO_POLICIES.md`. `REPO_POLICIES.md` comes from `prompts/REPO_POLICIES.md` at that commit: the root `REPO_POLICIES.md` there is a symlink, and its raw URL returns only the link's target path. That repository's own `.gitattributes` and `TODO.md` are not canonical. What changed that matters here: - golangci-lint is v2.14.0 (`golangci/golangci-lint@sha256:ad862ba6b3798cbe0fd9fd7408d498fd74fbd2623a92406b2fd3898faf0bf98f`). The lint phase digest and `.golangci.yml` change in one commit, since v2.12.2 rejects the new file; the `go` directive may name at most Go 1.27. - The Go `Dockerfile` example: the test phase uses the Debian Go image so `-race` works; the stage that compiles installs `git`, trusts `/src` with `git config --system --add safe.directory /src`, and fails when `.git` is present but no version comes out. - Host Go tools are installed with `go install` pinned to a commit, never as `go.mod` tool dependencies. - The image version comes from `git describe` inside the build: `.dockerignore` sends `.git` without its own or any submodule's `config`. `CHECK_EPOCH` is gone; every `docker build` in `script/` passes `--no-cache`. - `.gitignore` and `.dockerignore` keep out more secret files, hardware-backed SSH keys included. - Agent guidance lives in one root `AGENTS.md`; a committed file or directory named for one agent tool has its content moved there and is deleted. ## Definition of done 1. Every vendored canonical file is its copy at that commit, fetched rather than hand-edited, plus only the entries item 3 keeps. A canonical file the policies require and this repository lacks is added the same way. 2. `Dockerfile`, `Makefile` and `script/` follow `REPO_POLICIES.md` as of that commit, including the gate phases and the version step. 3. This repository's own entries are carried forward: the `deny` entries of the `test-support` depguard rule in `.golangci.yml`, anchored host-built artifacts in `.dockerignore`, and its language's entries in `.gitignore` and `.editorconfig`, kept after the canonical content. `.gitignore` is a base each repository extends for its language: a Go repository keeps at least `*.log`, `*.out`, `*.test` and its binaries (`prompts/CODE_STYLEGUIDE_GO.md`), and its `.editorconfig` keeps tabs for `*.go`. (Corrected 2026-10-06: the first version of this item dropped those entries.) 4. Findings the new files raise are fixed in the code in the same PR; no vendored file is loosened. 5. `make lint` runs with no deprecation warnings, and `make check` passes. 6. One reviewed PR against `next`. Closing this issue ticks this repository on https://git.eeqj.de/sneak/prompts/issues/78. Model: opus-5-5
clawbot self-assigned this 2026-10-06 01:30:36 +02:00
Author
Collaborator

Plan, on top of the definition of done above:

  • CHECK_EPOCH goes from Dockerfile, Dockerfile.lint, script/cibuild, script/docker, script/lint, README.md and TODO.md; every docker build in script/ passes --no-cache. The README and TODO.md text about the old mechanism is rewritten to describe what the tree then does.
  • .claude/settings.json is deleted: the policy at dd4027b allows nothing committed under .claude/, and the file holds tool configuration, not guidance, so nothing moves to AGENTS.md. Workers are launched from directories outside the repository, so the setting is not needed.
  • Findings from golangci-lint v2.14.0 are fixed in the code; .golangci.yml is not loosened and no //nolint is added.

Model: opus-5-5

Plan, on top of the definition of done above: - `CHECK_EPOCH` goes from `Dockerfile`, `Dockerfile.lint`, `script/cibuild`, `script/docker`, `script/lint`, `README.md` and `TODO.md`; every `docker build` in `script/` passes `--no-cache`. The README and `TODO.md` text about the old mechanism is rewritten to describe what the tree then does. - `.claude/settings.json` is deleted: the policy at `dd4027b` allows nothing committed under `.claude/`, and the file holds tool configuration, not guidance, so nothing moves to `AGENTS.md`. Workers are launched from directories outside the repository, so the setting is not needed. - Findings from golangci-lint v2.14.0 are fixed in the code; `.golangci.yml` is not loosened and no `//nolint` is added. Model: opus-5-5
Author
Collaborator

Implemented in #97. golangci-lint v2.14.0 raised no findings, so no Go code changed. make test now builds the race-enabled test phase uncached and takes about 60 seconds on this host, at the cap; that is disclosed on the PR and waits on sneak/prompts#113.

Model: opus-5-5

Implemented in https://git.eeqj.de/sneak/sfdupes/pulls/97. golangci-lint v2.14.0 raised no findings, so no Go code changed. `make test` now builds the race-enabled test phase uncached and takes about 60 seconds on this host, at the cap; that is disclosed on the PR and waits on https://git.eeqj.de/sneak/prompts/issues/113. Model: opus-5-5
Sign in to join this conversation.