sneak/sfdupes
1
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Remove dead files.dat references from Makefile, .gitignore and .dockerignore #22

New Issue
Closed
opened 2026-08-09 03:47:11 +02:00 by clawbot · 1 comment
clawbot commented 2026-08-09 03:47:11 +02:00
Collaborator
Copy Link
Copy Source

files.dat was the pre-database on-disk scan format. Nothing has produced it since the persistent SQLite database landed, but three references survive:

  • Makefile:49 — clean: rm -f $(BINARY) files.dat
  • .gitignore:30 — files.dat
  • .dockerignore:5 — files.dat

Dead references in the build files are misleading: they imply the tool still writes a local data file, which is exactly the wrong mental model now that the database location is SFDUPES_DATABASE or /var/lib/sfdupes/db.sqlite.

The README's own mention of it is handled in #21; TODO.md:95 is inside a historical Completed Steps entry and should be left alone as a record of what happened.

Definition of done

  1. The three references above are removed. make clean still removes the binary.
  2. grep -rn "files.dat" returns only the historical TODO.md entry.
  3. .gitignore still covers the database artifacts (*.sqlite, *.sqlite-shm, *.sqlite-wal), which are the files that actually appear during a local run.
  4. make check green.
`files.dat` was the pre-database on-disk scan format. Nothing has produced it since the persistent SQLite database landed, but three references survive: - `Makefile:49` — `clean: rm -f $(BINARY) files.dat` - `.gitignore:30` — `files.dat` - `.dockerignore:5` — `files.dat` Dead references in the build files are misleading: they imply the tool still writes a local data file, which is exactly the wrong mental model now that the database location is `SFDUPES_DATABASE` or `/var/lib/sfdupes/db.sqlite`. The README's own mention of it is handled in #21; `TODO.md:95` is inside a historical Completed Steps entry and should be left alone as a record of what happened. ## Definition of done 1. The three references above are removed. `make clean` still removes the binary. 2. `grep -rn "files.dat"` returns only the historical `TODO.md` entry. 3. `.gitignore` still covers the database artifacts (`*.sqlite`, `*.sqlite-shm`, `*.sqlite-wal`), which are the files that actually appear during a local run. 4. `make check` green.
clawbot added this to the 1.0.0 milestone 2026-08-09 03:47:11 +02:00
clawbot commented 2026-09-21 09:22:07 +02:00
Author
Collaborator
Copy Link
Copy Source

Removed the three dead files.dat references (Makefile clean, .gitignore, .dockerignore). make clean still removes the binary; .gitignore still ignores *.sqlite/*.sqlite-shm/*.sqlite-wal. The only remaining mention is the historical TODO.md audit entry. PR: #57

Model: opus-4-8

Removed the three dead `files.dat` references (Makefile `clean`, `.gitignore`, `.dockerignore`). `make clean` still removes the binary; `.gitignore` still ignores `*.sqlite`/`*.sqlite-shm`/`*.sqlite-wal`. The only remaining mention is the historical `TODO.md` audit entry. PR: https://git.eeqj.de/sneak/sfdupes/pulls/57 Model: opus-4-8
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
Review passed; ready to merge
 needs-checks
CI checks failing or not yet green
 needs-rebase
Branch conflicts with main; rebase required
 needs-review
PR awaiting independent adversarial review
 needs-rework
Review found blocking problems; author must rework
No labels
Milestone
No items
No Milestone 1.0.0
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/sfdupes#22