sneak/sfdupes
1
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

initSchema mishandles an unversioned database that already has the files table #11

New Issue
Closed
opened 2026-08-09 03:45:01 +02:00 by clawbot · 1 comment
clawbot commented 2026-08-09 03:45:01 +02:00
Collaborator
Copy Link
Copy Source

initSchema (db.go:163-166) treats user_version == 0 as "empty database" and calls createSchema, which unconditionally runs CREATE TABLE files (db.go:176-191). If the database already has a files table but user_version is 0 — a database created by some other tool, a partially initialized file, or one whose user_version was reset — the user gets create schema: table files already exists, which explains nothing and suggests no action.

README §Database says a database whose schema version is not 1 is a fatal error, so the intended behaviour for an unrecognized database is a clear schema-version error, not a raw SQLite complaint.

Definition of done

  1. initSchema distinguishes a genuinely empty database from one that has a files table but no recognized version, and reports the latter with a clear fatal error naming the file and telling the operator to remove it and rescan.
  2. Alternatively createSchema uses CREATE TABLE IF NOT EXISTS — but only if the version is then still validated, so an unversioned foreign database is not silently adopted.
  3. A test creates a database with a bare files table and user_version = 0 and asserts the error message.
  4. make check green.
`initSchema` (`db.go:163-166`) treats `user_version == 0` as "empty database" and calls `createSchema`, which unconditionally runs `CREATE TABLE files` (`db.go:176-191`). If the database already has a `files` table but `user_version` is 0 — a database created by some other tool, a partially initialized file, or one whose `user_version` was reset — the user gets `create schema: table files already exists`, which explains nothing and suggests no action. README §Database says a database whose schema version is not 1 is a fatal error, so the intended behaviour for an unrecognized database is a clear schema-version error, not a raw SQLite complaint. ## Definition of done 1. `initSchema` distinguishes a genuinely empty database from one that has a `files` table but no recognized version, and reports the latter with a clear fatal error naming the file and telling the operator to remove it and rescan. 2. Alternatively `createSchema` uses `CREATE TABLE IF NOT EXISTS` — but only if the version is then still validated, so an unversioned foreign database is not silently adopted. 3. A test creates a database with a bare `files` table and `user_version = 0` and asserts the error message. 4. `make check` green.
clawbot added this to the 1.0.0 milestone 2026-08-09 03:45:01 +02:00
clawbot commented 2026-09-21 09:23:40 +02:00
Author
Collaborator
Copy Link
Copy Source

Fixed in #58 .

createSchema now checks for an existing files table before creating one. At user_version 0 with a files table present it returns the schema-version error telling the operator to remove the file and rescan, so a foreign or partially initialized database is fatal instead of emitting the raw SQLite table files already exists. A genuinely empty database is unchanged. Added a test that opens a database with a bare files table and user_version 0 for scan and asserts that error. Change stays inside initSchema/createSchema; openDB untouched.

Model: opus-4-8

Fixed in https://git.eeqj.de/sneak/sfdupes/pulls/58 . `createSchema` now checks for an existing `files` table before creating one. At `user_version` 0 with a `files` table present it returns the schema-version error telling the operator to remove the file and rescan, so a foreign or partially initialized database is fatal instead of emitting the raw SQLite `table files already exists`. A genuinely empty database is unchanged. Added a test that opens a database with a bare `files` table and `user_version` 0 for scan and asserts that error. Change stays inside `initSchema`/`createSchema`; `openDB` untouched. Model: opus-4-8
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
Review passed; ready to merge
 needs-checks
CI checks failing or not yet green
 needs-rebase
Branch conflicts with main; rebase required
 needs-review
PR awaiting independent adversarial review
 needs-rework
Review found blocking problems; author must rework
No labels
Milestone
No items
No Milestone 1.0.0
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/sfdupes#11