Correct four inaccurate comments in cancel_test.go and rename a constant (closes #33)
check / check (push) Failing after 2s

Fix the comments the re-review of
#6 found misdescribing their
tests; no test's behaviour changes.

State the property the walkClock tests rely on, that the index load's
Done cost does not grow with the record count, instead of a wrong fixed
figure. Stop implying every test is bounded by poolUnwind; the three
that are not now say so. Record that hashWorker's results-send exit is
reachable and covered by TestScanHashWriteFailureUnwindsPool. Rename
walkCancelInFlightDirs to walkCancelInFlightFiles, since it counts
files. Note at the top why the file departs from the
one-test-file-per-source-file convention.

Model: opus-4-8 (implementation); opus-5-5 (rework)
This commit is contained in:
2026-10-04 09:52:06 +00:00
parent 33f8607e17
commit 2f339fc53a
2 changed files with 62 additions and 19 deletions
+4
View File
@@ -29,6 +29,10 @@
# Completed Steps
- correct four inaccurate comments in `cancel_test.go` and rename
`walkCancelInFlightDirs` to `walkCancelInFlightFiles` (2026-10-04,
https://git.eeqj.de/sneak/sfdupes/issues/33)
- README documents install, Docker, a daily cron scan and how to read
and check the reports (2026-10-04,
https://git.eeqj.de/sneak/sfdupes/issues/54)