From c491eb700328c036ef97cc9aec2ae03f4e52a967 Mon Sep 17 00:00:00 2001 From: sneak Date: Thu, 15 Oct 2026 18:00:40 +0000 Subject: [PATCH] Point the commandWait comment at the Dockerfile's test limit (closes #195) The comment said script/test gives the package 30 seconds. script/test sets no time limit; the test phase of the Dockerfile sets one with go test -timeout. The comment now names that place instead of a number. Model: opus-5-5 --- TODO.md | 5 +++++ internal/cli/integration_test.go | 7 ++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/TODO.md b/TODO.md index 50de5d1..060a89d 100644 --- a/TODO.md +++ b/TODO.md @@ -17,6 +17,11 @@ https://git.eeqj.de/sneak/secret/milestone/12 # Completed Steps +- 2026-10-15: The comment on `commandWait` in `internal/cli/integration_test.go` + no longer says `script/test` gives the package 30 seconds + (https://git.eeqj.de/sneak/secret/issues/195). `script/test` sets no time + limit; the test phase of the `Dockerfile` sets one with `go test -timeout`. + The comment now names that place instead of a number. - 2026-10-15: The canonical files are re-vendored from `sneak/prompts` commit `e3f79c4` (https://git.eeqj.de/sneak/secret/issues/129), so Go's build cache survives between check builds and `make test` no longer compiles the standard diff --git a/internal/cli/integration_test.go b/internal/cli/integration_test.go index 1d5a3d9..27943d1 100644 --- a/internal/cli/integration_test.go +++ b/internal/cli/integration_test.go @@ -34,9 +34,10 @@ const ( testMnemonic = "abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about" // commandWait is how long a test lets the secret binary run before it - // kills it and fails. It stays well under the 30 seconds script/test - // gives the whole package, so a command that hangs fails the test with - // the test's own message instead of Go's timeout panic. + // kills it and fails. It stays well under the time limit the test phase + // of the Dockerfile gives the whole package (go test -timeout), so a + // command that hangs fails the test with the test's own message instead + // of Go's timeout panic. commandWait = 10 * time.Second ) -- 2.54.0