internal/cli tests roughly doubled in run time with the locking change #80

New Issue

2026-10-04T05:01:18+02:00

clawbot commented

2026-10-04 05:01:18 +02:00

Since #69 (locking and atomic writes) landed, the internal/cli tests in script/cibuild take about 43s on this host, against about 24s on the commit before it under similar load. REPO_POLICIES.md asks for make test under 20 seconds. This is separate from #52, which is about -race and the large-size cases and stays sneak's decision.

Definition of done

Find which tests added the time (likely the ones that hold the state-directory lock and wait to show a command blocks, and the real-filesystem atomic-write tests) with a verbose test run through the repo's own entrypoints.
Bring internal/cli back to about its pre-locking time without weakening what the tests prove: shorter waits that still show the command is blocked (for example wait until the command is observed blocked, then release, instead of sleeping a fixed time), t.Parallel() where tests do not share state, shared fixtures. No skips, no testing.Short(), no removed cases.
Each changed test still fails when the defect it guards is planted back.
TODO.md updated in the same commit.

Model: opus-5-5

Since https://git.eeqj.de/sneak/secret/pulls/69 (locking and atomic writes) landed, the `internal/cli` tests in `script/cibuild` take about 43s on this host, against about 24s on the commit before it under similar load. `REPO_POLICIES.md` asks for `make test` under 20 seconds. This is separate from https://git.eeqj.de/sneak/secret/issues/52, which is about `-race` and the large-size cases and stays sneak's decision. ## Definition of done - Find which tests added the time (likely the ones that hold the state-directory lock and wait to show a command blocks, and the real-filesystem atomic-write tests) with a verbose test run through the repo's own entrypoints. - Bring `internal/cli` back to about its pre-locking time without weakening what the tests prove: shorter waits that still show the command is blocked (for example wait until the command is observed blocked, then release, instead of sleeping a fixed time), `t.Parallel()` where tests do not share state, shared fixtures. No skips, no `testing.Short()`, no removed cases. - Each changed test still fails when the defect it guards is planted back. - `TODO.md` updated in the same commit. Model: opus-5-5

~~clawbot referenced this issue 2026-10-04 05:01:46 +02:00~~

next → main: a plain docker build passes and stamps the version #59

clawbot referenced this issue from a commit

2026-10-04 06:36:59 +02:00

Speed up the internal/cli lock and two-vault tests (closes #80)

clawbot referenced this issue from a commit

2026-10-04 06:49:07 +02:00

Speed up the internal/cli lock and two-vault tests (closes #80)

clawbot referenced a pull request that will close this issue

2026-10-04 06:49:14 +02:00

Speed up the internal/cli lock and two-vault tests (closes #80) #83

clawbot commented

2026-10-04 06:49:23 +02:00

#83: the time came from the fixed 100 ms wait per command in the lock test and from six path and move tests each creating two vaults with passphrase unlockers. The lock test now releases the lock as soon as it sees the command waiting for it, and those vaults are created once and copied for each test.

Model: opus-5-5

https://git.eeqj.de/sneak/secret/pulls/83: the time came from the fixed 100 ms wait per command in the lock test and from six path and move tests each creating two vaults with passphrase unlockers. The lock test now releases the lock as soon as it sees the command waiting for it, and those vaults are created once and copied for each test. Model: opus-5-5

clawbot referenced this issue

2026-10-04 06:57:47 +02:00

Refuse to create a vault that already exists (closes #74) #82

clawbot referenced this issue from a commit

2026-10-04 08:03:41 +02:00

Speed up the internal/cli lock and two-vault tests (closes #80)

clawbot closed this issue

2026-10-04 08:08:05 +02:00

clawbot referenced this issue from a commit

2026-10-04 08:08:05 +02:00

Speed up the internal/cli lock and two-vault tests (closes #80)

Sign in to join this conversation.