Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
6f1b3f9fb7 |
@@ -2603,10 +2603,7 @@ func TestRemoveWithoutTerminalFailsAtOnce(t *testing.T) {
|
|||||||
// tty is the end a program uses as its terminal, and ptmx the end the test
|
// tty is the end a program uses as its terminal, and ptmx the end the test
|
||||||
// reads what the terminal shows from and types into. Reading ptmx stops at
|
// reads what the terminal shows from and types into. Reading ptmx stops at
|
||||||
// the context's deadline, when secret rm is killed too, so a terminal that
|
// the context's deadline, when secret rm is killed too, so a terminal that
|
||||||
// stays open fails the test then instead of hanging it. The deadline works
|
// stays open fails the test then instead of hanging it.
|
||||||
// only while ptmx stays non-blocking, as pty.Open of the github.com/creack/pty
|
|
||||||
// commit in go.mod leaves it: calling ptmx.Fd() or going back to v1.1.24
|
|
||||||
// makes the read ignore the deadline, without any error.
|
|
||||||
|
|
||||||
// TestRemoveIgnoresTerminalOnStdout runs `echo y | secret rm x` at a
|
// TestRemoveIgnoresTerminalOnStdout runs `echo y | secret rm x` at a
|
||||||
// terminal. stdin is a pipe, so nobody can answer there, and the command
|
// terminal. stdin is a pipe, so nobody can answer there, and the command
|
||||||
|
|||||||
Reference in New Issue
Block a user