sneak/secret
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix G115 integer overflow warnings in agehd tests

Browse Source 
Add bounds checking before converting int to uint32 to prevent
potential integer overflow in benchmark and concurrent test functions
This commit is contained in:
Jeffrey Paul 2025-06-20 08:27:41 -07:00
parent c52430554a
commit efc9456948
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
pkg/agehd/agehd_test.go
View File

@ -663,6 +663,10 @@ func TestConcurrentDerivation(t *testing.T) {
for i := 0; i < testNumGoroutines; i++ { for i := 0; i < testNumGoroutines; i++ {
go func(goroutineID int) { go func(goroutineID int) {
for j := 0; j < testNumIterations; j++ { for j := 0; j < testNumIterations; j++ {
if j < 0 || j > 1000000 {
errors <- fmt.Errorf("index out of safe range")
return
}
identity, err := DeriveIdentity(mnemonic, uint32(j)) identity, err := DeriveIdentity(mnemonic, uint32(j))
if err != nil { if err != nil {
errors <- err errors <- err
@ -706,7 +710,11 @@ func TestConcurrentDerivation(t *testing.T) {
// Benchmark tests // Benchmark tests
func BenchmarkDeriveIdentity(b *testing.B) { func BenchmarkDeriveIdentity(b *testing.B) {
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
_, err := DeriveIdentity(mnemonic, uint32(i%1000)) index := i % 1000
if index < 0 || index > 1000000 {
b.Fatalf("index out of safe range: %d", index)
}
_, err := DeriveIdentity(mnemonic, uint32(index))
if err != nil { if err != nil {
b.Fatalf("derive identity: %v", err) b.Fatalf("derive identity: %v", err)
} }
@ -715,7 +723,11 @@ func BenchmarkDeriveIdentity(b *testing.B) {
func BenchmarkDeriveIdentityFromXPRV(b *testing.B) { func BenchmarkDeriveIdentityFromXPRV(b *testing.B) {
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
_, err := DeriveIdentityFromXPRV(testXPRV, uint32(i%1000)) index := i % 1000
if index < 0 || index > 1000000 {
b.Fatalf("index out of safe range: %d", index)
}
_, err := DeriveIdentityFromXPRV(testXPRV, uint32(index))
if err != nil { if err != nil {
b.Fatalf("derive identity from xprv: %v", err) b.Fatalf("derive identity from xprv: %v", err)
} }
@ -724,7 +736,11 @@ func BenchmarkDeriveIdentityFromXPRV(b *testing.B) {
func BenchmarkDeriveEntropy(b *testing.B) { func BenchmarkDeriveEntropy(b *testing.B) {
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
_, err := DeriveEntropy(mnemonic, uint32(i%1000)) index := i % 1000
if index < 0 || index > 1000000 {
b.Fatalf("index out of safe range: %d", index)
}
_, err := DeriveEntropy(mnemonic, uint32(index))
if err != nil { if err != nil {
b.Fatalf("derive entropy: %v", err) b.Fatalf("derive entropy: %v", err)
} }