sneak/secret
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix revive package stuttering errors

Browse Source 
- Rename SecretMetadata to Metadata in secret package
- Rename SecretVersion to Version in secret package
- Update NewSecretVersion to NewVersion function
- Update all references across the codebase including:
  - vault package aliases
  - CLI usage
  - test files
  - method receivers and signatures
This commit is contained in:
sneak
2025-06-20 08:48:17 -07:00
parent efc9456948
commit e5b18202f3
10 changed files with 43 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/secret/version_test.go
+7 -7
View File
@@ -4,7 +4,7 @@
//
// - TestGenerateVersionName: Tests version name generation with date and serial format
// - TestGenerateVersionNameMaxSerial: Tests the 999 versions per day limit
// - TestNewSecretVersion: Tests secret version object creation
// - TestNewVersion: Tests secret version object creation
// - TestSecretVersionSave: Tests saving a version with encryption
// - TestSecretVersionLoadMetadata: Tests loading and decrypting version metadata
// - TestSecretVersionGetValue: Tests retrieving and decrypting version values
@@ -121,7 +121,7 @@ func TestGenerateVersionNameMaxSerial(t *testing.T) {
assert.Contains(t, err.Error(), "exceeded maximum versions per day")
}
func TestNewSecretVersion(t *testing.T) {
func TestNewVersion(t *testing.T) {
fs := afero.NewMemMapFs()
vault := &MockVersionVault{
Name: "test",
@@ -129,7 +129,7 @@ func TestNewSecretVersion(t *testing.T) {
stateDir: "/test",
}
sv := NewSecretVersion(vault, "test/secret", "20231215.001")
sv := NewVersion(vault, "test/secret", "20231215.001")
assert.Equal(t, "test/secret", sv.SecretName)
assert.Equal(t, "20231215.001", sv.Version)
@@ -161,7 +161,7 @@ func TestSecretVersionSave(t *testing.T) {
require.NoError(t, err)
// Create and save a version
sv := NewSecretVersion(vault, "test/secret", "20231215.001")
sv := NewVersion(vault, "test/secret", "20231215.001")
testValue := []byte("test-secret-value")
err = sv.Save(testValue)
@@ -196,7 +196,7 @@ func TestSecretVersionLoadMetadata(t *testing.T) {
require.NoError(t, err)
// Create and save a version with custom metadata
sv := NewSecretVersion(vault, "test/secret", "20231215.001")
sv := NewVersion(vault, "test/secret", "20231215.001")
now := time.Now()
epochPlusOne := time.Unix(1, 0)
sv.Metadata.NotBefore = &epochPlusOne
@@ -206,7 +206,7 @@ func TestSecretVersionLoadMetadata(t *testing.T) {
require.NoError(t, err)
// Create new version object and load metadata
sv2 := NewSecretVersion(vault, "test/secret", "20231215.001")
sv2 := NewVersion(vault, "test/secret", "20231215.001")
err = sv2.LoadMetadata(ltIdentity)
require.NoError(t, err)
@@ -239,7 +239,7 @@ func TestSecretVersionGetValue(t *testing.T) {
require.NoError(t, err)
// Create and save a version
sv := NewSecretVersion(vault, "test/secret", "20231215.001")
sv := NewVersion(vault, "test/secret", "20231215.001")
originalValue := []byte("test-secret-value-12345")
err = sv.Save(originalValue)