Fix revive package stuttering errors

- Rename SecretMetadata to Metadata in secret package
- Rename SecretVersion to Version in secret package
- Update NewSecretVersion to NewVersion function
- Update all references across the codebase including:
  - vault package aliases
  - CLI usage
  - test files
  - method receivers and signatures

internal/secret/metadata.go

@@ -20,8 +20,8 @@ type UnlockerMetadata struct {
 	Flags     []string  `json:"flags,omitempty"`
 }
 
-// SecretMetadata contains information about a secret
-type SecretMetadata struct {
+// Metadata contains information about a secret
+type Metadata struct {
 	CreatedAt time.Time `json:"createdAt"`
 	UpdatedAt time.Time `json:"updatedAt"`
 }

internal/secret/secret.go

@@ -28,7 +28,7 @@ type VaultInterface interface {
 type Secret struct {
 	Name      string
 	Directory string
-	Metadata  SecretMetadata
+	Metadata  Metadata
 	vault     VaultInterface
 }
 
@@ -54,7 +54,7 @@ func NewSecret(vault VaultInterface, name string) *Secret {
 		Name:      name,
 		Directory: secretDir,
 		vault:     vault,
-		Metadata: SecretMetadata{
+		Metadata: Metadata{
 			CreatedAt: time.Now(),
 			UpdatedAt: time.Now(),
 		},
@@ -109,7 +109,7 @@ func (s *Secret) GetValue(unlocker Unlocker) ([]byte, error) {
 	}
 
 	// Create version object
-	version := NewSecretVersion(s.vault, s.Name, currentVersion)
+	version := NewVersion(s.vault, s.Name, currentVersion)
 
 	// Check if we have SB_SECRET_MNEMONIC environment variable for direct decryption
 	if envMnemonic := os.Getenv(EnvMnemonic); envMnemonic != "" {
@@ -216,7 +216,7 @@ func (s *Secret) LoadMetadata() error {
 	Debug("LoadMetadata called but is deprecated in versioned model", "secret_name", s.Name)
 	// For backward compatibility, we'll populate with basic info
 	now := time.Now()
-	s.Metadata = SecretMetadata{
+	s.Metadata = Metadata{
 		CreatedAt: now,
 		UpdatedAt: now,
 	}
@@ -224,7 +224,7 @@ func (s *Secret) LoadMetadata() error {
 }
 
 // GetMetadata returns the secret metadata (deprecated)
-func (s *Secret) GetMetadata() SecretMetadata {
+func (s *Secret) GetMetadata() Metadata {
 	Debug("GetMetadata called but is deprecated in versioned model", "secret_name", s.Name)
 	return s.Metadata
 }

internal/secret/version.go

@@ -23,8 +23,8 @@ type VersionMetadata struct {
 	NotAfter  *time.Time `json:"notAfter,omitempty"`  // When this version expires (nil = current)
 }
 
-// SecretVersion represents a version of a secret
-type SecretVersion struct {
+// Version represents a version of a secret
+type Version struct {
 	SecretName string
 	Version    string
 	Directory  string
@@ -32,8 +32,8 @@ type SecretVersion struct {
 	vault      VaultInterface
 }
 
-// NewSecretVersion creates a new SecretVersion instance
-func NewSecretVersion(vault VaultInterface, secretName string, version string) *SecretVersion {
+// NewVersion creates a new Version instance
+func NewVersion(vault VaultInterface, secretName string, version string) *Version {
 	DebugWith("Creating new secret version instance",
 		slog.String("secret_name", secretName),
 		slog.String("version", version),
@@ -51,7 +51,7 @@ func NewSecretVersion(vault VaultInterface, secretName string, version string) *
 	)
 
 	now := time.Now()
-	return &SecretVersion{
+	return &Version{
 		SecretName: secretName,
 		Version:    version,
 		Directory:  versionDir,
@@ -107,7 +107,7 @@ func GenerateVersionName(fs afero.Fs, secretDir string) (string, error) {
 }
 
 // Save saves the version metadata and value
-func (sv *SecretVersion) Save(value []byte) error {
+func (sv *Version) Save(value []byte) error {
 	DebugWith("Saving secret version",
 		slog.String("secret_name", sv.SecretName),
 		slog.String("version", sv.Version),
@@ -223,7 +223,7 @@ func (sv *SecretVersion) Save(value []byte) error {
 }
 
 // LoadMetadata loads and decrypts the version metadata
-func (sv *SecretVersion) LoadMetadata(ltIdentity *age.X25519Identity) error {
+func (sv *Version) LoadMetadata(ltIdentity *age.X25519Identity) error {
 	DebugWith("Loading version metadata",
 		slog.String("secret_name", sv.SecretName),
 		slog.String("version", sv.Version),
@@ -281,7 +281,7 @@ func (sv *SecretVersion) LoadMetadata(ltIdentity *age.X25519Identity) error {
 }
 
 // GetValue retrieves and decrypts the version value
-func (sv *SecretVersion) GetValue(ltIdentity *age.X25519Identity) ([]byte, error) {
+func (sv *Version) GetValue(ltIdentity *age.X25519Identity) ([]byte, error) {
 	DebugWith("Getting version value",
 		slog.String("secret_name", sv.SecretName),
 		slog.String("version", sv.Version),

internal/secret/version_test.go

@@ -4,7 +4,7 @@
 //
 // - TestGenerateVersionName: Tests version name generation with date and serial format
 // - TestGenerateVersionNameMaxSerial: Tests the 999 versions per day limit
-// - TestNewSecretVersion: Tests secret version object creation
+// - TestNewVersion: Tests secret version object creation
 // - TestSecretVersionSave: Tests saving a version with encryption
 // - TestSecretVersionLoadMetadata: Tests loading and decrypting version metadata
 // - TestSecretVersionGetValue: Tests retrieving and decrypting version values
@@ -121,7 +121,7 @@ func TestGenerateVersionNameMaxSerial(t *testing.T) {
 	assert.Contains(t, err.Error(), "exceeded maximum versions per day")
 }
 
-func TestNewSecretVersion(t *testing.T) {
+func TestNewVersion(t *testing.T) {
 	fs := afero.NewMemMapFs()
 	vault := &MockVersionVault{
 		Name:     "test",
@@ -129,7 +129,7 @@ func TestNewSecretVersion(t *testing.T) {
 		stateDir: "/test",
 	}
 
-	sv := NewSecretVersion(vault, "test/secret", "20231215.001")
+	sv := NewVersion(vault, "test/secret", "20231215.001")
 
 	assert.Equal(t, "test/secret", sv.SecretName)
 	assert.Equal(t, "20231215.001", sv.Version)
@@ -161,7 +161,7 @@ func TestSecretVersionSave(t *testing.T) {
 	require.NoError(t, err)
 
 	// Create and save a version
-	sv := NewSecretVersion(vault, "test/secret", "20231215.001")
+	sv := NewVersion(vault, "test/secret", "20231215.001")
 	testValue := []byte("test-secret-value")
 
 	err = sv.Save(testValue)
@@ -196,7 +196,7 @@ func TestSecretVersionLoadMetadata(t *testing.T) {
 	require.NoError(t, err)
 
 	// Create and save a version with custom metadata
-	sv := NewSecretVersion(vault, "test/secret", "20231215.001")
+	sv := NewVersion(vault, "test/secret", "20231215.001")
 	now := time.Now()
 	epochPlusOne := time.Unix(1, 0)
 	sv.Metadata.NotBefore = &epochPlusOne
@@ -206,7 +206,7 @@ func TestSecretVersionLoadMetadata(t *testing.T) {
 	require.NoError(t, err)
 
 	// Create new version object and load metadata
-	sv2 := NewSecretVersion(vault, "test/secret", "20231215.001")
+	sv2 := NewVersion(vault, "test/secret", "20231215.001")
 	err = sv2.LoadMetadata(ltIdentity)
 	require.NoError(t, err)
 
@@ -239,7 +239,7 @@ func TestSecretVersionGetValue(t *testing.T) {
 	require.NoError(t, err)
 
 	// Create and save a version
-	sv := NewSecretVersion(vault, "test/secret", "20231215.001")
+	sv := NewVersion(vault, "test/secret", "20231215.001")
 	originalValue := []byte("test-secret-value-12345")
 
 	err = sv.Save(originalValue)