sneak/secret
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: add nolint comments for necessary global variables in internal/secret

Browse Source 
Add nolint:gochecknoglobals comments for legitimate global variables:
- debugEnabled and debugLogger: Package-wide debug state management
- GPGEncryptFunc and GPGDecryptFunc: Required for test mocking
- getCurrentVaultFunc: Required to break import cycle between packages
This commit is contained in:
Jeffrey Paul 2025-07-09 12:47:51 -07:00
parent 38b450cbcf
commit d710323bd0
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/secret/debug.go
View File

@ -13,8 +13,8 @@ import (
) )
var ( var (
debugEnabled bool debugEnabled bool //nolint:gochecknoglobals // Package-wide debug state is necessary
debugLogger *slog.Logger debugLogger *slog.Logger //nolint:gochecknoglobals // Package-wide logger instance is necessary
) )
func init() { func init() {

4
internal/secret/pgpunlocker.go
View File

@ -20,11 +20,11 @@ import (
var ( var (
// GPGEncryptFunc is the function used for GPG encryption // GPGEncryptFunc is the function used for GPG encryption
// Can be overridden in tests to provide a non-interactive implementation // Can be overridden in tests to provide a non-interactive implementation
GPGEncryptFunc = gpgEncryptDefault GPGEncryptFunc = gpgEncryptDefault //nolint:gochecknoglobals // Required for test mocking
// GPGDecryptFunc is the function used for GPG decryption // GPGDecryptFunc is the function used for GPG decryption
// Can be overridden in tests to provide a non-interactive implementation // Can be overridden in tests to provide a non-interactive implementation
GPGDecryptFunc = gpgDecryptDefault GPGDecryptFunc = gpgDecryptDefault //nolint:gochecknoglobals // Required for test mocking
// gpgKeyIDRegex validates GPG key IDs // gpgKeyIDRegex validates GPG key IDs
// Allows either: // Allows either:

2
internal/secret/secret.go
View File

@ -286,7 +286,7 @@ func GetCurrentVault(fs afero.Fs, stateDir string) (VaultInterface, error) {
// getCurrentVaultFunc is a function variable that will be set by the vault package // getCurrentVaultFunc is a function variable that will be set by the vault package
// to implement the actual GetCurrentVault functionality // to implement the actual GetCurrentVault functionality
var getCurrentVaultFunc func(fs afero.Fs, stateDir string) (VaultInterface, error) var getCurrentVaultFunc func(fs afero.Fs, stateDir string) (VaultInterface, error) //nolint:gochecknoglobals // Required to break import cycle
// RegisterGetCurrentVaultFunc allows the vault package to register its implementation // RegisterGetCurrentVaultFunc allows the vault package to register its implementation
// of GetCurrentVault to break the import cycle // of GetCurrentVault to break the import cycle