Update golangci-lint to v2.12.2 with canonical config

- Replace .golangci.yml with the canonical strict config (all linters
  enabled except the standard disable list; lll 88, funlen 80/50,
  cyclop 15, dupl 100; test files now linted)
- Pin the Dockerfile lint stage to golangci/golangci-lint:v2.12.2 by
  tag and digest (Debian-based)
- Fix all ~1550 findings surfaced by the new config: line wrapping,
  wsl_v5/nlreturn blank lines, noinlineerr splits, err113 sentinel
  errors, perfsprint/modernize rewrites, goconst constants, thelper,
  testifylint, noctx CommandContext, testpackage conversions,
  t.Parallel() where safe, and complexity/dupl helper extraction
- Record the change and follow-up items in TODO.md

internal/cli/info.go

@@ -18,7 +18,7 @@ import (
 )
 
 // Version info - these are set at build time
-var ( //nolint:gochecknoglobals // Set at build time
+var (
 	Version   = "dev"     //nolint:gochecknoglobals // Set at build time
 	GitCommit = "unknown" //nolint:gochecknoglobals // Set at build time
 )
@@ -35,8 +35,8 @@ type InfoOutput struct {
 	NumVaults     int       `json:"numVaults"`
 	NumSecrets    int       `json:"numSecrets"`
 	TotalSize     int64     `json:"totalSizeBytes"`
-	OldestSecret  time.Time `json:"oldestSecret,omitempty"`
-	LatestSecret  time.Time `json:"latestSecret,omitempty"`
+	OldestSecret  time.Time `json:"oldestSecret"`
+	LatestSecret  time.Time `json:"latestSecret"`
 }
 
 // newInfoCmd returns the info command
@@ -51,7 +51,8 @@ func newInfoCmd() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "info",
 		Short: "Display system information",
-		Long:  "Display information about the secret system including version, vault statistics, and storage usage",
+		Long: "Display information about the secret system including " +
+			"version, vault statistics, and storage usage",
 		RunE: func(cmd *cobra.Command, _ []string) error {
 			return cli.Info(cmd, jsonOutput)
 		},
@@ -81,6 +82,7 @@ func (cli *Instance) Info(cmd *cobra.Command, jsonOutput bool) error {
 
 	// Count vaults
 	vaultsDir := filepath.Join(cli.stateDir, "vaults.d")
+
 	vaultEntries, err := afero.ReadDir(cli.fs, vaultsDir)
 	if err == nil {
 		for _, entry := range vaultEntries {
@@ -92,12 +94,15 @@ func (cli *Instance) Info(cmd *cobra.Command, jsonOutput bool) error {
 
 	// Gather statistics from all vaults
 	if info.NumVaults > 0 {
-		totalSecrets, totalSize, oldestTime, latestTime, _ := gatherVaultStats(cli.fs, vaultsDir)
+		totalSecrets, totalSize, oldestTime, latestTime, _ := gatherVaultStats(
+			cli.fs, vaultsDir)
 		info.NumSecrets = totalSecrets
 		info.TotalSize = totalSize
+
 		if !oldestTime.IsZero() {
 			info.OldestSecret = oldestTime
 		}
+
 		if !latestTime.IsZero() {
 			info.LatestSecret = latestTime
 		}
@@ -144,19 +149,24 @@ func prettyPrintInfo(w io.Writer, info InfoOutput) error {
 	_, _ = fmt.Fprintln(w, strings.Repeat("─", separatorLength))
 
 	_, _ = fmt.Fprintf(w, "🗂️  Vaults:           %s\n", bold.Sprint(info.NumVaults))
+
 	_, _ = fmt.Fprintf(w, "🔑 Secrets:          %s\n", bold.Sprint(info.NumSecrets))
+
 	if info.TotalSize >= 0 {
-		//nolint:gosec // TotalSize is always >= 0
-		_, _ = fmt.Fprintf(w, "💾 Total Size:       %s\n", bold.Sprint(humanize.Bytes(uint64(info.TotalSize))))
+		_, _ = fmt.Fprintf(w, "💾 Total Size:       %s\n",
+			bold.Sprint(humanize.Bytes(uint64(info.TotalSize))))
 	} else {
 		_, _ = fmt.Fprintf(w, "💾 Total Size:       %s\n", bold.Sprint("0 B"))
 	}
 
 	if !info.OldestSecret.IsZero() {
-		_, _ = fmt.Fprintf(w, "🕰️  Oldest Secret:    %s\n", info.OldestSecret.Format("2006-01-02 15:04:05"))
+		_, _ = fmt.Fprintf(w, "🕰️  Oldest Secret:    %s\n",
+			info.OldestSecret.Format("2006-01-02 15:04:05"))
 	}
+
 	if !info.LatestSecret.IsZero() {
-		_, _ = fmt.Fprintf(w, "✨ Latest Secret:    %s\n", info.LatestSecret.Format("2006-01-02 15:04:05"))
+		_, _ = fmt.Fprintf(w, "✨ Latest Secret:    %s\n",
+			info.LatestSecret.Format("2006-01-02 15:04:05"))
 	}
 
 	_, _ = fmt.Fprintln(w)