From 9e35bf21a3e8b5020499be1ac5deb8a3e0b60549 Mon Sep 17 00:00:00 2001 From: sneak Date: Fri, 20 Jun 2025 09:40:17 -0700 Subject: [PATCH] fix: more nlreturn and testifylint issues - Add blank lines before return statements - Use require.Error instead of assert.Error for error assertions - Keep exact float64 comparisons as-is (they are integers from JSON) --- internal/cli/version_test.go | 4 ++-- internal/secret/helpers.go | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/cli/version_test.go b/internal/cli/version_test.go index e9cd36e..2b937a4 100644 --- a/internal/cli/version_test.go +++ b/internal/cli/version_test.go @@ -128,7 +128,7 @@ func TestListVersionsNonExistentSecret(t *testing.T) { // Try to list versions of non-existent secret err := cli.ListVersions(cmd, "nonexistent/secret") - assert.Error(t, err) + require.Error(t, err) assert.Contains(t, err.Error(), "not found") } @@ -212,7 +212,7 @@ func TestPromoteNonExistentVersion(t *testing.T) { // Try to promote non-existent version err = cli.PromoteVersion(cmd, "test/secret", "20991231.999") - assert.Error(t, err) + require.Error(t, err) assert.Contains(t, err.Error(), "not found") } diff --git a/internal/secret/helpers.go b/internal/secret/helpers.go index b3e9eca..a06e6e8 100644 --- a/internal/secret/helpers.go +++ b/internal/secret/helpers.go @@ -50,5 +50,6 @@ func DetermineStateDir(customConfigDir string) string { homeDir, _ := os.UserHomeDir() return filepath.Join(homeDir, ".config", AppID) } + return filepath.Join(configDir, AppID) }