refactor: fix redundant metadata fields across the codebase - Removed VaultMetadata.Name (redundant with directory structure) - Removed SecretMetadata.Name (redundant with Secret.Name field) - Removed AgePublicKey and AgeRecipient from PGPUnlockerMetadata - Removed AgePublicKey from KeychainUnlockerMetadata - Changed PGP and Keychain unlockers to store recipient in pub.txt instead of pub.age - Fixed all tests to reflect these changes - Follows DRY principle and prevents data inconsistency

internal/vault/management.go

@@ -247,7 +247,6 @@ func CreateVault(fs afero.Fs, stateDir string, name string) (*Vault, error) {
 
 	// Save vault metadata
 	metadata := &VaultMetadata{
-		Name:            name,
 		CreatedAt:       time.Now(),
 		DerivationIndex: derivationIndex,
 		PublicKeyHash:   publicKeyHash,

internal/vault/metadata_test.go

@@ -71,7 +71,6 @@ func TestVaultMetadata(t *testing.T) {
 		}
 
 		metadata1 := &VaultMetadata{
-			Name:            "vault1",
 			DerivationIndex: 0,
 			PublicKeyHash:   pubKeyHash0,
 		}
@@ -117,7 +116,6 @@ func TestVaultMetadata(t *testing.T) {
 		}
 
 		metadata2 := &VaultMetadata{
-			Name:            "vault2",
 			DerivationIndex: 5,
 			PublicKeyHash:   pubKeyHash0, // Same hash since it's from the same mnemonic
 		}
@@ -143,7 +141,6 @@ func TestVaultMetadata(t *testing.T) {
 
 		// Create and save metadata
 		metadata := &VaultMetadata{
-			Name:            "test-vault",
 			DerivationIndex: 3,
 			PublicKeyHash:   "test-public-key-hash",
 		}
@@ -158,9 +155,6 @@ func TestVaultMetadata(t *testing.T) {
 			t.Fatalf("Failed to load metadata: %v", err)
 		}
 
-		if loaded.Name != metadata.Name {
-			t.Errorf("Name mismatch: expected %s, got %s", metadata.Name, loaded.Name)
-		}
 		if loaded.DerivationIndex != metadata.DerivationIndex {
 			t.Errorf("DerivationIndex mismatch: expected %d, got %d", metadata.DerivationIndex, loaded.DerivationIndex)
 		}