diff --git a/internal/cli/generate.go b/internal/cli/generate.go index 0e5ffa3..86b3c12 100644 --- a/internal/cli/generate.go +++ b/internal/cli/generate.go @@ -11,6 +11,11 @@ import ( "github.com/tyler-smith/go-bip39" ) +const ( + defaultSecretLength = 16 + mnemonicEntropyBits = 128 +) + func newGenerateCmd() *cobra.Command { cmd := &cobra.Command{ Use: "generate", @@ -55,7 +60,7 @@ func newGenerateSecretCmd() *cobra.Command { }, } - cmd.Flags().IntP("length", "l", 16, "Length of the generated secret (default 16)") + cmd.Flags().IntP("length", "l", defaultSecretLength, "Length of the generated secret (default 16)") cmd.Flags().StringP("type", "t", "base58", "Type of secret to generate (base58, alnum)") cmd.Flags().BoolP("force", "f", false, "Overwrite existing secret") @@ -65,7 +70,7 @@ func newGenerateSecretCmd() *cobra.Command { // GenerateMnemonic generates a random BIP39 mnemonic phrase func (cli *Instance) GenerateMnemonic(cmd *cobra.Command) error { // Generate 128 bits of entropy for a 12-word mnemonic - entropy, err := bip39.NewEntropy(128) + entropy, err := bip39.NewEntropy(mnemonicEntropyBits) if err != nil { return fmt.Errorf("failed to generate entropy: %w", err) } diff --git a/internal/cli/init.go b/internal/cli/init.go index 19f1c92..b6fec87 100644 --- a/internal/cli/init.go +++ b/internal/cli/init.go @@ -80,12 +80,12 @@ func (cli *Instance) Init(cmd *cobra.Command) error { // Set mnemonic in environment for CreateVault to use originalMnemonic := os.Getenv(secret.EnvMnemonic) - os.Setenv(secret.EnvMnemonic, mnemonicStr) + _ = os.Setenv(secret.EnvMnemonic, mnemonicStr) defer func() { if originalMnemonic != "" { - os.Setenv(secret.EnvMnemonic, originalMnemonic) + _ = os.Setenv(secret.EnvMnemonic, originalMnemonic) } else { - os.Unsetenv(secret.EnvMnemonic) + _ = os.Unsetenv(secret.EnvMnemonic) } }() diff --git a/internal/cli/test_helpers.go b/internal/cli/test_helpers.go index fe8e765..06e4e66 100644 --- a/internal/cli/test_helpers.go +++ b/internal/cli/test_helpers.go @@ -20,7 +20,7 @@ func ExecuteCommandInProcess(args []string, stdin string, env map[string]string) // Set test environment for k, v := range env { - os.Setenv(k, v) + _ = os.Setenv(k, v) } // Create root command @@ -53,9 +53,9 @@ func ExecuteCommandInProcess(args []string, stdin string, env map[string]string) // Restore environment for k, v := range savedEnv { if v == "" { - os.Unsetenv(k) + _ = os.Unsetenv(k) } else { - os.Setenv(k, v) + _ = os.Setenv(k, v) } } diff --git a/internal/cli/version.go b/internal/cli/version.go index 285ca52..df74c8d 100644 --- a/internal/cli/version.go +++ b/internal/cli/version.go @@ -12,6 +12,10 @@ import ( "github.com/spf13/cobra" ) +const ( + tabWriterPadding = 2 +) + // newVersionCmd returns the version management command func newVersionCmd() *cobra.Command { cli := NewCLIInstance() @@ -110,8 +114,8 @@ func (cli *Instance) ListVersions(cmd *cobra.Command, secretName string) error { } // Create table writer - w := tabwriter.NewWriter(cmd.OutOrStdout(), 0, 0, 2, ' ', 0) - fmt.Fprintln(w, "VERSION\tCREATED\tSTATUS\tNOT_BEFORE\tNOT_AFTER") + w := tabwriter.NewWriter(cmd.OutOrStdout(), 0, 0, tabWriterPadding, ' ', 0) + _, _ = fmt.Fprintln(w, "VERSION\tCREATED\tSTATUS\tNOT_BEFORE\tNOT_AFTER") // Load and display each version's metadata for _, version := range versions { @@ -125,7 +129,7 @@ func (cli *Instance) ListVersions(cmd *cobra.Command, secretName string) error { if version == currentVersion { status = "current (error)" } - fmt.Fprintf(w, "%s\t%s\t%s\t%s\t%s\n", version, "-", status, "-", "-") + _, _ = fmt.Fprintf(w, "%s\t%s\t%s\t%s\t%s\n", version, "-", status, "-", "-") continue } @@ -152,10 +156,10 @@ func (cli *Instance) ListVersions(cmd *cobra.Command, secretName string) error { notAfter = sv.Metadata.NotAfter.Format("2006-01-02 15:04:05") } - fmt.Fprintf(w, "%s\t%s\t%s\t%s\t%s\n", version, createdAt, status, notBefore, notAfter) + _, _ = fmt.Fprintf(w, "%s\t%s\t%s\t%s\t%s\n", version, createdAt, status, notBefore, notAfter) } - w.Flush() + _ = w.Flush() return nil }