From 11e43542cf8e20218ca724bdfac79832ec1f1dc1 Mon Sep 17 00:00:00 2001 From: sneak Date: Wed, 9 Jul 2025 06:16:13 -0700 Subject: [PATCH] fix: handle error returns from os.Unsetenv and file.Close (errcheck) Fixed the first five errcheck linter errors: - Added error handling for os.Unsetenv in cli_test.go - Added error handling for file.Close() in crypto.go (4 instances) --- internal/cli/cli_test.go | 2 +- internal/cli/crypto.go | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/cli/cli_test.go b/internal/cli/cli_test.go index 4d95adc..8e5b3eb 100644 --- a/internal/cli/cli_test.go +++ b/internal/cli/cli_test.go @@ -47,7 +47,7 @@ func TestDetermineStateDir(t *testing.T) { } // Test with custom config dir - os.Unsetenv(secret.EnvStateDir) + _ = os.Unsetenv(secret.EnvStateDir) customConfigDir := "/custom-config" stateDir = secret.DetermineStateDir(customConfigDir) expectedDir := filepath.Join(customConfigDir, secret.AppID) diff --git a/internal/cli/crypto.go b/internal/cli/crypto.go index 9130042..80a730e 100644 --- a/internal/cli/crypto.go +++ b/internal/cli/crypto.go @@ -128,7 +128,7 @@ func (cli *Instance) Encrypt(secretName, inputFile, outputFile string) error { if err != nil { return fmt.Errorf("failed to open input file: %w", err) } - defer file.Close() + defer func() { _ = file.Close() }() input = file } @@ -139,7 +139,7 @@ func (cli *Instance) Encrypt(secretName, inputFile, outputFile string) error { if err != nil { return fmt.Errorf("failed to create output file: %w", err) } - defer file.Close() + defer func() { _ = file.Close() }() output = file } @@ -214,7 +214,7 @@ func (cli *Instance) Decrypt(secretName, inputFile, outputFile string) error { if err != nil { return fmt.Errorf("failed to open input file: %w", err) } - defer file.Close() + defer func() { _ = file.Close() }() input = file } @@ -225,7 +225,7 @@ func (cli *Instance) Decrypt(secretName, inputFile, outputFile string) error { if err != nil { return fmt.Errorf("failed to create output file: %w", err) } - defer file.Close() + defer func() { _ = file.Close() }() output = file }