latest from ai, it broke the tests

internal/vault/unlockers.go

@@ -139,20 +139,20 @@ func (v *Vault) ListUnlockers() ([]UnlockerMetadata, error) {
 			metadataPath := filepath.Join(unlockersDir, file.Name(), "unlocker-metadata.json")
 			exists, err := afero.Exists(v.fs, metadataPath)
 			if err != nil {
-				continue
+				return nil, fmt.Errorf("failed to check if metadata exists for unlocker %s: %w", file.Name(), err)
 			}
 			if !exists {
-				continue
+				return nil, fmt.Errorf("unlocker directory %s is missing metadata file", file.Name())
 			}
 
 			metadataBytes, err := afero.ReadFile(v.fs, metadataPath)
 			if err != nil {
-				continue
+				return nil, fmt.Errorf("failed to read metadata for unlocker %s: %w", file.Name(), err)
 			}
 
 			var metadata UnlockerMetadata
 			if err := json.Unmarshal(metadataBytes, &metadata); err != nil {
-				continue
+				return nil, fmt.Errorf("failed to parse metadata for unlocker %s: %w", file.Name(), err)
 			}
 
 			unlockers = append(unlockers, metadata)
@@ -185,18 +185,22 @@ func (v *Vault) RemoveUnlocker(unlockerID string) error {
 			// Read metadata file
 			metadataPath := filepath.Join(unlockersDir, file.Name(), "unlocker-metadata.json")
 			exists, err := afero.Exists(v.fs, metadataPath)
-			if err != nil || !exists {
+			if err != nil {
+				return fmt.Errorf("failed to check if metadata exists for unlocker %s: %w", file.Name(), err)
+			}
+			if !exists {
+				// Skip directories without metadata - they might not be unlockers
 				continue
 			}
 
 			metadataBytes, err := afero.ReadFile(v.fs, metadataPath)
 			if err != nil {
-				continue
+				return fmt.Errorf("failed to read metadata for unlocker %s: %w", file.Name(), err)
 			}
 
 			var metadata UnlockerMetadata
 			if err := json.Unmarshal(metadataBytes, &metadata); err != nil {
-				continue
+				return fmt.Errorf("failed to parse metadata for unlocker %s: %w", file.Name(), err)
 			}
 
 			unlockerDirPath = filepath.Join(unlockersDir, file.Name())
@@ -255,18 +259,22 @@ func (v *Vault) SelectUnlocker(unlockerID string) error {
 			// Read metadata file
 			metadataPath := filepath.Join(unlockersDir, file.Name(), "unlocker-metadata.json")
 			exists, err := afero.Exists(v.fs, metadataPath)
-			if err != nil || !exists {
+			if err != nil {
+				return fmt.Errorf("failed to check if metadata exists for unlocker %s: %w", file.Name(), err)
+			}
+			if !exists {
+				// Skip directories without metadata - they might not be unlockers
 				continue
 			}
 
 			metadataBytes, err := afero.ReadFile(v.fs, metadataPath)
 			if err != nil {
-				continue
+				return fmt.Errorf("failed to read metadata for unlocker %s: %w", file.Name(), err)
 			}
 
 			var metadata UnlockerMetadata
 			if err := json.Unmarshal(metadataBytes, &metadata); err != nil {
-				continue
+				return fmt.Errorf("failed to parse metadata for unlocker %s: %w", file.Name(), err)
 			}
 
 			unlockerDirPath := filepath.Join(unlockersDir, file.Name())
@@ -303,9 +311,11 @@ func (v *Vault) SelectUnlocker(unlockerID string) error {
 	currentUnlockerPath := filepath.Join(vaultDir, "current-unlocker")
 
 	// Remove existing symlink if it exists
-	if exists, _ := afero.Exists(v.fs, currentUnlockerPath); exists {
+	if exists, err := afero.Exists(v.fs, currentUnlockerPath); err != nil {
+		return fmt.Errorf("failed to check if current unlocker symlink exists: %w", err)
+	} else if exists {
 		if err := v.fs.Remove(currentUnlockerPath); err != nil {
-			secret.Debug("Failed to remove existing unlocker symlink", "error", err, "path", currentUnlockerPath)
+			return fmt.Errorf("failed to remove existing unlocker symlink: %w", err)
 		}
 	}