refactor: remove confusing dual ID method pattern from Unlocker interface - Removed redundant ID() method from Unlocker interface - Removed ID field from UnlockerMetadata struct - Modified GetID() to generate IDs dynamically based on unlocker type and data - Updated vault package to create unlocker instances when searching by ID - Fixed all tests and CLI code to remove ID field references - IDs are now consistently generated from unlocker data, preventing redundancy

internal/secret/pgpunlocker.go

@@ -106,18 +106,14 @@ func (p *PGPUnlocker) GetDirectory() string {
 	return p.Directory
 }
 
-// GetID implements Unlocker interface
+// GetID implements Unlocker interface - generates ID from GPG key ID
 func (p *PGPUnlocker) GetID() string {
-	return p.Metadata.ID
-}
-
-// ID implements Unlocker interface - generates ID from GPG key ID
-func (p *PGPUnlocker) ID() string {
 	// Generate ID using GPG key ID: <keyid>-pgp
 	gpgKeyID, err := p.GetGPGKeyID()
 	if err != nil {
-		// Fallback to metadata ID if we can't read the GPG key ID
-		return p.Metadata.ID
+		// Fallback to creation time-based ID if we can't read the GPG key ID
+		createdAt := p.Metadata.CreatedAt
+		return fmt.Sprintf("%s-pgp", createdAt.Format("2006-01-02.15.04"))
 	}
 	return fmt.Sprintf("%s-pgp", gpgKeyID)
 }
@@ -290,12 +286,8 @@ func CreatePGPUnlocker(fs afero.Fs, stateDir string, gpgKeyID string) (*PGPUnloc
 	}
 
 	// Step 9: Create and write enhanced metadata
-	// Generate the key ID directly using the GPG key ID
-	keyID := fmt.Sprintf("%s-pgp", gpgKeyID)
-
 	pgpMetadata := PGPUnlockerMetadata{
 		UnlockerMetadata: UnlockerMetadata{
-			ID:        keyID,
 			Type:      "pgp",
 			CreatedAt: time.Now(),
 			Flags:     []string{"gpg", "encrypted"},