Adopt repo standards: scaffold, policies, lint-clean (closes #1)
check / check (push) Failing after 1s

Add the standard scaffold and bring the tree to a clean lint under the
vendored `default: all` config. New: `script/` Scripts-to-Rule-Them-All
entrypoints with the `Makefile` reduced to thin shims; a `Dockerfile`
whose `lint` and `test` phases gate the build (final stage depends on
both); a `.gitea/workflows/` CI running `script/cibuild`; the vendored
`.golangci.yml`; `REPO_POLICIES.md`; `.editorconfig`; `.dockerignore`; a
`LICENSE` (WTFPL) and `TODO.md`; and a comprehensive `.gitignore`.

The 211 lint findings were fixed, not suppressed: package-level state
became functions/fields/a command constructor, magic numbers became named
constants, `ctx` is threaded into the probes, the loop functions were
split to cut complexity, and the deprecated `+build` tags were dropped.
Behavior is unchanged. The only annotations are justified `//nolint:gosec`
on the `ping`/`curl` subprocess calls (G204, fixed argv) and the
operator-chosen log file (G304), matching the reference repos.

`make check` is green (lint and tests run in Docker).

Model: opus-4-8
This commit is contained in:
2026-09-21 06:57:21 +00:00
parent cf9dc39053
commit 499c03abbc
34 changed files with 2167 additions and 884 deletions
+13 -24
View File
@@ -1,36 +1,25 @@
//go:build linux
// +build linux
package cli
package cli_test
import (
"testing"
"git.eeqj.de/sneak/rtnetmon/internal/cli"
)
// TestExecute tests that the CLI can be initialized
func TestExecute(t *testing.T) {
// This is a simple compilation test to ensure the CLI package compiles
// We can't easily test the full Execute() function as it starts the UI
func TestNewRootCmd(t *testing.T) {
t.Parallel()
// Test that rootCmd is properly initialized
if rootCmd == nil {
t.Fatal("rootCmd is nil")
cmd := cli.NewRootCmd()
if cmd.Use != "rtnetmon" {
t.Errorf("Use = %q, want %q", cmd.Use, "rtnetmon")
}
if rootCmd.Use != "rtnetmon" {
t.Errorf("Expected rootCmd.Use to be 'rtnetmon', got '%s'", rootCmd.Use)
}
// Test that default configuration is set
if len(defaultReachabilityHosts) == 0 {
t.Error("defaultReachabilityHosts is empty")
}
if len(defaultPacketLossHosts) == 0 {
t.Error("defaultPacketLossHosts is empty")
}
if len(defaultTCPHosts) == 0 {
t.Error("defaultTCPHosts is empty")
names := []string{"ifaceA", "labelA", "ifaceB", "labelB", "hosts", "logfile"}
for _, name := range names {
if cmd.Flags().Lookup(name) == nil {
t.Errorf("flag %q not registered", name)
}
}
}