sneak
f6850b8c09
check / check (push) Canceled after 0s
make asupdate piped the generator into gzip, so the target saw gzip's exit status. A failed download replaced pkg/asinfo/asdata.json.gz with an empty file and the target still exited 0. The target now runs the new script/asupdate. It writes the output of cmd/asinfo-gen to a temporary file. Only when the generator succeeds does it compress the list and move it into place. Otherwise it leaves the file alone and exits non-zero. The generator now fails when as.csv holds no AS. The generator reads as.csv from ipverse/as-metadata, the source's new name. The list it builds there is unchanged, so no new list is committed. Model: opus-5-5
74 lines
2.0 KiB
Go
74 lines
2.0 KiB
Go
package main
|
|
|
|
import (
|
|
"errors"
|
|
"slices"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// TestParseCSVReadsTodaysLayout parses an as.csv with the country code column
|
|
// that the source added after the description. It expects each AS with its
|
|
// handle and description spelled exactly as in the file, accents included.
|
|
func TestParseCSVReadsTodaysLayout(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
const asCSV = `asn,handle,description,country-code
|
|
1,LVLT-1,Level 3 Parent LLC,US
|
|
1251,FUNDACAO-AMPARO-PESQUISA,FUNDAÇÃO DE AMPARO À PESQUISA DO ESTADO SÃO PAULO,BR
|
|
`
|
|
|
|
got, err := parseCSV(strings.NewReader(asCSV))
|
|
if err != nil {
|
|
t.Fatalf("parseCSV: %v", err)
|
|
}
|
|
|
|
want := []ASInfo{
|
|
{ASN: 1, Handle: "LVLT-1", Description: "Level 3 Parent LLC"},
|
|
{
|
|
ASN: 1251,
|
|
Handle: "FUNDACAO-AMPARO-PESQUISA",
|
|
Description: "FUNDAÇÃO DE AMPARO À PESQUISA DO ESTADO " +
|
|
"SÃO PAULO",
|
|
},
|
|
}
|
|
|
|
if !slices.Equal(got, want) {
|
|
t.Errorf("parseCSV = %+v, want %+v", got, want)
|
|
}
|
|
}
|
|
|
|
// TestParseCSVRejectsAnotherHeader parses files whose first columns are not
|
|
// the AS number, the handle and the description. It expects an error rather
|
|
// than a list read from the wrong columns.
|
|
func TestParseCSVRejectsAnotherHeader(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
for _, asCSV := range []string{
|
|
"asn,handle\n1,LVLT-1\n",
|
|
"asn,description,handle\n1,Level 3 Parent LLC,LVLT-1\n",
|
|
} {
|
|
_, err := parseCSV(strings.NewReader(asCSV))
|
|
if err == nil {
|
|
t.Errorf("parseCSV(%q): no error", asCSV)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestParseCSVRejectsAFileWithNoASes parses files that hold no AS, one with
|
|
// only the header and one whose only record has no valid AS number. It
|
|
// expects errNoASes, so that make asupdate keeps the old list.
|
|
func TestParseCSVRejectsAFileWithNoASes(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
for _, asCSV := range []string{
|
|
"asn,handle,description,country-code\n",
|
|
"asn,handle,description,country-code\nAS1,LVLT-1,Level 3,US\n",
|
|
} {
|
|
_, err := parseCSV(strings.NewReader(asCSV))
|
|
if !errors.Is(err, errNoASes) {
|
|
t.Errorf("parseCSV(%q) = %v, want %v", asCSV, err, errNoASes)
|
|
}
|
|
}
|
|
}
|