clawbot
9024e8c16c
check / check (push) Successful in 2m42s
strconv.Atoi accepts a leading sign, so PORT=+9090 passed the check while the image's health check put "+9090" into its URL and failed. PORT is now parsed with strconv.ParseUint, which accepts only plain digits. Model: opus-5-5
63 lines
1.3 KiB
Go
63 lines
1.3 KiB
Go
package config
|
|
|
|
import (
|
|
"runtime"
|
|
"testing"
|
|
)
|
|
|
|
func TestNewReadsPort(t *testing.T) {
|
|
tests := map[string]int{
|
|
"": defaultPort,
|
|
"1": 1,
|
|
"9090": 9090,
|
|
"65535": 65535,
|
|
}
|
|
|
|
for value, want := range tests {
|
|
t.Run(value, func(t *testing.T) {
|
|
t.Setenv("PORT", value)
|
|
t.Setenv("XDG_DATA_HOME", "")
|
|
|
|
cfg, err := New()
|
|
if err != nil {
|
|
t.Fatalf("New() with PORT=%q: %v", value, err)
|
|
}
|
|
|
|
if cfg.Port != want {
|
|
t.Errorf("New() with PORT=%q: Port = %d, want %d", value, cfg.Port, want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNewRefusesInvalidPort(t *testing.T) {
|
|
for _, value := range []string{"0", "65536", "-1", "+9090", "http", "80.5"} {
|
|
t.Run(value, func(t *testing.T) {
|
|
t.Setenv("PORT", value)
|
|
t.Setenv("XDG_DATA_HOME", "")
|
|
|
|
if _, err := New(); err == nil {
|
|
t.Errorf("New() with PORT=%q returned no error", value)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNewRefusesRelativeXDGDataHome(t *testing.T) {
|
|
if runtime.GOOS == "darwin" {
|
|
t.Skip("macOS does not read XDG_DATA_HOME")
|
|
}
|
|
|
|
t.Setenv("PORT", "")
|
|
|
|
t.Setenv("XDG_DATA_HOME", "relative/path")
|
|
if _, err := New(); err == nil {
|
|
t.Error("New() with a relative XDG_DATA_HOME returned no error")
|
|
}
|
|
|
|
t.Setenv("XDG_DATA_HOME", "/var/lib")
|
|
if _, err := New(); err != nil {
|
|
t.Errorf("New() with XDG_DATA_HOME=/var/lib: %v", err)
|
|
}
|
|
}
|