clawbot
b4dee48401
check / check (push) Waiting to run
`Server.Start` opened its port inside a goroutine and returned nil at once, so a port already in use was only logged and the daemon kept running with no web server. It now opens the listener before returning and returns that error; serving runs in the background on the open listener. `CLIEntry` turns an error from `Run` into an fx shutdown with exit status 1, after the normal stop sequence, so a container restart policy can act. A serving error after a successful listen is still only logged. Model: opus-5-5
34 lines
1.0 KiB
Go
34 lines
1.0 KiB
Go
package server
|
|
|
|
import (
|
|
"context"
|
|
"net"
|
|
"testing"
|
|
|
|
"git.eeqj.de/sneak/routewatch/internal/config"
|
|
"git.eeqj.de/sneak/routewatch/internal/logger"
|
|
"git.eeqj.de/sneak/routewatch/internal/metrics"
|
|
"git.eeqj.de/sneak/routewatch/internal/streamer"
|
|
)
|
|
|
|
// TestStartFailsWhenPortIsHeld holds a port with a listener of its own and
|
|
// checks that Start on that port returns an error. Before the fix Start
|
|
// listened in a goroutine, only logged the failure and returned nil, so the
|
|
// daemon kept running without its web server.
|
|
func TestStartFailsWhenPortIsHeld(t *testing.T) {
|
|
held, err := net.Listen("tcp", ":0")
|
|
if err != nil {
|
|
t.Fatalf("failed to open the test listener: %v", err)
|
|
}
|
|
defer func() { _ = held.Close() }()
|
|
|
|
port := held.Addr().(*net.TCPAddr).Port
|
|
log := logger.New()
|
|
s := New(nil, streamer.New(log, metrics.New()), log, &config.Config{Port: port})
|
|
defer func() { _ = s.Stop(context.Background()) }()
|
|
|
|
if err := s.Start(); err == nil {
|
|
t.Fatalf("Start returned nil while port %d was held by another listener", port)
|
|
}
|
|
}
|