sneak/routewatch
1
0 Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Two tests fail on a loaded host: geo fallback timeout and home-card refresh #256

New Issue
Closed
opened 2026-11-11 01:09:00 +01:00 by clawbot · 1 comment
clawbot commented 2026-11-11 01:09:00 +01:00
Collaborator
Copy link
Copy source

make check on a fresh clone of next at 760ba47 failed twice in a row on sandcastle, a busy 48-core host:

  • internal/geo TestLookupFallsBackToTheDatabase, subtest timeout, both runs: locator_internal_test.go:417: 1 requests, want 2. The subtest gives the lookup a 50 ms time limit (shortTimeLimit). On a loaded host that limit can run out before the request reaches the fake geojs server, so the server records one request where the test expects two.
  • internal/server TestKeepHomeCardsFreshWorksThemOutEveryInterval, second run only, after 15.61 s.

So next is red on a loaded host. The tests should pass whatever the host's load, in the way #240 made the other tests do.

Definition of done

  • Neither test depends on how fast the host runs.
  • make check passes on a fresh clone of next.

Model: opus-5-5

`make check` on a fresh clone of `next` at `760ba47` failed twice in a row on sandcastle, a busy 48-core host: - `internal/geo` `TestLookupFallsBackToTheDatabase`, subtest `timeout`, both runs: `locator_internal_test.go:417: 1 requests, want 2`. The subtest gives the lookup a 50 ms time limit (`shortTimeLimit`). On a loaded host that limit can run out before the request reaches the fake geojs server, so the server records one request where the test expects two. - `internal/server` `TestKeepHomeCardsFreshWorksThemOutEveryInterval`, second run only, after 15.61 s. So `next` is red on a loaded host. The tests should pass whatever the host's load, in the way https://git.eeqj.de/sneak/routewatch/issues/240 made the other tests do. ## Definition of done - Neither test depends on how fast the host runs. - `make check` passes on a fresh clone of `next`. Model: opus-5-5
clawbot commented 2026-11-11 19:15:27 +01:00
Author
Collaborator
Copy link
Copy source

Built in #258, branch issue-256-load-independent-tests, test code only. The card refresh test runs on a fake clock; the geo timeout subtest counts requests as they are sent.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/routewatch/pulls/258, branch `issue-256-load-independent-tests`, test code only. The card refresh test runs on a fake clock; the geo `timeout` subtest counts requests as they are sent. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
needs-checks
needs-decision
needs-rebase
needs-review
needs-rework
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/routewatch#256