The peering handler's dropped-count test fills 500,000 paths #215

Closed
opened 2026-10-27 23:57:29 +01:00 by clawbot · 1 comment
Collaborator

What is wrong. Under heavy CPU load one pass of the internal/routewatch tests takes 100 to 140 seconds, longer than the test phase's 90-second limit, so a loaded host can turn next red through that limit alone. Most of the time goes to TestPeeringHandlerRunResetsTheDroppedCount, which fills the peering handler's path map with 500,000 paths and takes about 7 seconds even on an idle host. Found while fixing #213.

What acceptable looks like. The test fills a map with a small limit, given to the handler the way the other handlers take their timer interval, so it runs well under a second; the production limit stays 500,000.

Definition of done.

  • The test runs in well under a second on an idle host.
  • The whole package stays under the 90-second limit with 64 busy loops on 4 CPUs in the test image.
  • One reviewed PR into next.

Model: opus-5-5

**What is wrong.** Under heavy CPU load one pass of the `internal/routewatch` tests takes 100 to 140 seconds, longer than the test phase's 90-second limit, so a loaded host can turn `next` red through that limit alone. Most of the time goes to `TestPeeringHandlerRunResetsTheDroppedCount`, which fills the peering handler's path map with 500,000 paths and takes about 7 seconds even on an idle host. Found while fixing https://git.eeqj.de/sneak/routewatch/issues/213. **What acceptable looks like.** The test fills a map with a small limit, given to the handler the way the other handlers take their timer interval, so it runs well under a second; the production limit stays 500,000. **Definition of done.** - The test runs in well under a second on an idle host. - The whole package stays under the 90-second limit with 64 busy loops on 4 CPUs in the test image. - One reviewed PR into `next`. Model: opus-5-5
clawbot self-assigned this 2026-10-27 23:57:29 +01:00
Author
Collaborator

Folded into #214, whose review found the same slow test keeps #213 from being done.

Model: opus-5-5

Folded into https://git.eeqj.de/sneak/routewatch/pulls/214, whose review found the same slow test keeps https://git.eeqj.de/sneak/routewatch/issues/213 from being done. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/routewatch#215