Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
601bc812b9 |
No files matched your search
@@ -53,9 +53,6 @@ problem the run finds.
|
|||||||
|
|
||||||
# Completed Steps
|
# Completed Steps
|
||||||
|
|
||||||
- 2026-11-10: the tests no longer fail when a busy host stalls for several
|
|
||||||
seconds. Most such waits are now 15 seconds. The test of the stream's idle
|
|
||||||
timeout runs on a fake clock (closes #240)
|
|
||||||
- 2026-11-10: the IP lookup checks the public VPN server lists of Mullvad,
|
- 2026-11-10: the IP lookup checks the public VPN server lists of Mullvad,
|
||||||
NordVPN, Private Internet Access and IVPN, and X4BNet's community list. Each
|
NordVPN, Private Internet Access and IVPN, and X4BNet's community list. Each
|
||||||
result has `flags.is_vpn` and `vpn_providers` (closes
|
result has `flags.is_vpn` and `vpn_providers` (closes
|
||||||
|
|||||||
@@ -12,7 +12,7 @@ import (
|
|||||||
|
|
||||||
// parseTimeLimit is how long a test waits for parseCSV to return before it
|
// parseTimeLimit is how long a test waits for parseCSV to return before it
|
||||||
// fails.
|
// fails.
|
||||||
const parseTimeLimit = 15 * time.Second
|
const parseTimeLimit = 2 * time.Second
|
||||||
|
|
||||||
// TestParseCSVReadsTodaysLayout parses an as.csv with the country code column
|
// TestParseCSVReadsTodaysLayout parses an as.csv with the country code column
|
||||||
// that the source added after the description. It expects each AS with its
|
// that the source added after the description. It expects each AS with its
|
||||||
|
|||||||
@@ -72,34 +72,17 @@ const (
|
|||||||
// lockTestPrefix is the prefix the batch writes in the checkpoint tests
|
// lockTestPrefix is the prefix the batch writes in the checkpoint tests
|
||||||
// store.
|
// store.
|
||||||
lockTestPrefix = "192.0.2.0/24"
|
lockTestPrefix = "192.0.2.0/24"
|
||||||
// longBusyTimeoutMs is the busy timeout setLongBusyTimeout gives the
|
|
||||||
// writing connection. A checkpoint that waits for an open read takes this
|
|
||||||
// long.
|
|
||||||
longBusyTimeoutMs = 30000
|
|
||||||
// readerCheckpointLimit is how long a checkpoint, and a batch write
|
// readerCheckpointLimit is how long a checkpoint, and a batch write
|
||||||
// waiting for it, may take while a reader is open: well under
|
// waiting for it, may take while a reader is open: well under the busy
|
||||||
// longBusyTimeoutMs, with room for a stall on a busy host.
|
// timeout, which a checkpoint that waits for the reader takes.
|
||||||
readerCheckpointLimit = 15 * time.Second
|
readerCheckpointLimit = time.Second
|
||||||
// truncateCheckpointLimit is how long a checkpoint of a WAL file over
|
// truncateCheckpointLimit is how long a checkpoint of a WAL file over
|
||||||
// sqliteWALSizeLimitBytes may take to give up while a reader is open: its
|
// sqliteWALSizeLimitBytes may take to give up while a reader is open: its
|
||||||
// wait for the reader plus readerCheckpointLimit.
|
// wait for the reader plus a second, well under the busy timeout.
|
||||||
truncateCheckpointLimit = truncateBusyTimeoutMs*time.Millisecond +
|
truncateCheckpointLimit = truncateBusyTimeoutMs*time.Millisecond +
|
||||||
readerCheckpointLimit
|
time.Second
|
||||||
)
|
)
|
||||||
|
|
||||||
// setLongBusyTimeout gives the writing connection of db longBusyTimeoutMs, so
|
|
||||||
// that a checkpoint that waits for an open read takes far longer than a stall
|
|
||||||
// on a busy host.
|
|
||||||
func setLongBusyTimeout(ctx context.Context, t *testing.T, db *Database) {
|
|
||||||
t.Helper()
|
|
||||||
|
|
||||||
_, err := db.writer.ExecContext(ctx,
|
|
||||||
fmt.Sprintf("PRAGMA busy_timeout=%d", longBusyTimeoutMs))
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("failed to set the busy timeout: %v", err)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// TestConnectionPoolPragmas holds several pooled connections open at once and
|
// TestConnectionPoolPragmas holds several pooled connections open at once and
|
||||||
// checks each one carries the per-connection settings from the DSN, plus the
|
// checks each one carries the per-connection settings from the DSN, plus the
|
||||||
// process-wide heap limits, and sees the new file with auto_vacuum
|
// process-wide heap limits, and sees the new file with auto_vacuum
|
||||||
@@ -596,8 +579,6 @@ func TestCheckpointDoesNotWaitForReader(t *testing.T) {
|
|||||||
ctx := context.Background()
|
ctx := context.Background()
|
||||||
ts := time.Now().UTC()
|
ts := time.Now().UTC()
|
||||||
|
|
||||||
setLongBusyTimeout(ctx, t, db)
|
|
||||||
|
|
||||||
err = db.UpdatePrefixesBatch(map[string]time.Time{"198.51.100.0/24": ts})
|
err = db.UpdatePrefixesBatch(map[string]time.Time{"198.51.100.0/24": ts})
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("failed to store the prefix the reader reads: %v", err)
|
t.Fatalf("failed to store the prefix the reader reads: %v", err)
|
||||||
@@ -709,7 +690,6 @@ func TestCheckpointEmptiesWALOnceNoReadIsOpen(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
fillWALPastLimit(ctx, t, db)
|
fillWALPastLimit(ctx, t, db)
|
||||||
setLongBusyTimeout(ctx, t, db)
|
|
||||||
|
|
||||||
started := time.Now()
|
started := time.Now()
|
||||||
|
|
||||||
|
|||||||
@@ -646,13 +646,9 @@ func TestRestartLoadsCopiesFromDisk(t *testing.T) {
|
|||||||
second.Start(t.Context())
|
second.Start(t.Context())
|
||||||
second.Stop(t.Context())
|
second.Stop(t.Context())
|
||||||
|
|
||||||
// The download takes its time after writing the file, and the restart
|
|
||||||
// reads the file's time. A busy host can put seconds between the two.
|
|
||||||
const maxUpdatedDifference = 15 * time.Second
|
|
||||||
|
|
||||||
listings := lookup(t, second, listedAddr)
|
listings := lookup(t, second, listedAddr)
|
||||||
if len(listings) != 1 ||
|
if len(listings) != 1 ||
|
||||||
listings[0].Updated.Sub(downloaded).Abs() > maxUpdatedDifference {
|
listings[0].Updated.Sub(downloaded).Abs() > time.Second {
|
||||||
t.Errorf("after the restart, listings %+v, want one updated at %s",
|
t.Errorf("after the restart, listings %+v, want one updated at %s",
|
||||||
listings, downloaded)
|
listings, downloaded)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -17,7 +17,6 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
"sync/atomic"
|
"sync/atomic"
|
||||||
"testing"
|
"testing"
|
||||||
"testing/synctest"
|
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"git.eeqj.de/sneak/routewatch/internal/config"
|
"git.eeqj.de/sneak/routewatch/internal/config"
|
||||||
@@ -174,9 +173,6 @@ type tableStats struct {
|
|||||||
// carried 203.0.113.0/24, the two with kept routes withdrew it, so its origin
|
// carried 203.0.113.0/24, the two with kept routes withdrew it, so its origin
|
||||||
// keeps no route. The oldest and newest routes are those of the other two
|
// keeps no route. The oldest and newest routes are those of the other two
|
||||||
// prefixes.
|
// prefixes.
|
||||||
//
|
|
||||||
// The requests run in a synctest bubble, whose clock is fake, so a stall on
|
|
||||||
// the host does not use up the handlers' 4-second limit.
|
|
||||||
func TestStatsHandlersAnswerFromMemory(t *testing.T) {
|
func TestStatsHandlersAnswerFromMemory(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
@@ -222,11 +218,7 @@ func TestStatsHandlersAnswerFromMemory(t *testing.T) {
|
|||||||
|
|
||||||
for name, handler := range handlers {
|
for name, handler := range handlers {
|
||||||
rec := httptest.NewRecorder()
|
rec := httptest.NewRecorder()
|
||||||
|
handler(rec, httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/", nil))
|
||||||
synctest.Test(t, func(t *testing.T) {
|
|
||||||
handler(rec,
|
|
||||||
httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/", nil))
|
|
||||||
})
|
|
||||||
|
|
||||||
if rec.Code != http.StatusOK {
|
if rec.Code != http.StatusOK {
|
||||||
t.Errorf("%s: status %d, want %d; body %s",
|
t.Errorf("%s: status %d, want %d; body %s",
|
||||||
@@ -261,20 +253,15 @@ func TestStatsHandlersAnswerFromMemory(t *testing.T) {
|
|||||||
// TestStatsAnswerCarriesChurnPerMinute checks that the stream object of the
|
// TestStatsAnswerCarriesChurnPerMinute checks that the stream object of the
|
||||||
// /api/v1/stats answer holds route_churn_per_min as a whole number, and no
|
// /api/v1/stats answer holds route_churn_per_min as a whole number, and no
|
||||||
// longer route_churn_per_sec, the moving average it replaces
|
// longer route_churn_per_sec, the moving average it replaces
|
||||||
// (https://git.eeqj.de/sneak/routewatch/issues/160). The request runs in a
|
// (https://git.eeqj.de/sneak/routewatch/issues/160).
|
||||||
// synctest bubble, whose clock is fake, so a stall on the host does not use up
|
|
||||||
// the handler's 4-second limit.
|
|
||||||
func TestStatsAnswerCarriesChurnPerMinute(t *testing.T) {
|
func TestStatsAnswerCarriesChurnPerMinute(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
s := newServerWithTestRoutes(t)
|
s := newServerWithTestRoutes(t)
|
||||||
|
|
||||||
rec := httptest.NewRecorder()
|
rec := httptest.NewRecorder()
|
||||||
|
|
||||||
synctest.Test(t, func(t *testing.T) {
|
|
||||||
s.handleStats()(rec,
|
s.handleStats()(rec,
|
||||||
httptest.NewRequestWithContext(t.Context(), http.MethodGet, statsPath, nil))
|
httptest.NewRequestWithContext(t.Context(), http.MethodGet, statsPath, nil))
|
||||||
})
|
|
||||||
|
|
||||||
if rec.Code != http.StatusOK {
|
if rec.Code != http.StatusOK {
|
||||||
t.Fatalf("status %d, want %d; body %s", rec.Code, http.StatusOK, rec.Body)
|
t.Fatalf("status %d, want %d; body %s", rec.Code, http.StatusOK, rec.Body)
|
||||||
@@ -322,26 +309,18 @@ func (heldBackHandler) HeldBackCount() int { return heldBackMess
|
|||||||
|
|
||||||
// TestStatsAnswerGivesHowManyMessagesAHandlerHoldsBack registers a handler
|
// TestStatsAnswerGivesHowManyMessagesAHandlerHoldsBack registers a handler
|
||||||
// that holds back messages. Its figures in /api/v1/stats, which the status
|
// that holds back messages. Its figures in /api/v1/stats, which the status
|
||||||
// page shows, must give how many. The request runs in a synctest bubble, whose
|
// page shows, must give how many.
|
||||||
// clock is fake, so a stall on the host does not use up the handler's 4-second
|
|
||||||
// limit.
|
|
||||||
func TestStatsAnswerGivesHowManyMessagesAHandlerHoldsBack(t *testing.T) {
|
func TestStatsAnswerGivesHowManyMessagesAHandlerHoldsBack(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
s := newServerWithTestRoutes(t)
|
s := newServerWithTestRoutes(t)
|
||||||
s.streamer.RegisterHandler(heldBackHandler{})
|
s.streamer.RegisterHandler(heldBackHandler{})
|
||||||
|
|
||||||
var answer []byte
|
|
||||||
|
|
||||||
synctest.Test(t, func(t *testing.T) {
|
|
||||||
answer = get(t, s, statsPath).Body.Bytes()
|
|
||||||
})
|
|
||||||
|
|
||||||
var body struct {
|
var body struct {
|
||||||
Data StatsResponse `json:"data"`
|
Data StatsResponse `json:"data"`
|
||||||
}
|
}
|
||||||
|
|
||||||
err := json.Unmarshal(answer, &body)
|
err := json.Unmarshal(get(t, s, statsPath).Body.Bytes(), &body)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("decoding the answer: %v", err)
|
t.Fatalf("decoding the answer: %v", err)
|
||||||
}
|
}
|
||||||
@@ -385,9 +364,7 @@ type unitStats struct {
|
|||||||
// names. They used to be strings with the unit in them, such as "1h18m34s" or
|
// names. They used to be strings with the unit in them, such as "1h18m34s" or
|
||||||
// "1.1 GB" (https://git.eeqj.de/sneak/routewatch/issues/199). The stream has
|
// "1.1 GB" (https://git.eeqj.de/sneak/routewatch/issues/199). The stream has
|
||||||
// never connected, so the uptime is 0. The memory use in /api/v1/stats is the
|
// never connected, so the uptime is 0. The memory use in /api/v1/stats is the
|
||||||
// same number of bytes as its gc.heap_alloc_bytes. The requests run in a
|
// same number of bytes as its gc.heap_alloc_bytes.
|
||||||
// synctest bubble, whose clock is fake, so a stall on the host does not use up
|
|
||||||
// the handlers' 4-second limit.
|
|
||||||
func TestStatsAnswersGiveUnitsInFieldNames(t *testing.T) {
|
func TestStatsAnswersGiveUnitsInFieldNames(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
@@ -397,11 +374,7 @@ func TestStatsAnswersGiveUnitsInFieldNames(t *testing.T) {
|
|||||||
s.SetASNFetcher(fixedIntervalASNFetcher{interval: fetchInterval})
|
s.SetASNFetcher(fixedIntervalASNFetcher{interval: fetchInterval})
|
||||||
|
|
||||||
for _, path := range []string{statusJSONPath, statsPath} {
|
for _, path := range []string{statusJSONPath, statsPath} {
|
||||||
var answer []byte
|
answer := get(t, s, path).Body.Bytes()
|
||||||
|
|
||||||
synctest.Test(t, func(t *testing.T) {
|
|
||||||
answer = get(t, s, path).Body.Bytes()
|
|
||||||
})
|
|
||||||
|
|
||||||
var body struct {
|
var body struct {
|
||||||
Data unitStats `json:"data"`
|
Data unitStats `json:"data"`
|
||||||
@@ -442,15 +415,12 @@ func TestStatsAnswersGiveUnitsInFieldNames(t *testing.T) {
|
|||||||
// connection_duration_seconds of /api/v1/stats is null while the stream is not
|
// connection_duration_seconds of /api/v1/stats is null while the stream is not
|
||||||
// connected, and a whole number of seconds once it is. It used to be the
|
// connected, and a whole number of seconds once it is. It used to be the
|
||||||
// string "disconnected", or a Go duration such as "1h18m34s"
|
// string "disconnected", or a Go duration such as "1h18m34s"
|
||||||
// (https://git.eeqj.de/sneak/routewatch/issues/199). The test runs in a
|
// (https://git.eeqj.de/sneak/routewatch/issues/199).
|
||||||
// synctest bubble, whose clock is fake, so a stall on the host does not use up
|
|
||||||
// the handler's 4-second limit.
|
|
||||||
func TestStatsAnswerGivesConnectionDurationInSeconds(t *testing.T) {
|
func TestStatsAnswerGivesConnectionDurationInSeconds(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
s := newServerWithTestRoutes(t)
|
s := newServerWithTestRoutes(t)
|
||||||
|
|
||||||
synctest.Test(t, func(t *testing.T) {
|
|
||||||
connectionDuration := func() json.RawMessage {
|
connectionDuration := func() json.RawMessage {
|
||||||
answer := get(t, s, statsPath).Body.Bytes()
|
answer := get(t, s, statsPath).Body.Bytes()
|
||||||
|
|
||||||
@@ -488,18 +458,15 @@ func TestStatsAnswerGivesConnectionDurationInSeconds(t *testing.T) {
|
|||||||
t.Errorf("just connected: connection_duration_seconds = %s, want 0",
|
t.Errorf("just connected: connection_duration_seconds = %s, want 0",
|
||||||
connected)
|
connected)
|
||||||
}
|
}
|
||||||
})
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// TestStreamDurationsCountSeconds checks that the uptime and the connection
|
// TestStreamDurationsCountSeconds checks that the uptime and the connection
|
||||||
// duration of a stream that connected 90 seconds ago are both 90. A stream
|
// duration of a stream that connected 90 seconds ago are both 90. A stream
|
||||||
// that has never connected has an uptime of 0, and one that is not connected
|
// that has never connected has an uptime of 0, and one that is not connected
|
||||||
// has no connection duration. The test runs in a synctest bubble, whose clock
|
// has no connection duration.
|
||||||
// is fake, so a stall on the host does not add to the 90 seconds.
|
|
||||||
func TestStreamDurationsCountSeconds(t *testing.T) {
|
func TestStreamDurationsCountSeconds(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
synctest.Test(t, func(t *testing.T) {
|
|
||||||
const connectedFor = 90 * time.Second
|
const connectedFor = 90 * time.Second
|
||||||
|
|
||||||
connectedSince := time.Now().Add(-connectedFor)
|
connectedSince := time.Now().Add(-connectedFor)
|
||||||
@@ -524,7 +491,6 @@ func TestStreamDurationsCountSeconds(t *testing.T) {
|
|||||||
t.Errorf("connectionDurationSeconds while not connected = %d, want nil",
|
t.Errorf("connectionDurationSeconds while not connected = %d, want nil",
|
||||||
*got)
|
*got)
|
||||||
}
|
}
|
||||||
})
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// newTestTable returns a routing table that holds a route for testPrefixV4,
|
// newTestTable returns a routing table that holds a route for testPrefixV4,
|
||||||
@@ -1168,9 +1134,7 @@ func (failingDB) GetPrefixFirstSeen(
|
|||||||
// with the driver's error text. It also sends a prefix that does not parse.
|
// with the driver's error text. It also sends a prefix that does not parse.
|
||||||
// No answer may carry the driver's or the prefix parser's text. Before the fix
|
// No answer may carry the driver's or the prefix parser's text. Before the fix
|
||||||
// the answers sent it to the client
|
// the answers sent it to the client
|
||||||
// (https://git.eeqj.de/sneak/routewatch/issues/108). The requests run in a
|
// (https://git.eeqj.de/sneak/routewatch/issues/108).
|
||||||
// synctest bubble, whose clock is fake, so a stall on the host does not use up
|
|
||||||
// the stats handlers' 4-second limit.
|
|
||||||
func TestJSONRoutesDoNotSendErrorDetails(t *testing.T) {
|
func TestJSONRoutesDoNotSendErrorDetails(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
@@ -1191,11 +1155,8 @@ func TestJSONRoutesDoNotSendErrorDetails(t *testing.T) {
|
|||||||
|
|
||||||
for _, tt := range tests {
|
for _, tt := range tests {
|
||||||
rec := httptest.NewRecorder()
|
rec := httptest.NewRecorder()
|
||||||
|
|
||||||
synctest.Test(t, func(t *testing.T) {
|
|
||||||
s.router.ServeHTTP(rec, httptest.NewRequestWithContext(
|
s.router.ServeHTTP(rec, httptest.NewRequestWithContext(
|
||||||
t.Context(), http.MethodGet, tt.path, nil))
|
t.Context(), http.MethodGet, tt.path, nil))
|
||||||
})
|
|
||||||
|
|
||||||
if rec.Code != tt.wantCode {
|
if rec.Code != tt.wantCode {
|
||||||
t.Errorf("%s: status %d, want %d; body %s",
|
t.Errorf("%s: status %d, want %d; body %s",
|
||||||
@@ -1436,11 +1397,8 @@ func TestIPLookupKeepsRouteWhenPTRLookupDoesNotAnswer(t *testing.T) {
|
|||||||
s := newServerWithTestRoutes(t)
|
s := newServerWithTestRoutes(t)
|
||||||
s.resolver = &fakeResolver{ptrNeverAnswers: true}
|
s.resolver = &fakeResolver{ptrNeverAnswers: true}
|
||||||
|
|
||||||
// The request's time limit passes well after the PTR lookup's, so that a
|
// The request's time limit passes after the PTR lookup's.
|
||||||
// stall on a busy host does not use up the difference.
|
ctx, cancel := context.WithTimeout(t.Context(), 2*ptrLookupTimeout)
|
||||||
const requestTimeLimit = ptrLookupTimeout + 15*time.Second
|
|
||||||
|
|
||||||
ctx, cancel := context.WithTimeout(t.Context(), requestTimeLimit)
|
|
||||||
defer cancel()
|
defer cancel()
|
||||||
|
|
||||||
rec := httptest.NewRecorder()
|
rec := httptest.NewRecorder()
|
||||||
@@ -2409,13 +2367,9 @@ func settledGoroutineCount() int {
|
|||||||
return prev
|
return prev
|
||||||
}
|
}
|
||||||
|
|
||||||
// waitForGoroutines waits up to 15 seconds for the goroutine count to drop to
|
// waitForGoroutines waits until the goroutine count drops to target or below.
|
||||||
// target or below.
|
|
||||||
func waitForGoroutines(target int) bool {
|
func waitForGoroutines(target int) bool {
|
||||||
const maxWait = 15 * time.Second
|
for range 100 {
|
||||||
|
|
||||||
deadline := time.Now().Add(maxWait)
|
|
||||||
for time.Now().Before(deadline) {
|
|
||||||
if runtime.NumGoroutine() <= target {
|
if runtime.NumGoroutine() <= target {
|
||||||
return true
|
return true
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -76,9 +76,7 @@ func asLink(asn int) string {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// TestHomePageCardsShowTheTableFigures fills a routing table and the asns
|
// TestHomePageCardsShowTheTableFigures fills a routing table and the asns
|
||||||
// table, works out the cards, and checks that each card shows its figure. The
|
// table, works out the cards, and checks that each card shows its figure.
|
||||||
// cards are worked out in a synctest bubble, whose clock is fake, so a stall on
|
|
||||||
// the host does not use up the 4-second limit on their database read.
|
|
||||||
func TestHomePageCardsShowTheTableFigures(t *testing.T) {
|
func TestHomePageCardsShowTheTableFigures(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
@@ -97,9 +95,7 @@ func TestHomePageCardsShowTheTableFigures(t *testing.T) {
|
|||||||
t.Fatalf("GetOrCreateASNBatch: %v", err)
|
t.Fatalf("GetOrCreateASNBatch: %v", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
synctest.Test(t, func(t *testing.T) {
|
|
||||||
s.refreshHomeCards(t.Context())
|
s.refreshHomeCards(t.Context())
|
||||||
})
|
|
||||||
|
|
||||||
page := get(t, s, "/").Body.String()
|
page := get(t, s, "/").Body.String()
|
||||||
|
|
||||||
@@ -283,7 +279,7 @@ func TestKeepHomeCardsFreshWorksThemOutEveryInterval(t *testing.T) {
|
|||||||
|
|
||||||
const (
|
const (
|
||||||
interval = 10 * time.Millisecond
|
interval = 10 * time.Millisecond
|
||||||
maxWait = 15 * time.Second
|
maxWait = 5 * time.Second
|
||||||
)
|
)
|
||||||
|
|
||||||
table := emptyTable()
|
table := emptyTable()
|
||||||
@@ -325,7 +321,7 @@ func TestKeepHomeCardsFreshWorksThemOutEveryInterval(t *testing.T) {
|
|||||||
func TestStartedServerWorksOutTheCards(t *testing.T) {
|
func TestStartedServerWorksOutTheCards(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
const maxWait = 15 * time.Second
|
const maxWait = 5 * time.Second
|
||||||
|
|
||||||
s := newServerWithTable(t, newCardsTable())
|
s := newServerWithTable(t, newCardsTable())
|
||||||
|
|
||||||
|
|||||||
@@ -14,7 +14,6 @@ import (
|
|||||||
"regexp"
|
"regexp"
|
||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
"testing/synctest"
|
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"git.eeqj.de/sneak/routewatch/internal/config"
|
"git.eeqj.de/sneak/routewatch/internal/config"
|
||||||
@@ -164,10 +163,6 @@ func TestJSONAnswersPutNoUnitInAString(t *testing.T) {
|
|||||||
// router and the middleware write. Before the fix a panic in a handler, and a
|
// router and the middleware write. Before the fix a panic in a handler, and a
|
||||||
// method /status.json or the health check does not take, answered with an
|
// method /status.json or the health check does not take, answered with an
|
||||||
// empty body (https://git.eeqj.de/sneak/routewatch/issues/201).
|
// empty body (https://git.eeqj.de/sneak/routewatch/issues/201).
|
||||||
//
|
|
||||||
// The requests run in a synctest bubble, whose clock is fake, so a stall on
|
|
||||||
// the host does not use up the 2-second limit of the health check or the
|
|
||||||
// 4-second limit of the stats handlers.
|
|
||||||
func TestJSONAnswersCarryMeta(t *testing.T) {
|
func TestJSONAnswersCarryMeta(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
@@ -186,10 +181,6 @@ func TestJSONAnswersCarryMeta(t *testing.T) {
|
|||||||
s.router.Get(panicsPath, JSONValidationMiddleware(http.HandlerFunc(
|
s.router.Get(panicsPath, JSONValidationMiddleware(http.HandlerFunc(
|
||||||
func(http.ResponseWriter, *http.Request) { panic(errDiskIO) })).ServeHTTP)
|
func(http.ResponseWriter, *http.Request) { panic(errDiskIO) })).ServeHTTP)
|
||||||
|
|
||||||
failing := New(failingDB{}, newTestTable(),
|
|
||||||
streamer.New(logger.New(), metrics.New()), logger.New(), &config.Config{})
|
|
||||||
failing.resolver = &fakeResolver{}
|
|
||||||
|
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
method string
|
method string
|
||||||
path string
|
path string
|
||||||
@@ -225,15 +216,14 @@ func TestJSONAnswersCarryMeta(t *testing.T) {
|
|||||||
{http.MethodGet, panicsPath, http.StatusInternalServerError},
|
{http.MethodGet, panicsPath, http.StatusInternalServerError},
|
||||||
}
|
}
|
||||||
|
|
||||||
synctest.Test(t, func(t *testing.T) {
|
|
||||||
for _, tt := range tests {
|
for _, tt := range tests {
|
||||||
checkAnswerCarriesMeta(t, s, httptest.NewRequestWithContext(
|
checkAnswerCarriesMeta(t, s, httptest.NewRequestWithContext(
|
||||||
t.Context(), tt.method, tt.path, nil), tt.wantCode)
|
t.Context(), tt.method, tt.path, nil), tt.wantCode)
|
||||||
}
|
}
|
||||||
|
|
||||||
// A request whose time limit has already passed answers 504. The
|
// A request whose time limit has already passed answers 504. The handlers
|
||||||
// handlers write the answers of the first five routes, and the JSON
|
// write the answers of the first five routes, and the JSON check on the
|
||||||
// check on the route writes the last.
|
// route writes the last.
|
||||||
pastTimeLimit, cancel := context.WithDeadline(t.Context(), time.Now())
|
pastTimeLimit, cancel := context.WithDeadline(t.Context(), time.Now())
|
||||||
defer cancel()
|
defer cancel()
|
||||||
|
|
||||||
@@ -245,8 +235,12 @@ func TestJSONAnswersCarryMeta(t *testing.T) {
|
|||||||
pastTimeLimit, http.MethodGet, path, nil), http.StatusGatewayTimeout)
|
pastTimeLimit, http.MethodGet, path, nil), http.StatusGatewayTimeout)
|
||||||
}
|
}
|
||||||
|
|
||||||
// With a store whose reads fail, the health check answers 503, and
|
// With a store whose reads fail, the health check answers 503, and the
|
||||||
// the handlers of the other routes 500.
|
// handlers of the other routes 500.
|
||||||
|
failing := New(failingDB{}, newTestTable(),
|
||||||
|
streamer.New(logger.New(), metrics.New()), logger.New(), &config.Config{})
|
||||||
|
failing.resolver = &fakeResolver{}
|
||||||
|
|
||||||
checkAnswerCarriesMeta(t, failing, httptest.NewRequestWithContext(
|
checkAnswerCarriesMeta(t, failing, httptest.NewRequestWithContext(
|
||||||
t.Context(), http.MethodGet, healthCheckPath, nil),
|
t.Context(), http.MethodGet, healthCheckPath, nil),
|
||||||
http.StatusServiceUnavailable)
|
http.StatusServiceUnavailable)
|
||||||
@@ -258,7 +252,6 @@ func TestJSONAnswersCarryMeta(t *testing.T) {
|
|||||||
checkAnswerCarriesMeta(t, failing, httptest.NewRequestWithContext(
|
checkAnswerCarriesMeta(t, failing, httptest.NewRequestWithContext(
|
||||||
t.Context(), http.MethodGet, path, nil), http.StatusInternalServerError)
|
t.Context(), http.MethodGet, path, nil), http.StatusInternalServerError)
|
||||||
}
|
}
|
||||||
})
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// checkAnswerCarriesMeta serves req through the server's router, and checks
|
// checkAnswerCarriesMeta serves req through the server's router, and checks
|
||||||
|
|||||||
@@ -5,7 +5,6 @@ import (
|
|||||||
"net/http"
|
"net/http"
|
||||||
"net/http/httptest"
|
"net/http/httptest"
|
||||||
"testing"
|
"testing"
|
||||||
"testing/synctest"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
// TestRoutesAnswerHEAD sends HEAD for a page and JSON routes through the
|
// TestRoutesAnswerHEAD sends HEAD for a page and JSON routes through the
|
||||||
@@ -13,23 +12,15 @@ import (
|
|||||||
// lookup of the caller's own address, are in the list because chi's GetHead
|
// lookup of the caller's own address, are in the list because chi's GetHead
|
||||||
// does not reach them. Before the fix every route answered HEAD with 405
|
// does not reach them. Before the fix every route answered HEAD with 405
|
||||||
// (https://git.eeqj.de/sneak/routewatch/issues/111).
|
// (https://git.eeqj.de/sneak/routewatch/issues/111).
|
||||||
//
|
|
||||||
// The requests run in a synctest bubble, whose clock is fake, so a stall on
|
|
||||||
// the host does not use up the stats handlers' 4-second limit. The resolver
|
|
||||||
// is fake because no time limit would cut off a real DNS lookup in a bubble.
|
|
||||||
func TestRoutesAnswerHEAD(t *testing.T) {
|
func TestRoutesAnswerHEAD(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
s := newServerWithTestRoutes(t)
|
s := newServerWithTestRoutes(t)
|
||||||
s.resolver = &fakeResolver{}
|
|
||||||
|
|
||||||
for _, path := range []string{"/", statusJSONPath, statsPath, "/ip", "/ip/"} {
|
for _, path := range []string{"/", statusJSONPath, statsPath, "/ip", "/ip/"} {
|
||||||
rec := httptest.NewRecorder()
|
rec := httptest.NewRecorder()
|
||||||
|
|
||||||
synctest.Test(t, func(t *testing.T) {
|
|
||||||
s.router.ServeHTTP(rec, httptest.NewRequestWithContext(
|
s.router.ServeHTTP(rec, httptest.NewRequestWithContext(
|
||||||
t.Context(), http.MethodHead, path, nil))
|
t.Context(), http.MethodHead, path, nil))
|
||||||
})
|
|
||||||
|
|
||||||
if rec.Code != http.StatusOK {
|
if rec.Code != http.StatusOK {
|
||||||
t.Errorf("HEAD %s: status %d, want %d; body %s",
|
t.Errorf("HEAD %s: status %d, want %d; body %s",
|
||||||
|
|||||||
@@ -22,10 +22,10 @@ func TestStopClosesTheConnectionOfARequestStillRunning(t *testing.T) {
|
|||||||
stopDeadline = 100 * time.Millisecond
|
stopDeadline = 100 * time.Millisecond
|
||||||
// waitTimeout is how long the test waits for the request to reach
|
// waitTimeout is how long the test waits for the request to reach
|
||||||
// the handler, and then for the client to see its connection closed.
|
// the handler, and then for the client to see its connection closed.
|
||||||
waitTimeout = 15 * time.Second
|
waitTimeout = 2 * time.Second
|
||||||
// readHeaderTimeout bounds the test server's read of the request
|
// readHeaderTimeout bounds the test server's read of the request
|
||||||
// header, as every http.Server must.
|
// header, as every http.Server must.
|
||||||
readHeaderTimeout = waitTimeout
|
readHeaderTimeout = time.Second
|
||||||
)
|
)
|
||||||
|
|
||||||
release := make(chan struct{})
|
release := make(chan struct{})
|
||||||
|
|||||||
@@ -14,7 +14,6 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
"sync/atomic"
|
"sync/atomic"
|
||||||
"testing"
|
"testing"
|
||||||
"testing/synctest"
|
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"git.eeqj.de/sneak/routewatch/internal/logger"
|
"git.eeqj.de/sneak/routewatch/internal/logger"
|
||||||
@@ -399,7 +398,7 @@ func TestStopQueuesTheHeldStateMessages(t *testing.T) {
|
|||||||
const (
|
const (
|
||||||
held = 2
|
held = 2
|
||||||
lines = held + 1
|
lines = held + 1
|
||||||
maxWait = 15 * time.Second
|
maxWait = 5 * time.Second
|
||||||
)
|
)
|
||||||
|
|
||||||
srv := httptest.NewServer(http.HandlerFunc(
|
srv := httptest.NewServer(http.HandlerFunc(
|
||||||
@@ -479,15 +478,15 @@ func TestStopQueuesTheHeldStateMessages(t *testing.T) {
|
|||||||
// TestStopReturnsByItsDeadline stops a streamer whose handler has a full queue
|
// TestStopReturnsByItsDeadline stops a streamer whose handler has a full queue
|
||||||
// and a STATE message held for it, and a worker that stays busy until the test
|
// and a STATE message held for it, and a worker that stays busy until the test
|
||||||
// ends, as one does whose handler waits for a database write. Stop must return
|
// ends, as one does whose handler waits for a database write. Stop must return
|
||||||
// within its deadline plus a margin instead of waiting for room on the queue
|
// within its deadline plus a small margin instead of waiting for room on the
|
||||||
// and for the worker, and log as not handed over the held message and every
|
// queue and for the worker, and log as not handed over the held message and
|
||||||
// message on the queue.
|
// every message on the queue.
|
||||||
func TestStopReturnsByItsDeadline(t *testing.T) {
|
func TestStopReturnsByItsDeadline(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
const (
|
const (
|
||||||
deadline = 100 * time.Millisecond
|
deadline = 100 * time.Millisecond
|
||||||
margin = 15 * time.Second
|
margin = 2 * time.Second
|
||||||
)
|
)
|
||||||
|
|
||||||
var logs bytes.Buffer
|
var logs bytes.Buffer
|
||||||
@@ -578,7 +577,7 @@ func TestStopBeforeMessageReachesQueues(t *testing.T) {
|
|||||||
func TestReconnectWhenStreamEnds(t *testing.T) {
|
func TestReconnectWhenStreamEnds(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
endResponse := pipeTransport{write: func(context.Context, io.Writer) {}}
|
endResponse := func(http.ResponseWriter, *http.Request) {}
|
||||||
checkReconnect(t, endResponse, streamIdleTimeout)
|
checkReconnect(t, endResponse, streamIdleTimeout)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -590,8 +589,9 @@ func TestReconnectWhenStreamGoesIdle(t *testing.T) {
|
|||||||
|
|
||||||
const idleTimeout = 50 * time.Millisecond
|
const idleTimeout = 50 * time.Millisecond
|
||||||
|
|
||||||
holdResponse := pipeTransport{
|
holdResponse := func(w http.ResponseWriter, r *http.Request) {
|
||||||
write: func(ctx context.Context, _ io.Writer) { <-ctx.Done() },
|
flush(w)
|
||||||
|
<-r.Context().Done()
|
||||||
}
|
}
|
||||||
checkReconnect(t, holdResponse, idleTimeout)
|
checkReconnect(t, holdResponse, idleTimeout)
|
||||||
}
|
}
|
||||||
@@ -604,51 +604,16 @@ func TestReconnectWhenServerNeverAnswers(t *testing.T) {
|
|||||||
|
|
||||||
const idleTimeout = 50 * time.Millisecond
|
const idleTimeout = 50 * time.Millisecond
|
||||||
|
|
||||||
neverAnswer := roundTripFunc(
|
neverAnswer := func(_ http.ResponseWriter, r *http.Request) {
|
||||||
func(req *http.Request) (*http.Response, error) {
|
<-r.Context().Done()
|
||||||
<-req.Context().Done()
|
}
|
||||||
|
|
||||||
return nil, req.Context().Err()
|
|
||||||
},
|
|
||||||
)
|
|
||||||
checkReconnect(t, neverAnswer, idleTimeout)
|
checkReconnect(t, neverAnswer, idleTimeout)
|
||||||
}
|
}
|
||||||
|
|
||||||
// pipeTransport answers every request with a response whose body write fills.
|
// TestStreamNotDroppedWhileLinesArrive has the server send lines well within
|
||||||
// The body fails when the request's context ends, as a connection's does.
|
// the idle timeout for several times the timeout, then end the response. Each
|
||||||
// write gets that context, so that it can end when the request does.
|
// line must start the idle timeout over, so the stream lasts until the server
|
||||||
type pipeTransport struct {
|
// ends it instead of being dropped as idle.
|
||||||
write func(context.Context, io.Writer)
|
|
||||||
}
|
|
||||||
|
|
||||||
func (p pipeTransport) RoundTrip(req *http.Request) (*http.Response, error) {
|
|
||||||
body, w := io.Pipe()
|
|
||||||
|
|
||||||
context.AfterFunc(req.Context(), func() {
|
|
||||||
_ = w.CloseWithError(req.Context().Err())
|
|
||||||
})
|
|
||||||
|
|
||||||
go func(ctx context.Context) {
|
|
||||||
p.write(ctx, w)
|
|
||||||
|
|
||||||
_ = w.Close()
|
|
||||||
}(req.Context())
|
|
||||||
|
|
||||||
return &http.Response{StatusCode: http.StatusOK, Body: body}, nil
|
|
||||||
}
|
|
||||||
|
|
||||||
// roundTripFunc makes a function an http.RoundTripper.
|
|
||||||
type roundTripFunc func(*http.Request) (*http.Response, error)
|
|
||||||
|
|
||||||
func (f roundTripFunc) RoundTrip(req *http.Request) (*http.Response, error) {
|
|
||||||
return f(req)
|
|
||||||
}
|
|
||||||
|
|
||||||
// TestStreamNotDroppedWhileLinesArrive has a response send lines well within
|
|
||||||
// the idle timeout for several times the timeout, then end. Each line must
|
|
||||||
// start the idle timeout over, so the stream lasts until the response ends
|
|
||||||
// instead of being dropped as idle. It runs in a synctest bubble, whose clock
|
|
||||||
// is fake, so a stall on the host does not use up the timeout.
|
|
||||||
func TestStreamNotDroppedWhileLinesArrive(t *testing.T) {
|
func TestStreamNotDroppedWhileLinesArrive(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
@@ -658,35 +623,26 @@ func TestStreamNotDroppedWhileLinesArrive(t *testing.T) {
|
|||||||
sendFor = 5 * idleTimeout
|
sendFor = 5 * idleTimeout
|
||||||
)
|
)
|
||||||
|
|
||||||
// The streamer is made outside the bubble. Its metrics start a goroutine
|
srv := httptest.NewServer(http.HandlerFunc(
|
||||||
// that never returns, and a bubble waits for each of its goroutines to
|
func(w http.ResponseWriter, _ *http.Request) {
|
||||||
// return.
|
|
||||||
s := New(logger.New(), metrics.New())
|
|
||||||
s.idleTimeout = idleTimeout
|
|
||||||
s.client = &http.Client{Transport: pipeTransport{
|
|
||||||
write: func(ctx context.Context, w io.Writer) {
|
|
||||||
deadline := time.Now().Add(sendFor)
|
deadline := time.Now().Add(sendFor)
|
||||||
for time.Now().Before(deadline) {
|
for time.Now().Before(deadline) {
|
||||||
_, _ = io.WriteString(w, updateLine)
|
_, _ = io.WriteString(w, updateLine)
|
||||||
|
|
||||||
// The wait ends with the stream. A bubble's clock stops when
|
flush(w)
|
||||||
// the test function returns, and a goroutine then still
|
time.Sleep(lineInterval)
|
||||||
// asleep panics the test binary.
|
|
||||||
select {
|
|
||||||
case <-ctx.Done():
|
|
||||||
return
|
|
||||||
case <-time.After(lineInterval):
|
|
||||||
}
|
}
|
||||||
}
|
}))
|
||||||
},
|
defer srv.Close()
|
||||||
}}
|
|
||||||
|
s := New(logger.New(), metrics.New())
|
||||||
|
s.url = srv.URL
|
||||||
|
s.idleTimeout = idleTimeout
|
||||||
|
|
||||||
synctest.Test(t, func(t *testing.T) {
|
|
||||||
err := s.stream(context.Background())
|
err := s.stream(context.Background())
|
||||||
if !errors.Is(err, errStreamEnded) {
|
if !errors.Is(err, errStreamEnded) {
|
||||||
t.Fatalf("stream returned %v, want %v", err, errStreamEnded)
|
t.Fatalf("stream returned %v, want %v", err, errStreamEnded)
|
||||||
}
|
}
|
||||||
})
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// TestStreamReadsLongLine has the server send one UPDATE line of about
|
// TestStreamReadsLongLine has the server send one UPDATE line of about
|
||||||
@@ -750,7 +706,7 @@ func TestHandlerStatsReadWhileMessagesAreDropped(t *testing.T) {
|
|||||||
const (
|
const (
|
||||||
lines = 5
|
lines = 5
|
||||||
wantDropped = lines - 2
|
wantDropped = lines - 2
|
||||||
maxWait = 15 * time.Second
|
maxWait = 5 * time.Second
|
||||||
)
|
)
|
||||||
|
|
||||||
srv := httptest.NewServer(http.HandlerFunc(
|
srv := httptest.NewServer(http.HandlerFunc(
|
||||||
@@ -864,38 +820,24 @@ func streamLines(t *testing.T, s *Streamer, lines string) {
|
|||||||
// line and then stays open. The streamer must come back for a second
|
// line and then stays open. The streamer must come back for a second
|
||||||
// response, must not be marked connected when it does, and must handle the
|
// response, must not be marked connected when it does, and must handle the
|
||||||
// UPDATE in it.
|
// UPDATE in it.
|
||||||
//
|
|
||||||
// It runs in a synctest bubble, whose clock is fake, so a stall on the host
|
|
||||||
// does not use up the idle timeout. The fake server gets the requests in the
|
|
||||||
// order the streamer makes them, because no real connection carries them.
|
|
||||||
func checkReconnect(
|
func checkReconnect(
|
||||||
t *testing.T, firstResponse http.RoundTripper, idleTimeout time.Duration,
|
t *testing.T, firstResponse http.HandlerFunc, idleTimeout time.Duration,
|
||||||
) {
|
) {
|
||||||
t.Helper()
|
t.Helper()
|
||||||
|
|
||||||
const maxWait = 15 * time.Second
|
const maxWait = 5 * time.Second
|
||||||
|
|
||||||
// The tracker is made outside the bubble. It starts a goroutine that never
|
|
||||||
// returns, and a bubble waits for each of its goroutines to return.
|
|
||||||
tracker := metrics.New()
|
tracker := metrics.New()
|
||||||
|
|
||||||
synctest.Test(t, func(t *testing.T) {
|
|
||||||
connectedAtReconnect := make(chan bool, 1)
|
connectedAtReconnect := make(chan bool, 1)
|
||||||
laterResponse := pipeTransport{
|
|
||||||
write: func(ctx context.Context, w io.Writer) {
|
|
||||||
_, _ = io.WriteString(w, updateLine)
|
|
||||||
|
|
||||||
<-ctx.Done()
|
|
||||||
},
|
|
||||||
}
|
|
||||||
|
|
||||||
var requests atomic.Int32
|
var requests atomic.Int32
|
||||||
|
|
||||||
s := New(logger.New(), tracker)
|
srv := httptest.NewServer(http.HandlerFunc(
|
||||||
s.client = &http.Client{Transport: roundTripFunc(
|
func(w http.ResponseWriter, r *http.Request) {
|
||||||
func(req *http.Request) (*http.Response, error) {
|
|
||||||
if requests.Add(1) == 1 {
|
if requests.Add(1) == 1 {
|
||||||
return firstResponse.RoundTrip(req)
|
firstResponse(w, r)
|
||||||
|
|
||||||
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
select {
|
select {
|
||||||
@@ -903,9 +845,15 @@ func checkReconnect(
|
|||||||
default:
|
default:
|
||||||
}
|
}
|
||||||
|
|
||||||
return laterResponse.RoundTrip(req)
|
_, _ = io.WriteString(w, updateLine)
|
||||||
},
|
|
||||||
)}
|
flush(w)
|
||||||
|
<-r.Context().Done()
|
||||||
|
}))
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
s := New(logger.New(), tracker)
|
||||||
|
s.url = srv.URL
|
||||||
s.idleTimeout = idleTimeout
|
s.idleTimeout = idleTimeout
|
||||||
s.minBackoff = time.Millisecond
|
s.minBackoff = time.Millisecond
|
||||||
handler := updateHandler{handled: make(chan struct{}, 1)}
|
handler := updateHandler{handled: make(chan struct{}, 1)}
|
||||||
@@ -927,7 +875,6 @@ func checkReconnect(
|
|||||||
t.Error("streamer was still marked connected when it came back " +
|
t.Error("streamer was still marked connected when it came back " +
|
||||||
"for a second response")
|
"for a second response")
|
||||||
}
|
}
|
||||||
})
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// settledGoroutineCount lets transient goroutines finish, then reports the
|
// settledGoroutineCount lets transient goroutines finish, then reports the
|
||||||
@@ -949,13 +896,9 @@ func settledGoroutineCount() int {
|
|||||||
return prev
|
return prev
|
||||||
}
|
}
|
||||||
|
|
||||||
// waitForGoroutines waits up to 15 seconds for the goroutine count to drop to
|
// waitForGoroutines waits until the goroutine count drops to target or below.
|
||||||
// target or below.
|
|
||||||
func waitForGoroutines(target int) bool {
|
func waitForGoroutines(target int) bool {
|
||||||
const maxWait = 15 * time.Second
|
for range 100 {
|
||||||
|
|
||||||
deadline := time.Now().Add(maxWait)
|
|
||||||
for time.Now().Before(deadline) {
|
|
||||||
if runtime.NumGoroutine() <= target {
|
if runtime.NumGoroutine() <= target {
|
||||||
return true
|
return true
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in new issue
Block a user