Bound each shutdown stage by the stop deadline (closes #100)

Shutdown passes its context to every stage: the streamer, the four
handlers, the WHOIS fetcher, the database maintainer and the HTTP server
each stop waiting when it ends. A handler then skips its last write and
logs how many updates it did not write, and the HTTP server closes the
connections still open. The database is checkpointed and closed last,
and left open once the deadline has passed, since a write may still
hold it. The stop hook gives Shutdown 8 seconds and fx 9, inside the 10
seconds upaas and docker stop allow, so a stop signal exits 0.

Model: opus-5-5

README.md

@@ -54,9 +54,8 @@ DEBUG=routewatch ./routewatch
   picked at random, each with its newest route (HTML)
 - `GET /prefixlength6/{length}` - The same for IPv6
 - `GET /ip/{addr}` - The same JSON answer as `/api/v1/ip/{ip}`
-- `GET /ip/` - The same, for the caller's own address: the address the request
+- `GET /ip/` - The same, for the caller's own address, or the one a proxy names
-  came from or, when that is a trusted proxy (`TRUSTED_PROXIES`, see
+  in `True-Client-IP`, `X-Real-IP` or `X-Forwarded-For`
-  Configuration), the client address in its `X-Forwarded-For`
 
 ### API v1
 
@@ -85,17 +84,7 @@ and 4 seconds for the database reads behind `/status.json` and `/api/v1/stats`.
 An AS number, prefix or mask length that does not parse answers 400, as does a
 mask length out of range for its IP version. An AS the database does not hold,
 or a prefix with no live route, answers 404. The HTML pages give these errors as
-plain text. A 500 answer says only `Internal server error`, and a host name that
+plain text.
-does not resolve only `could not resolve host name`; the detail goes to the log.
-
-Every answer carries `Strict-Transport-Security`, `Content-Security-Policy`,
-`X-Frame-Options`, `X-Content-Type-Options`, `Referrer-Policy` and
-`Permissions-Policy`. The Content-Security-Policy lets a page load content only
-from the server, and does not allow inline content with `'unsafe-inline'`: the
-pages keep their CSS and JavaScript in inline `<style>` and `<script>` blocks,
-so each answer's policy names a random nonce made for that answer, and the
-browser applies or runs only the blocks that carry it. The pages therefore use
-no `style` attributes, which a nonce cannot cover.
 
 An origin AS of 0 (`origin_asn` in a route, `asn` in an IP lookup, the key `0`
 in a prefix's `origins`) means the route has no known origin: its AS path ends
@@ -262,20 +251,10 @@ Configuration is handled via environment variables and OS-specific paths:
 | `XDG_DATA_HOME`    | `/var/lib` (in the Docker image) | Base of the state directory; must be an absolute path       |
 | `GOMEMLIMIT`       | `1536MiB` (in the Docker image)  | Go soft memory limit; see Memory                            |
 | `MALLOC_ARENA_MAX` | `2` (in the Docker image)        | glibc malloc arena cap, a positive whole number; see Memory |
-| `TRUSTED_PROXIES`  | (empty)                          | Addresses and CIDR ranges of trusted proxies; see below     |
 
 A variable that is set to an invalid value stops the start with an error and a
 non-zero exit. An empty variable counts as unset.
 
-`TRUSTED_PROXIES` lists the reverse proxies whose `X-Forwarded-For` the server
-believes, comma-separated, such as `10.0.0.0/8,192.0.2.1`. For a request from
-one of them, the request log and `/ip/` use the last address in
-`X-Forwarded-For` that is not a trusted proxy: each proxy adds the address it
-received the request from to the end, so the entries before it are whatever the
-client sent. For a request from any other address they use the address the
-request came from, whatever forwarding headers it carries. `X-Real-IP` and
-`True-Client-IP` are not read.
-
 State directory (database location):
 
 - macOS: `~/Library/Application Support/berlin.sneak.app.routewatch/`
@@ -361,12 +340,9 @@ What the [upaas](https://git.eeqj.de/sneak/upaas) app needs:
 
 - Container port: `8080`.
 - Volume: one, at container path `/var/lib/berlin.sneak.app.routewatch`.
-- Environment: `TRUSTED_PROXIES`, set to the address the reverse proxy in front
+- Environment: nothing is required. Leave `XDG_DATA_HOME`, `GOMEMLIMIT` and
-  of the app connects from, as the container sees it; without it the request log
+  `MALLOC_ARENA_MAX` at the image's values. `DEBUG=routewatch` is optional and
-  and `/ip/` give the proxy's address for every request. Nothing else is needed:
+  adds the `System stats` memory line to the log.
-  leave `XDG_DATA_HOME`, `GOMEMLIMIT` and `MALLOC_ARENA_MAX` at the image's
-  values. `DEBUG=routewatch` is optional and adds the `System stats` memory line
-  to the log.
 - Memory Limit: `5g`, the 5 GiB limit from Memory above. upaas sets no swap
   limit, so on a host with swap Docker allows the same amount of swap again.
 - Health check: the image's `HEALTHCHECK` requests
@@ -378,19 +354,14 @@ What the [upaas](https://git.eeqj.de/sneak/upaas) app needs:
   `docker stop` does by default. The daemon allows 8 seconds for the handlers to
   write what they hold and for the requests in progress to finish, then stops
   the HTTP server, closes the database and exits with status 0. A longer grace
-  changes nothing. What is not written after 8 seconds is lost, and the streamer
+  changes nothing. What the handlers have not written after 8 seconds is lost,
-  and each handler log how much. When the prefix handler has fallen behind the
+  and each logs how many updates: when the prefix handler has fallen behind the
-  feed, a stop loses far more: its batch is full at 250,000 updates and the
+  feed, its batch holds up to 250,000 updates, which take about 20 seconds to
-  streamer's worker for it waits for room, so the streamer's stop takes the
+  write, so a stop then loses them, withdrawals and peer downs included. A route
-  whole 8 seconds and every handler then skips its last write. Lost then are the
+  withdrawn in them stays in the live route table until its peer announces or
-  messages left on the four handlers' queues, what the AS, peer and peering
+  withdraws the prefix again or its session goes down. When the 8 seconds run
-  handlers hold, the prefix handler's batch, and the write it has in progress,
+  out the database is not closed, and SQLite rolls back a write the exit cut off
-  up to another 250,000 updates, which take about 20 seconds and are cut off by
+  when the database next opens.
-  the exit; withdrawals and peer downs are among them. A route withdrawn in them
-  stays in the live route table until its peer announces or withdraws the prefix
-  again or its session goes down. When the 8 seconds run out the database is not
-  closed, and SQLite rolls back a write the exit cut off when the database next
-  opens.
 
 ## Development
 

internal/config/config.go

@@ -4,12 +4,10 @@ package config
 import (
 	"errors"
 	"fmt"
-	"net/netip"
 	"os"
 	"path/filepath"
 	"runtime"
 	"strconv"
-	"strings"
 	"time"
 )
 
@@ -34,8 +32,6 @@ var (
 	errRelativeXDGDataHome = errors.New("XDG_DATA_HOME must be an absolute path")
 	errUnsupportedOS       = errors.New("unsupported operating system")
 	errInvalidPort         = errors.New("PORT must be a whole number")
-	errInvalidProxy        = errors.New(
-		"TRUSTED_PROXIES must list IP addresses and CIDR ranges, comma-separated")
 )
 
 // Config holds configuration for the entire application
@@ -46,10 +42,6 @@ type Config struct {
 	// Port is the TCP port the HTTP server listens on
 	Port int
 
-	// TrustedProxies are the reverse proxies whose X-Forwarded-For header
-	// the HTTP server believes
-	TrustedProxies []netip.Prefix
-
 	// MaxRuntime is the maximum runtime (0 = run forever)
 	MaxRuntime time.Duration
 
@@ -76,15 +68,9 @@ func New() (*Config, error) {
 		return nil, err
 	}
 
-	trustedProxies, err := getTrustedProxies()
-	if err != nil {
-		return nil, err
-	}
-
 	return &Config{
 		StateDir: stateDir,
 		Port:     port,
-		TrustedProxies: trustedProxies,
 		// Run forever by default
 		MaxRuntime: 0,
 		// Enable batching by default
@@ -159,38 +145,6 @@ func getPort() (int, error) {
 	return int(port), nil
 }
 
-// getTrustedProxies returns the addresses and CIDR ranges listed in
-// TRUSTED_PROXIES, such as "10.0.0.0/8,192.0.2.1", or none when it is not set.
-// An address is returned as a range holding only that address.
-func getTrustedProxies() ([]netip.Prefix, error) {
-	value := os.Getenv("TRUSTED_PROXIES")
-	if value == "" {
-		return nil, nil
-	}
-
-	var proxies []netip.Prefix
-
-	for entry := range strings.SplitSeq(value, ",") {
-		entry = strings.TrimSpace(entry)
-
-		addr, err := netip.ParseAddr(entry)
-		if err == nil {
-			proxies = append(proxies, netip.PrefixFrom(addr, addr.BitLen()))
-
-			continue
-		}
-
-		prefix, err := netip.ParsePrefix(entry)
-		if err != nil {
-			return nil, fmt.Errorf("%w, got %q", errInvalidProxy, entry)
-		}
-
-		proxies = append(proxies, prefix)
-	}
-
-	return proxies, nil
-}
-
 // EnsureDirectories creates all necessary directories if they don't exist
 func (c *Config) EnsureDirectories() error {
 	// Ensure state directory exists

internal/config/config_internal_test.go

@@ -1,9 +1,7 @@
 package config
 
 import (
-	"net/netip"
 	"runtime"
-	"slices"
 	"testing"
 )
 
@@ -46,55 +44,6 @@ func TestNewRefusesInvalidPort(t *testing.T) {
 	}
 }
 
-func TestNewReadsTrustedProxies(t *testing.T) {
-	t.Setenv("PORT", "")
-	t.Setenv("XDG_DATA_HOME", "")
-
-	t.Setenv("TRUSTED_PROXIES", "")
-
-	cfg, err := New()
-	if err != nil {
-		t.Fatalf("New() without TRUSTED_PROXIES: %v", err)
-	}
-
-	if len(cfg.TrustedProxies) != 0 {
-		t.Errorf("New() without TRUSTED_PROXIES: TrustedProxies = %v, want none",
-			cfg.TrustedProxies)
-	}
-
-	t.Setenv("TRUSTED_PROXIES", "10.0.0.0/8, 192.0.2.1,2001:db8::/32")
-
-	cfg, err = New()
-	if err != nil {
-		t.Fatalf("New() with TRUSTED_PROXIES: %v", err)
-	}
-
-	want := []netip.Prefix{
-		netip.MustParsePrefix("10.0.0.0/8"),
-		netip.MustParsePrefix("192.0.2.1/32"),
-		netip.MustParsePrefix("2001:db8::/32"),
-	}
-	if !slices.Equal(cfg.TrustedProxies, want) {
-		t.Errorf("TrustedProxies = %v, want %v", cfg.TrustedProxies, want)
-	}
-}
-
-func TestNewRefusesInvalidTrustedProxies(t *testing.T) {
-	invalid := []string{"proxy.example", "10.0.0.0/33", "192.0.2.1:80", "192.0.2.1,"}
-	for _, value := range invalid {
-		t.Run(value, func(t *testing.T) {
-			t.Setenv("PORT", "")
-			t.Setenv("XDG_DATA_HOME", "")
-			t.Setenv("TRUSTED_PROXIES", value)
-
-			_, err := New()
-			if err == nil {
-				t.Errorf("New() with TRUSTED_PROXIES=%q returned no error", value)
-			}
-		})
-	}
-}
-
 func TestNewRefusesRelativeXDGDataHome(t *testing.T) {
 	if runtime.GOOS == "darwin" {
 		t.Skip("macOS does not read XDG_DATA_HOME")

internal/routewatch/batchwrite_internal_test.go

@@ -1,10 +1,7 @@
 package routewatch
 
 import (
-	"bytes"
 	"context"
-	"encoding/json"
-	"log/slog"
 	"slices"
 	"sync"
 	"testing"
@@ -26,9 +23,8 @@ const (
 )
 
 // blockingStore is a mockStore whose batch writes for the AS, peer and prefix
-// handlers, delete of a peer's routes and peering write wait until the test
+// handlers wait until the test calls releaseWrites. writeStarted is closed when
-// calls releaseWrites. writeStarted is closed when the first of them starts. It
+// the first of them starts. It records what each write was given.
-// records what each batch write was given.
 type blockingStore struct {
 	*mockStore
 
@@ -90,18 +86,6 @@ func (s *blockingStore) UpdatePeerBatch(peers map[string]database.PeerUpdate) er
 	return nil
 }
 
-func (s *blockingStore) DeleteLiveRoutesOfPeer(peerIP string) (int, error) {
-	s.waitForRelease()
-
-	return s.mockStore.DeleteLiveRoutesOfPeer(peerIP)
-}
-
-func (s *blockingStore) RecordPeering(asA, asB int, ts time.Time) error {
-	s.waitForRelease()
-
-	return s.mockStore.RecordPeering(asA, asB, ts)
-}
-
 func (s *blockingStore) waitForRelease() {
 	s.startOnce.Do(func() { close(s.writeStarted) })
 	<-s.release
@@ -113,40 +97,6 @@ func (s *blockingStore) releaseWrites() {
 	s.releaseOnce.Do(func() { close(s.release) })
 }
 
-// stopLog holds what a handler's Stop logs it did not write.
-//
-//nolint:tagliatelle // field names are the keys the handlers log
-type stopLog struct {
-	Msg       string `json:"msg"`
-	Updates   int    `json:"updates"`
-	PeersDown int    `json:"peers_down"`
-	Paths     int    `json:"paths"`
-}
-
-// newErrorLogger returns a logger that writes only errors, as JSON lines, to
-// logs.
-func newErrorLogger(logs *bytes.Buffer) *logger.Logger {
-	return &logger.Logger{Logger: slog.New(slog.NewJSONHandler(logs,
-		&slog.HandlerOptions{Level: slog.LevelError}))}
-}
-
-// lastLogged decodes the last line in logs, which is the one Stop logs: a
-// handler logs nothing after it.
-func lastLogged(t *testing.T, logs *bytes.Buffer) stopLog {
-	t.Helper()
-
-	lines := bytes.Split(bytes.TrimSpace(logs.Bytes()), []byte("\n"))
-
-	var logged stopLog
-
-	err := json.Unmarshal(lines[len(lines)-1], &logged)
-	if err != nil {
-		t.Fatalf("want the error Stop logs, got %q: %v", logs.String(), err)
-	}
-
-	return logged
-}
-
 // returnsInTime reports whether f returns within handleMessageTimeout.
 func returnsInTime(f func()) bool {
 	done := make(chan struct{})
@@ -272,8 +222,7 @@ func handleAtMaxBatchSize(
 // hands h the message extra, and stops h with a deadline that passes while
 // store holds the write. Stop must return all the same. Then it lets the write
 // finish and waits until done, closed when h's flush goroutine returns. Past
-// the deadline that goroutine skips its last write, so extra is not written,
+// the deadline that goroutine skips its last write, so extra is not written.
-// and Stop logs as not written both extra and what the held write took.
 func stopWhileAWriteIsBlocked(
 	t *testing.T,
 	store *blockingStore,
@@ -316,15 +265,11 @@ func TestPrefixHandlerSkipsItsLastWriteAfterTheStopDeadline(t *testing.T) {
 
 	const extraPrefix = "198.51.100.0/24"
 
-	var logs bytes.Buffer
-
 	store := newBlockingStore()
-	h := NewPrefixHandler(store, newErrorLogger(&logs))
+	h := NewPrefixHandler(store, logger.New())
 	fill := slices.Repeat([]string{testV4Prefix}, prefixBatchSize)
-	// The peer's session goes down first, so the write held is the delete of
-	// its routes, and Stop must log that peer down too.
 	stopWhileAWriteIsBlocked(t, store, h, h.done,
-		[]*ristypes.RISMessage{sessionDown(), prefixAnnouncement(fill)},
+		[]*ristypes.RISMessage{prefixAnnouncement(fill)},
 		prefixAnnouncement([]string{extraPrefix}))
 
 	store.mu.Lock()
@@ -333,25 +278,13 @@ func TestPrefixHandlerSkipsItsLastWriteAfterTheStopDeadline(t *testing.T) {
 	if store.prefixes[extraPrefix] {
 		t.Errorf("%s was written after the stop deadline", extraPrefix)
 	}
-
-	logged := lastLogged(t, &logs)
-	if logged.Updates != prefixBatchSize+1 || logged.PeersDown != 1 {
-		t.Errorf("Stop logged %d updates and %d peer downs not written, "+
-			"want %d and 1", logged.Updates, logged.PeersDown, prefixBatchSize+1)
-	}
 }
 
 func TestASHandlerSkipsItsLastWriteAfterTheStopDeadline(t *testing.T) {
 	t.Parallel()
 
-	// Each message gives an update for its origin AS and one for each AS
-	// in its path: fill asnBatchSize+1, extra 2.
-	const wantUpdates = asnBatchSize + 1 + 2
-
-	var logs bytes.Buffer
-
 	store := newBlockingStore()
-	h := NewASHandler(store, newErrorLogger(&logs))
+	h := NewASHandler(store, logger.New())
 	fill := ristypes.ASPath{Sequence: slices.Repeat([]int{testASNA}, asnBatchSize)}
 	stopWhileAWriteIsBlocked(t, store, h, h.done,
 		[]*ristypes.RISMessage{{Path: fill}},
@@ -363,11 +296,6 @@ func TestASHandlerSkipsItsLastWriteAfterTheStopDeadline(t *testing.T) {
 	if store.asns[testASNB] {
 		t.Errorf("AS%d was written after the stop deadline", testASNB)
 	}
-
-	if logged := lastLogged(t, &logs); logged.Updates != wantUpdates {
-		t.Errorf("Stop logged %d updates not written, want %d",
-			logged.Updates, wantUpdates)
-	}
 }
 
 func TestPeerHandlerSkipsItsLastWriteAfterTheStopDeadline(t *testing.T) {
@@ -375,10 +303,8 @@ func TestPeerHandlerSkipsItsLastWriteAfterTheStopDeadline(t *testing.T) {
 
 	const otherPeerIP = "2001:db8:ffff::2"
 
-	var logs bytes.Buffer
-
 	store := newBlockingStore()
-	h := NewPeerHandler(store, newErrorLogger(&logs))
+	h := NewPeerHandler(store, logger.New())
 	stopWhileAWriteIsBlocked(t, store, h, h.done,
 		slices.Repeat([]*ristypes.RISMessage{{Peer: testPeerIP}}, peerBatchSize),
 		&ristypes.RISMessage{Peer: otherPeerIP})
@@ -389,50 +315,6 @@ func TestPeerHandlerSkipsItsLastWriteAfterTheStopDeadline(t *testing.T) {
 	if store.peers[otherPeerIP] {
 		t.Errorf("peer %s was written after the stop deadline", otherPeerIP)
 	}
-
-	if logged := lastLogged(t, &logs); logged.Updates != peerBatchSize+1 {
-		t.Errorf("Stop logged %d updates not written, want %d",
-			logged.Updates, peerBatchSize+1)
-	}
-}
-
-// TestPeeringHandlerStopCountsTheWriteInProgress hands a running peering
-// handler one AS path and stops it with a deadline that passes while store
-// holds Stop's last write, of that path's peering. Stop must log that path as
-// not written.
-func TestPeeringHandlerStopCountsTheWriteInProgress(t *testing.T) {
-	t.Parallel()
-
-	const stopDeadline = 100 * time.Millisecond
-
-	var logs bytes.Buffer
-
-	store := newBlockingStore()
-	defer store.releaseWrites()
-
-	h := NewPeeringHandler(store, newErrorLogger(&logs))
-	handle(h, time.Now().UTC(), testASNA, testASNB)
-
-	ctx, cancel := context.WithTimeout(t.Context(), stopDeadline)
-	defer cancel()
-
-	if !returnsInTime(func() { h.Stop(ctx) }) {
-		t.Fatalf("Stop with a deadline of %s did not return while a write "+
-			"was blocked", stopDeadline)
-	}
-
-	store.releaseWrites()
-
-	select {
-	case <-h.done:
-	case <-time.After(handleMessageTimeout):
-		t.Fatal("the processing goroutine did not return after the write " +
-			"finished")
-	}
-
-	if logged := lastLogged(t, &logs); logged.Paths != 1 {
-		t.Errorf("Stop logged %d paths not written, want 1", logged.Paths)
-	}
 }
 
 // prefixAnnouncement returns a message in which testPeerIP announces prefixes

internal/routewatch/prefixhandler.go

@@ -51,9 +51,9 @@ type PrefixHandler struct {
 	logger  *logger.Logger
 	metrics *metrics.Tracker
 
-	// Batching. mu guards batch, held, peersDown, writing and deleting only:
+	// Batching. mu guards batch, held, peersDown and writing only: the flush
-	// the flush goroutine takes them under mu and writes them after releasing
+	// goroutine takes them under mu and writes them after releasing mu, so
-	// mu, so HandleMessage waits for a database write only while batch is at
+	// HandleMessage waits for a database write only while batch is at
 	// prefixBatchMaxSize.
 	mu    sync.Mutex
 	batch []prefixUpdate
@@ -70,9 +70,6 @@ type PrefixHandler struct {
 	// writing is how many updates the flush goroutine took and has not
 	// finished writing.
 	writing int
-	// deleting is how many peers from peersDown the flush goroutine took and
-	// has not yet deleted the routes of.
-	deleting int
 	// batchTaken is signalled when the flush goroutine takes batch; its L is
 	// &mu.
 	batchTaken  sync.Cond
@@ -214,9 +211,8 @@ func (h *PrefixHandler) HandleMessage(msg *ristypes.RISMessage) {
 // Stop stops the flush goroutine, which writes the updates and peer downs the
 // handler holds before it returns, and waits for it until ctx ends. Once ctx
 // has ended the flush goroutine skips that last write, and a write still
-// running is lost when the process exits. A peer whose route delete fails in
+// running is lost when the process exits, so Stop logs how many updates are
-// the last write is not retried either. Stop logs how many updates are not
+// not written and how many peer downs have not had their routes deleted.
-// written and how many peer downs have not had their routes deleted.
 func (h *PrefixHandler) Stop(ctx context.Context) {
 	h.stopCh <- ctx
 
@@ -227,23 +223,13 @@ func (h *PrefixHandler) Stop(ctx context.Context) {
 
 	h.mu.Lock()
 	unwritten := h.writing + len(h.batch) + len(h.held)
-	peersDown := h.deleting + len(h.peersDown)
+	peersDown := len(h.peersDown)
 	h.mu.Unlock()
 
-	if unwritten == 0 && peersDown == 0 {
+	if unwritten > 0 || peersDown > 0 {
-		return
-	}
-
-	if ctx.Err() != nil {
 		h.logger.Error("Stop deadline passed before the prefix handler wrote "+
 			"its updates", "updates", unwritten, "peers_down", peersDown)
-
-		return
 	}
-
-	h.logger.Error("The prefix handler stopped without deleting the routes "+
-		"of peers whose session went down", "updates", unwritten,
-		"peers_down", peersDown)
 }
 
 // peerSessionDown notes that the peer's BGP session went down, so that the next
@@ -295,8 +281,7 @@ func (h *PrefixHandler) flushLoop() {
 // takeBatch returns the pending updates, the held ones first, and the peers in
 // peersDown, and leaves an empty batch, no held updates and no peers in their
 // place for HandleMessage to fill. The updates count in writing until
-// flushBatch has written them, and the peers in deleting until their routes
+// flushBatch has written them.
-// are deleted.
 func (h *PrefixHandler) takeBatch() ([]prefixUpdate, []string) {
 	h.mu.Lock()
 	defer h.mu.Unlock()
@@ -311,7 +296,6 @@ func (h *PrefixHandler) takeBatch() ([]prefixUpdate, []string) {
 	}
 
 	h.writing = len(batch)
-	h.deleting = len(peersDown)
 	h.held = nil
 	h.batch = make([]prefixUpdate, 0, prefixBatchSize)
 	h.peersDown = nil
@@ -417,8 +401,7 @@ func (h *PrefixHandler) flushBatch() {
 // deleteLiveRoutesOfPeers deletes all live routes of each of peers, the peers
 // whose BGP session went down, and returns those whose delete failed. Most
 // downs come from peers that have no routes, so only a delete that removed
-// routes is logged. A peer whose delete succeeded no longer counts in deleting;
+// routes is logged.
-// a failed one counts until keepForNextFlush puts it back in peersDown.
 func (h *PrefixHandler) deleteLiveRoutesOfPeers(peers []string) []string {
 	var failed []string
 
@@ -435,10 +418,6 @@ func (h *PrefixHandler) deleteLiveRoutesOfPeers(peers []string) []string {
 			continue
 		}
 
-		h.mu.Lock()
-		h.deleting--
-		h.mu.Unlock()
-
 		if deleted > 0 {
 			h.logger.Info(
 				"Deleted the live routes of a peer whose session went down",
@@ -493,11 +472,9 @@ func (h *PrefixHandler) keepForNextFlush(
 	}
 
 	// takeBatch left held empty, and only this flush fills it. The kept
-	// updates now count in held, not in writing, and the failed peers in
+	// updates now count in held, not in writing.
-	// peersDown, not in deleting.
 	h.held = kept
 	h.writing = len(toWrite)
-	h.deleting = 0
 
 	for _, peer := range failedPeers {
 		if !slices.Contains(h.peersDown, peer) {

internal/routewatch/prefixhandler_internal_test.go

@@ -1,13 +1,11 @@
 package routewatch
 
 import (
-	"bytes"
 	"context"
 	"errors"
 	"fmt"
 	"net/netip"
 	"slices"
-	"strings"
 	"sync"
 	"testing"
 	"time"
@@ -768,34 +766,6 @@ func TestPrefixHandlerKeepsAtMostABatchOfUpdatesWhileADeleteKeepsFailing(
 	}
 }
 
-// TestPrefixHandlerStopLogsAFailedDeleteWithoutTheDeadline stops a prefix
-// handler, with no deadline, after a peer's session went down and the peer
-// announced a prefix, into a database whose every delete of a peer's routes
-// fails. Stop must log the peer down and the announcement as not written, and
-// must not say that the stop deadline passed.
-func TestPrefixHandlerStopLogsAFailedDeleteWithoutTheDeadline(t *testing.T) {
-	t.Parallel()
-
-	var logs bytes.Buffer
-
-	h := NewPrefixHandler(peerDeleteAlwaysFailsStore{Database: newTestDatabase(t)},
-		newErrorLogger(&logs))
-	h.HandleMessage(sessionDown())
-	h.HandleMessage(peerAnnouncement(testPeerIP, testV4Prefix))
-	h.Stop(t.Context())
-
-	logged := lastLogged(t, &logs)
-	if strings.Contains(logged.Msg, "deadline") {
-		t.Errorf("Stop logged %q although its deadline had not passed",
-			logged.Msg)
-	}
-
-	if logged.Updates != 1 || logged.PeersDown != 1 {
-		t.Errorf("Stop logged %d updates and %d peer downs not written, "+
-			"want 1 and 1", logged.Updates, logged.PeersDown)
-	}
-}
-
 // newTestDatabase opens a database in a new temporary directory. It is closed
 // when the test ends.
 func newTestDatabase(t *testing.T) *database.Database {

internal/server/handlers.go

@@ -41,12 +41,6 @@ const (
 	jsonStatusError = "error"
 )
 
-// Error messages an answer sends in place of the error that caused it.
-const (
-	invalidPrefixMessage   = "Invalid prefix"
-	hostNotResolvedMessage = "could not resolve host name"
-)
-
 // IP versions as database.LiveRoute.IPVersion records them.
 const (
 	ipVersionV4 = 4
@@ -74,9 +68,7 @@ func (s *Server) handleHealthCheck() http.HandlerFunc {
 		// Check database connectivity with lightweight ping
 		err := s.db.Ping(ctx)
 		if err != nil {
-			s.logger.Error("Health check database ping failed", "error", err)
+			checks["database"] = "error: " + err.Error()
-
-			checks["database"] = jsonStatusError
 			healthy = false
 		} else {
 			checks["database"] = "ok"
@@ -116,12 +108,12 @@ func (s *Server) handleHealthCheck() http.HandlerFunc {
 
 // handleIndex returns a handler that serves the home page.
 func (s *Server) handleIndex() http.HandlerFunc {
-	return func(w http.ResponseWriter, r *http.Request) {
+	return func(w http.ResponseWriter, _ *http.Request) {
 		w.Header().Set("Content-Type", "text/html; charset=utf-8")
 
 		tmpl := templates.IndexTemplate()
 
-		err := tmpl.Execute(w, pageData{CSPNonce: cspNonce(r.Context())})
+		err := tmpl.Execute(w, nil)
 		if err != nil {
 			s.logger.Error("Failed to render index template", "error", err)
 			http.Error(w, "Internal Server Error", http.StatusInternalServerError)
@@ -129,12 +121,6 @@ func (s *Server) handleIndex() http.HandlerFunc {
 	}
 }
 
-// pageData is what the pages that show no data are rendered with: the nonce
-// their script and style blocks carry.
-type pageData struct {
-	CSPNonce string
-}
-
 // writeJSONError writes a standardized JSON error response with the given
 // status code and error message.
 func (s *Server) writeJSONError(w http.ResponseWriter, statusCode int, message string) {
@@ -265,7 +251,7 @@ func (s *Server) handleStatusJSON() http.HandlerFunc {
 
 		if err != nil {
 			s.logger.Error("Failed to get database stats", "error", err)
-			s.writeJSONError(w, http.StatusInternalServerError, internalErrorMessage)
+			s.writeJSONError(w, http.StatusInternalServerError, err.Error())
 
 			return
 		}
@@ -555,7 +541,7 @@ func (s *Server) handleStats() http.HandlerFunc {
 
 		if err != nil {
 			s.logger.Error("Failed to get database stats", "error", err)
-			s.writeJSONError(w, http.StatusInternalServerError, internalErrorMessage)
+			s.writeJSONError(w, http.StatusInternalServerError, err.Error())
 
 			return
 		}
@@ -636,12 +622,12 @@ func (s *Server) statsResponse(
 // handleStatusHTML returns a handler that serves the HTML status page,
 // which displays real-time statistics fetched via JavaScript.
 func (s *Server) handleStatusHTML() http.HandlerFunc {
-	return func(w http.ResponseWriter, r *http.Request) {
+	return func(w http.ResponseWriter, _ *http.Request) {
 		w.Header().Set("Content-Type", "text/html; charset=utf-8")
 
 		tmpl := templates.StatusTemplate()
 
-		err := tmpl.Execute(w, pageData{CSPNonce: cspNonce(r.Context())})
+		err := tmpl.Execute(w, nil)
 		if err != nil {
 			s.logger.Error("Failed to render template", "error", err)
 			http.Error(w, "Internal Server Error", http.StatusInternalServerError)
@@ -681,7 +667,7 @@ func (s *Server) handleIPInfo() http.HandlerFunc {
 		}
 
 		// Collect all IPs to look up
-		ipsToLookup, resolveErrors := s.resolveLookupTargets(ctx, target)
+		ipsToLookup, resolveErrors := resolveLookupTargets(ctx, target)
 		if deadlinePassed(ctx) {
 			s.writeJSONError(w, http.StatusGatewayTimeout, requestTimeoutMessage)
 
@@ -709,8 +695,7 @@ func (s *Server) handleIPInfo() http.HandlerFunc {
 			}
 
 			if err != nil {
-				response.Errors = append(response.Errors,
+				response.Errors = append(response.Errors, ip+": "+err.Error())
-					ip+": "+s.lookupErrorMessage(ip, err))
 
 				continue
 			}
@@ -751,19 +736,6 @@ func (s *Server) handleIPInfo() http.HandlerFunc {
 	}
 }
 
-// lookupErrorMessage returns what an IP lookup answer says about err, the
-// failed lookup of ip: err's own text when ip is not a valid address or has no
-// route, otherwise a fixed message, with err in the log.
-func (s *Server) lookupErrorMessage(ip string, err error) string {
-	if errors.Is(err, database.ErrNoRoute) || errors.Is(err, database.ErrInvalidIP) {
-		return err.Error()
-	}
-
-	s.logger.Error("Failed to look up IP", "ip", ip, "error", err)
-
-	return internalErrorMessage
-}
-
 // lookupTarget returns what an IP lookup request asks for: the ip or addr URL
 // parameter, or else the client's own address.
 func lookupTarget(r *http.Request) string {
@@ -794,12 +766,9 @@ func (s *Server) queueWHOISRefresh(asns map[int]bool) {
 
 // resolveLookupTargets splits a comma-separated list of IP addresses and
 // hostnames and returns the IP addresses to look up, resolving each hostname.
-// A hostname that does not resolve is reported in the returned errors instead,
+// A hostname that does not resolve is reported in the returned errors instead.
-// with the resolver's own error only in the log, since it names the DNS server.
 // It stops once ctx's deadline has passed; the caller then answers 504.
-func (s *Server) resolveLookupTargets(
+func resolveLookupTargets(ctx context.Context, target string) ([]string, []string) {
-	ctx context.Context, target string,
-) ([]string, []string) {
 	var ipsToLookup, resolveErrors []string
 
 	for t := range strings.SplitSeq(target, ",") {
@@ -822,8 +791,7 @@ func (s *Server) resolveLookupTargets(
 		}
 
 		if err != nil {
-			s.logger.Warn("Host name lookup failed", "host", t, "error", err)
+			resolveErrors = append(resolveErrors, t+": "+err.Error())
-			resolveErrors = append(resolveErrors, t+": "+hostNotResolvedMessage)
 
 			continue
 		}
@@ -851,7 +819,7 @@ func lookupPTRNames(ctx context.Context, ip string) []string {
 }
 
 // extractClientIP extracts the client IP from the request.
-// Works with RealIPMiddleware, which sets RemoteAddr.
+// Works with chi's RealIP middleware which sets RemoteAddr.
 func extractClientIP(r *http.Request) string {
 	// RemoteAddr is in the form "IP:port" or just "IP" for unix sockets
 	host, _, err := net.SplitHostPort(r.RemoteAddr)
@@ -886,9 +854,7 @@ func (s *Server) handleASDetailJSON() http.HandlerFunc {
 			if errors.Is(err, database.ErrNoRoute) {
 				s.writeJSONError(w, http.StatusNotFound, err.Error())
 			} else {
-				s.logger.Error("Failed to get AS details", "asn", asn, "error", err)
+				s.writeJSONError(w, http.StatusInternalServerError, err.Error())
-				s.writeJSONError(w, http.StatusInternalServerError,
-					internalErrorMessage)
 			}
 
 			return
@@ -967,7 +933,7 @@ func (s *Server) handlePrefixDetailJSON() http.HandlerFunc {
 		// tables store, so that any valid way of writing it finds the route.
 		parsed, err := netip.ParsePrefix(prefixParam + "/" + lenParam)
 		if err != nil {
-			s.writeJSONError(w, http.StatusBadRequest, invalidPrefixMessage)
+			s.writeJSONError(w, http.StatusBadRequest, err.Error())
 
 			return
 		}
@@ -985,10 +951,7 @@ func (s *Server) handlePrefixDetailJSON() http.HandlerFunc {
 			if errors.Is(err, database.ErrNoRoute) {
 				s.writeJSONError(w, http.StatusNotFound, err.Error())
 			} else {
-				s.logger.Error("Failed to get prefix details",
+				s.writeJSONError(w, http.StatusInternalServerError, err.Error())
-					"prefix", prefix, "error", err)
-				s.writeJSONError(w, http.StatusInternalServerError,
-					internalErrorMessage)
 			}
 
 			return
@@ -1039,7 +1002,7 @@ func (s *Server) handleASDetail() http.HandlerFunc {
 				http.Error(w, "AS not found", http.StatusNotFound)
 			} else {
 				s.logger.Error("Failed to get AS details", "error", err)
-				http.Error(w, internalErrorMessage, http.StatusInternalServerError)
+				http.Error(w, "Internal server error", http.StatusInternalServerError)
 			}
 
 			return
@@ -1076,7 +1039,6 @@ func (s *Server) handleASDetail() http.HandlerFunc {
 			IPv6Count    int
 			Peers        []database.ASPeer
 			PeerCount    int
-			CSPNonce     string
 		}{
 			ASN:          asInfo,
 			IPv4Prefixes: ipv4Prefixes,
@@ -1086,7 +1048,6 @@ func (s *Server) handleASDetail() http.HandlerFunc {
 			IPv6Count:    len(ipv6Prefixes),
 			Peers:        peers,
 			PeerCount:    len(peers),
-			CSPNonce:     cspNonce(r.Context()),
 		}
 
 		// Check if context is still valid before writing response
@@ -1097,7 +1058,9 @@ func (s *Server) handleASDetail() http.HandlerFunc {
 
 		w.Header().Set("Content-Type", "text/html; charset=utf-8")
 
-		err = templates.ASDetailTemplate().Execute(w, data)
+		tmpl := templates.ASDetailTemplate()
+
+		err = tmpl.Execute(w, data)
 		if err != nil {
 			s.logger.Error("Failed to render AS detail template", "error", err)
 			http.Error(w, "Internal Server Error", http.StatusInternalServerError)
@@ -1122,7 +1085,7 @@ func (s *Server) handlePrefixDetail() http.HandlerFunc {
 		// tables store, so that any valid way of writing it finds the route.
 		parsed, err := netip.ParsePrefix(prefixParam + "/" + lenParam)
 		if err != nil {
-			http.Error(w, invalidPrefixMessage, http.StatusBadRequest)
+			http.Error(w, "Invalid prefix", http.StatusBadRequest)
 
 			return
 		}
@@ -1141,7 +1104,7 @@ func (s *Server) handlePrefixDetail() http.HandlerFunc {
 				http.Error(w, "Prefix not found", http.StatusNotFound)
 			} else {
 				s.logger.Error("Failed to get prefix details", "error", err)
-				http.Error(w, internalErrorMessage, http.StatusInternalServerError)
+				http.Error(w, "Internal server error", http.StatusInternalServerError)
 			}
 
 			return
@@ -1168,7 +1131,6 @@ func (s *Server) handlePrefixDetail() http.HandlerFunc {
 			Origins     []*ASNInfo
 			PeerCount   int
 			OriginCount int
-			CSPNonce    string
 		}{
 			Prefix:      prefix,
 			MaskLength:  maskLength,
@@ -1177,7 +1139,6 @@ func (s *Server) handlePrefixDetail() http.HandlerFunc {
 			Origins:     origins,
 			PeerCount:   len(routes),
 			OriginCount: len(origins),
-			CSPNonce:    cspNonce(r.Context()),
 		}
 
 		// Check if context is still valid before writing response
@@ -1190,7 +1151,9 @@ func (s *Server) handlePrefixDetail() http.HandlerFunc {
 
 		w.Header().Set("Content-Type", "text/html; charset=utf-8")
 
-		err = templates.PrefixDetailTemplate().Execute(w, data)
+		tmpl := templates.PrefixDetailTemplate()
+
+		err = tmpl.Execute(w, data)
 		if err != nil {
 			s.logger.Error("Failed to render prefix detail template", "error", err)
 			http.Error(w, "Internal Server Error", http.StatusInternalServerError)
@@ -1340,7 +1303,7 @@ func (s *Server) prefixLengthHandler(ipVersion, maxMaskLength int) http.HandlerF
 
 		if err != nil {
 			s.logger.Error("Failed to get prefixes by length", "error", err)
-			http.Error(w, internalErrorMessage, http.StatusInternalServerError)
+			http.Error(w, "Internal server error", http.StatusInternalServerError)
 
 			return
 		}
@@ -1361,7 +1324,6 @@ func (s *Server) prefixLengthHandler(ipVersion, maxMaskLength int) http.HandlerF
 			"IPVersion":  ipVersion,
 			"Prefixes":   prefixesWithASDescriptions(prefixes),
 			"Count":      len(prefixes),
-			"CSPNonce":   cspNonce(r.Context()),
 		}
 
 		// Check if context is still valid before writing response

internal/server/handlers_internal_test.go

@@ -28,14 +28,6 @@ const (
 	testPeerV6   = "2001:db8::1"
 )
 
-// Paths several tests request.
-const (
-	asPagePath           = "/as/64500"
-	prefixLengthPagePath = "/prefixlength/24"
-	statusJSONPath       = "/status.json"
-	statsPath            = "/api/v1/stats"
-)
-
 // The names the stats handler tests report the two stats handlers by.
 const (
 	statusJSONHandlerName = "status.json"
@@ -437,7 +429,7 @@ func TestPagesSayOriginZeroIsNoKnownOrigin(t *testing.T) {
 
 	s := New(db, streamer.New(logger.New(), metrics.New()), logger.New(), &config.Config{})
 
-	for _, path := range []string{"/prefix/" + testPrefixV4, prefixLengthPagePath} {
+	for _, path := range []string{"/prefix/" + testPrefixV4, "/prefixlength/24"} {
 		rec := httptest.NewRecorder()
 		s.router.ServeHTTP(rec, httptest.NewRequestWithContext(
 			t.Context(), http.MethodGet, path, nil))
@@ -618,13 +610,13 @@ func TestRoutesAnswer504WhenDatabaseReadIsCutOff(t *testing.T) {
 		path         string
 		wantJSONBody bool
 	}{
-		{path: asPagePath},
+		{path: "/as/64500"},
 		{path: "/prefix/192.0.2.0/24"},
-		{path: prefixLengthPagePath},
+		{path: "/prefixlength/24"},
 		{path: "/prefixlength6/48"},
-		{path: statusJSONPath, wantJSONBody: true},
+		{path: "/status.json", wantJSONBody: true},
 		{path: "/ip/192.0.2.1", wantJSONBody: true},
-		{path: statsPath, wantJSONBody: true},
+		{path: "/api/v1/stats", wantJSONBody: true},
 		{path: "/api/v1/ip/192.0.2.1", wantJSONBody: true},
 		{path: "/api/v1/as/64500", wantJSONBody: true},
 		{path: "/api/v1/prefix/192.0.2.0/24", wantJSONBody: true},
@@ -697,9 +689,9 @@ func TestRoutesAnswer504WhenSecondDatabaseReadIsCutOff(t *testing.T) {
 		path         string
 		wantJSONBody bool
 	}{
-		{path: asPagePath},
+		{path: "/as/64500"},
-		{path: statusJSONPath, wantJSONBody: true},
+		{path: "/status.json", wantJSONBody: true},
-		{path: statsPath, wantJSONBody: true},
+		{path: "/api/v1/stats", wantJSONBody: true},
 	}
 
 	for _, tt := range tests {
@@ -766,86 +758,6 @@ func checkJSONErrorCode(
 	}
 }
 
-// errDiskIO is the database driver's error failingDB answers with.
-var errDiskIO = errors.New("disk I/O error")
-
-// failingDB embeds database.Store (left nil) and fails the reads of the JSON
-// routes and the health check's ping with errDiskIO. Every other Store method
-// is unused and would panic if called.
-type failingDB struct {
-	database.Store
-}
-
-func (failingDB) Ping(_ context.Context) error {
-	return errDiskIO
-}
-
-func (failingDB) GetStatsContext(_ context.Context) (database.Stats, error) {
-	return database.Stats{}, errDiskIO
-}
-
-func (failingDB) GetIPInfoContext(
-	_ context.Context, _ string,
-) (*database.IPInfo, error) {
-	return nil, errDiskIO
-}
-
-func (failingDB) GetASDetailsContext(
-	_ context.Context, _ int,
-) (*database.ASN, []database.LiveRoute, error) {
-	return nil, nil, errDiskIO
-}
-
-func (failingDB) GetPrefixDetailsContext(
-	_ context.Context, _ string,
-) ([]database.LiveRoute, map[int]database.ASN, error) {
-	return nil, nil, errDiskIO
-}
-
-// TestJSONRoutesDoNotSendErrorDetails sends a request to each JSON route and
-// the health check with a store whose reads fail with the driver's error text,
-// and a prefix that does not parse, and checks that no answer carries the
-// driver's or the prefix parser's text. Before the fix the answers sent it to
-// the client (https://git.eeqj.de/sneak/routewatch/issues/108). The IP lookup
-// answers 404, as it does whenever no address could be looked up.
-func TestJSONRoutesDoNotSendErrorDetails(t *testing.T) {
-	t.Parallel()
-
-	s := New(failingDB{}, streamer.New(logger.New(), metrics.New()), logger.New(),
-		&config.Config{})
-
-	tests := []struct {
-		path     string
-		wantCode int
-	}{
-		{"/.well-known/healthcheck.json", http.StatusServiceUnavailable},
-		{statusJSONPath, http.StatusInternalServerError},
-		{statsPath, http.StatusInternalServerError},
-		{"/api/v1/as/64500", http.StatusInternalServerError},
-		{"/api/v1/prefix/192.0.2.0/24", http.StatusInternalServerError},
-		{"/api/v1/ip/192.0.2.1", http.StatusNotFound},
-		{"/api/v1/prefix/foo/24", http.StatusBadRequest},
-	}
-
-	for _, tt := range tests {
-		rec := httptest.NewRecorder()
-		s.router.ServeHTTP(rec, httptest.NewRequestWithContext(
-			t.Context(), http.MethodGet, tt.path, nil))
-
-		if rec.Code != tt.wantCode {
-			t.Errorf("%s: status %d, want %d; body %s",
-				tt.path, rec.Code, tt.wantCode, rec.Body)
-		}
-
-		for _, detail := range []string{errDiskIO.Error(), "netip"} {
-			if strings.Contains(rec.Body.String(), detail) {
-				t.Errorf("%s: body %s carries the error text %q",
-					tt.path, rec.Body, detail)
-			}
-		}
-	}
-}
-
 // settledGoroutineCount lets transient goroutines finish, then reports the
 // current count.
 func settledGoroutineCount() int {

internal/server/middleware.go

@@ -3,15 +3,11 @@ package server
 import (
 	"bytes"
 	"context"
-	"crypto/rand"
 	"encoding/json"
 	"errors"
 	"fmt"
 	"log/slog"
 	"net/http"
-	"net/netip"
-	"slices"
-	"strings"
 	"sync"
 	"time"
 
@@ -122,10 +118,6 @@ func JSONResponseMiddleware(next http.Handler) http.Handler {
 // requestTimeoutMessage is the error message sent with 504 Gateway Timeout.
 const requestTimeoutMessage = "Request timeout"
 
-// internalErrorMessage is the error message sent with 500 Internal Server
-// Error, whatever went wrong; the handler logs the detail.
-const internalErrorMessage = "Internal server error"
-
 // deadlinePassed reports whether ctx ended because its deadline passed.
 //
 // A handler calls it right after each database read or host name lookup,
@@ -202,7 +194,7 @@ func JSONValidationMiddleware(next http.Handler) http.Handler {
 
 		w.WriteHeader(statusCode)
 
-		errorMsg := internalErrorMessage
+		errorMsg := "Internal server error"
 		if statusCode == http.StatusGatewayTimeout {
 			errorMsg = requestTimeoutMessage
 		}
@@ -304,105 +296,3 @@ func DecodedPathMiddleware(next http.Handler) http.Handler {
 		next.ServeHTTP(w, r)
 	})
 }
-
-// The values of the headers SecurityHeadersMiddleware sets.
-const (
-	// strictTransportSecurity tells browsers to reach this host and its
-	// subdomains only over HTTPS for a year. The server listens on plain
-	// HTTP behind a TLS-terminating proxy, which passes the header on.
-	strictTransportSecurity = "max-age=31536000; includeSubDomains"
-
-	// contentSecurityPolicy lets a page load content only from this server,
-	// and run or apply an inline script or style block only when the block
-	// carries the nonce made for that answer, which replaces %[1]s. No other
-	// site may frame the pages.
-	contentSecurityPolicy = "default-src 'self'; " +
-		"script-src 'nonce-%[1]s'; style-src 'nonce-%[1]s'; " +
-		"frame-ancestors 'none'; base-uri 'none'; form-action 'self'"
-
-	frameOptions       = "DENY"
-	contentTypeOptions = "nosniff"
-	referrerPolicy     = "strict-origin-when-cross-origin"
-
-	// permissionsPolicy turns off browser features the pages do not use.
-	permissionsPolicy = "accelerometer=(), camera=(), geolocation=(), " +
-		"gyroscope=(), magnetometer=(), microphone=(), payment=(), usb=()"
-)
-
-// cspNonceKey is the request context key of the nonce SecurityHeadersMiddleware
-// made for the answer.
-type cspNonceKey struct{}
-
-// SecurityHeadersMiddleware sets the security headers REPO_POLICIES.md requires
-// on every answer. Each answer's Content-Security-Policy names a nonce of its
-// own; a page reads it with cspNonce and writes it on its script and style
-// blocks.
-func SecurityHeadersMiddleware(next http.Handler) http.Handler {
-	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		nonce := rand.Text()
-
-		header := w.Header()
-		header.Set("Strict-Transport-Security", strictTransportSecurity)
-		header.Set("Content-Security-Policy",
-			fmt.Sprintf(contentSecurityPolicy, nonce))
-		header.Set("X-Frame-Options", frameOptions)
-		header.Set("X-Content-Type-Options", contentTypeOptions)
-		header.Set("Referrer-Policy", referrerPolicy)
-		header.Set("Permissions-Policy", permissionsPolicy)
-
-		ctx := context.WithValue(r.Context(), cspNonceKey{}, nonce)
-		next.ServeHTTP(w, r.WithContext(ctx))
-	})
-}
-
-// cspNonce returns the nonce SecurityHeadersMiddleware made for the answer to
-// the request with ctx.
-func cspNonce(ctx context.Context) string {
-	nonce, _ := ctx.Value(cspNonceKey{}).(string)
-
-	return nonce
-}
-
-// RealIPMiddleware gives a request from one of trustedProxies the address of
-// the client the proxies forwarded it for as its RemoteAddr: the last
-// X-Forwarded-For entry that is not a trusted proxy. Each proxy appends the
-// address it took the request from, so the entries left of that one are
-// whatever the client sent. A request from any other peer keeps the peer's
-// address, whatever headers it carries.
-func RealIPMiddleware(trustedProxies []netip.Prefix) func(http.Handler) http.Handler {
-	isTrusted := func(addr netip.Addr) bool {
-		return slices.ContainsFunc(trustedProxies, func(proxy netip.Prefix) bool {
-			return proxy.Contains(addr.Unmap())
-		})
-	}
-
-	return func(next http.Handler) http.Handler {
-		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-			peer, err := netip.ParseAddrPort(r.RemoteAddr)
-			if err != nil || !isTrusted(peer.Addr()) {
-				next.ServeHTTP(w, r)
-
-				return
-			}
-
-			// A header sent on several lines is one list.
-			entries := strings.Split(
-				strings.Join(r.Header.Values("X-Forwarded-For"), ","), ",")
-
-			for _, entry := range slices.Backward(entries) {
-				addr, err := netip.ParseAddr(strings.TrimSpace(entry))
-				if err != nil {
-					break
-				}
-
-				r.RemoteAddr = addr.String()
-
-				if !isTrusted(addr) {
-					break
-				}
-			}
-
-			next.ServeHTTP(w, r)
-		})
-	}
-}

internal/server/middleware_internal_test.go

@@ -1,205 +0,0 @@
-package server
-
-import (
-	"encoding/json"
-	"net/http"
-	"net/http/httptest"
-	"net/netip"
-	"strings"
-	"testing"
-	"time"
-)
-
-// The addresses the forwarding tests use: the client a proxy names in
-// X-Forwarded-For, a peer inside the trusted range of
-// TestRealIPMiddlewareTrustsOnlyConfiguredProxies, and a peer outside it,
-// which lies in testPrefixV4 so that an IP lookup of it finds a route.
-const (
-	forwardedClient   = "203.0.113.9"
-	trustedPeer       = "10.0.0.2:1234"
-	untrustedPeerAddr = "192.0.2.1"
-	untrustedPeer     = untrustedPeerAddr + ":1234"
-)
-
-// TestResponsesCarrySecurityHeaders checks that a page, a JSON route and a
-// path no route matches each answer with the security headers REPO_POLICIES.md
-// requires, and that the Content-Security-Policy allows no inline content
-// without a nonce (https://git.eeqj.de/sneak/routewatch/issues/108).
-func TestResponsesCarrySecurityHeaders(t *testing.T) {
-	t.Parallel()
-
-	s := newServerWithTestRoutes(t)
-
-	headers := []string{
-		"Strict-Transport-Security",
-		"Content-Security-Policy",
-		"X-Frame-Options",
-		"X-Content-Type-Options",
-		"Referrer-Policy",
-		"Permissions-Policy",
-	}
-
-	for _, path := range []string{"/", statsPath, "/no-such-page"} {
-		rec := httptest.NewRecorder()
-		s.router.ServeHTTP(rec, httptest.NewRequestWithContext(
-			t.Context(), http.MethodGet, path, nil))
-
-		for _, name := range headers {
-			if rec.Header().Get(name) == "" {
-				t.Errorf("%s: no %s header", path, name)
-			}
-		}
-
-		policy := rec.Header().Get("Content-Security-Policy")
-		if strings.Contains(policy, "'unsafe-") {
-			t.Errorf("%s: Content-Security-Policy %q allows unsafe content",
-				path, policy)
-		}
-	}
-}
-
-// TestPagesCarryTheCSPNonce checks that every script and style block of each
-// page carries the nonce its Content-Security-Policy header names, so that the
-// browser runs and applies them, that each answer has a nonce of its own, and
-// that no page uses a style attribute, which the policy does not allow.
-func TestPagesCarryTheCSPNonce(t *testing.T) {
-	t.Parallel()
-
-	s := newServerWithTestRoutes(t)
-
-	_, err := s.db.GetOrCreateASN(64500, time.Date(2026, 1, 2, 3, 4, 5, 0, time.UTC))
-	if err != nil {
-		t.Fatalf("GetOrCreateASN: %v", err)
-	}
-
-	paths := []string{
-		"/", "/status", asPagePath, "/prefix/" + testPrefixV4,
-		prefixLengthPagePath, "/prefixlength6/32",
-	}
-	seen := make(map[string]bool)
-
-	for _, path := range paths {
-		rec := httptest.NewRecorder()
-		s.router.ServeHTTP(rec, httptest.NewRequestWithContext(
-			t.Context(), http.MethodGet, path, nil))
-
-		if rec.Code != http.StatusOK {
-			t.Errorf("%s: status %d, want %d; body %s",
-				path, rec.Code, http.StatusOK, rec.Body)
-
-			continue
-		}
-
-		policy := rec.Header().Get("Content-Security-Policy")
-
-		_, nonce, found := strings.Cut(policy, "'nonce-")
-		if !found {
-			t.Errorf("%s: Content-Security-Policy %q names no nonce", path, policy)
-
-			continue
-		}
-
-		nonce, _, _ = strings.Cut(nonce, "'")
-		if seen[nonce] {
-			t.Errorf("%s: nonce %q was already used for another answer", path, nonce)
-		}
-
-		seen[nonce] = true
-		page := rec.Body.String()
-
-		for _, tag := range []string{"<script", "<style"} {
-			withNonce := tag + ` nonce="` + nonce + `"`
-			if strings.Count(page, tag) != strings.Count(page, withNonce) {
-				t.Errorf("%s: a %s tag does not carry the nonce %q", path, tag, nonce)
-			}
-		}
-
-		if strings.Contains(page, "style=") {
-			t.Errorf("%s: the page uses a style attribute", path)
-		}
-	}
-}
-
-// TestForwardedForFromUntrustedPeerIsIgnored asks /ip/ for the caller's own
-// address from a peer that is not a trusted proxy, with forwarding headers
-// naming another address, and checks that the lookup is for the TCP peer.
-// Before the fix any client could choose the address it was looked up and
-// logged as (https://git.eeqj.de/sneak/routewatch/issues/108).
-func TestForwardedForFromUntrustedPeerIsIgnored(t *testing.T) {
-	t.Parallel()
-
-	s := newServerWithTestRoutes(t)
-
-	req := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/ip/", nil)
-	req.RemoteAddr = untrustedPeer
-	req.Header.Set("X-Forwarded-For", forwardedClient)
-	req.Header.Set("X-Real-IP", forwardedClient)
-	req.Header.Set("True-Client-IP", forwardedClient)
-
-	rec := httptest.NewRecorder()
-	s.router.ServeHTTP(rec, req)
-
-	var body struct {
-		Data IPLookupResponse `json:"data"`
-	}
-
-	err := json.Unmarshal(rec.Body.Bytes(), &body)
-	if err != nil {
-		t.Fatalf("decoding the answer %q: %v", rec.Body, err)
-	}
-
-	if body.Data.Query != untrustedPeerAddr {
-		t.Errorf("looked up %q, want the TCP peer %s; answer %s",
-			body.Data.Query, untrustedPeerAddr, rec.Body)
-	}
-}
-
-// TestRealIPMiddlewareTrustsOnlyConfiguredProxies checks which address
-// RealIPMiddleware gives a request: the TCP peer, unless the peer is a trusted
-// proxy; then the last X-Forwarded-For entry that is not a trusted proxy,
-// since the entries left of it are whatever the client sent.
-func TestRealIPMiddlewareTrustsOnlyConfiguredProxies(t *testing.T) {
-	t.Parallel()
-
-	trusted := []netip.Prefix{netip.MustParsePrefix("10.0.0.0/8")}
-
-	tests := []struct {
-		name         string
-		peer         string
-		forwardedFor string
-		want         string
-	}{
-		{"untrusted peer", untrustedPeer, forwardedClient, untrustedPeer},
-		{"trusted peer", trustedPeer, forwardedClient, forwardedClient},
-		{
-			"entries the client wrote", trustedPeer,
-			"198.51.100.7, " + forwardedClient, forwardedClient,
-		},
-		{
-			"two trusted proxies", trustedPeer,
-			forwardedClient + ", 10.0.0.3", forwardedClient,
-		},
-		{"no header", trustedPeer, "", trustedPeer},
-		{"entry not an address", trustedPeer, "client", trustedPeer},
-	}
-
-	for _, tt := range tests {
-		var got string
-
-		handler := RealIPMiddleware(trusted)(http.HandlerFunc(
-			func(_ http.ResponseWriter, r *http.Request) { got = r.RemoteAddr }))
-
-		req := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/", nil)
-		req.RemoteAddr = tt.peer
-
-		if tt.forwardedFor != "" {
-			req.Header.Set("X-Forwarded-For", tt.forwardedFor)
-		}
-
-		handler.ServeHTTP(httptest.NewRecorder(), req)
-
-		if got != tt.want {
-			t.Errorf("%s: RemoteAddr %q, want %q", tt.name, got, tt.want)
-		}
-	}
-}

internal/server/routes.go

@@ -13,9 +13,8 @@ func (s *Server) setupRoutes() {
 
 	// Middleware
 	r.Use(DecodedPathMiddleware)
-	r.Use(SecurityHeadersMiddleware)
 	r.Use(middleware.RequestID)
-	r.Use(RealIPMiddleware(s.trustedProxies))
+	r.Use(middleware.RealIP)
 	r.Use(RequestLoggerMiddleware(s.logger.Logger)) // Structured request logging
 	r.Use(middleware.Recoverer)
 	r.Use(JSONResponseMiddleware)

internal/server/server.go

@@ -7,7 +7,6 @@ import (
 	"fmt"
 	"net"
 	"net/http"
-	"net/netip"
 	"strconv"
 	"time"
 
@@ -41,10 +40,6 @@ type Server struct {
 	port       int
 	srv        *http.Server
 	asnFetcher ASNFetcher
-
-	// trustedProxies are the reverse proxies whose X-Forwarded-For header
-	// RealIPMiddleware believes
-	trustedProxies []netip.Prefix
 }
 
 // New creates a new HTTP server
@@ -59,7 +54,6 @@ func New(
 		streamer: streamer,
 		logger:   logger,
 		port:     cfg.Port,
-		trustedProxies: cfg.TrustedProxies,
 	}
 
 	s.setupRoutes()

internal/server/server_internal_test.go

@@ -1,92 +0,0 @@
-package server
-
-import (
-	"context"
-	"net"
-	"net/http"
-	"testing"
-	"time"
-
-	"git.eeqj.de/sneak/routewatch/internal/logger"
-)
-
-// TestStopClosesTheConnectionOfARequestStillRunning serves a request whose
-// handler does not return until the test ends, and stops the server with a
-// deadline that passes while the request runs. The client must then see its
-// connection closed. Before the fix Stop returned at the deadline and left the
-// connection open until the handler returned.
-func TestStopClosesTheConnectionOfARequestStillRunning(t *testing.T) {
-	t.Parallel()
-
-	const (
-		stopDeadline = 100 * time.Millisecond
-		// waitTimeout is how long the test waits for the request to reach
-		// the handler, and then for the client to see its connection closed.
-		waitTimeout = 2 * time.Second
-		// readHeaderTimeout bounds the test server's read of the request
-		// header, as every http.Server must.
-		readHeaderTimeout = time.Second
-	)
-
-	release := make(chan struct{})
-	defer close(release)
-
-	started := make(chan struct{})
-
-	var listenConfig net.ListenConfig
-
-	listener, err := listenConfig.Listen(t.Context(), "tcp", "127.0.0.1:0")
-	if err != nil {
-		t.Fatalf("failed to open the test listener: %v", err)
-	}
-
-	s := &Server{logger: logger.New(), srv: &http.Server{
-		Handler: http.HandlerFunc(func(http.ResponseWriter, *http.Request) {
-			close(started)
-			<-release
-		}),
-		ReadHeaderTimeout: readHeaderTimeout,
-	}}
-
-	go func() { _ = s.srv.Serve(listener) }()
-
-	answered := make(chan error, 1)
-
-	go func() {
-		req, err := http.NewRequestWithContext(t.Context(), http.MethodGet,
-			"http://"+listener.Addr().String()+"/", nil)
-		if err != nil {
-			answered <- err
-
-			return
-		}
-
-		resp, err := http.DefaultClient.Do(req)
-		if err == nil {
-			_ = resp.Body.Close()
-		}
-
-		answered <- err
-	}()
-
-	select {
-	case <-started:
-	case <-time.After(waitTimeout):
-		t.Fatal("the request did not reach the handler")
-	}
-
-	ctx, cancel := context.WithTimeout(t.Context(), stopDeadline)
-	defer cancel()
-
-	_ = s.Stop(ctx)
-
-	select {
-	case err := <-answered:
-		if err == nil {
-			t.Error("the request still running at the deadline was answered")
-		}
-	case <-time.After(waitTimeout):
-		t.Fatal("the connection of the request still running at the " +
-			"deadline was open after Stop returned")
-	}
-}

internal/templates/as_detail.html

@@ -4,7 +4,7 @@
     <meta charset="UTF-8">
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
     <title>AS{{.ASN.ASN}} - {{.ASN.Handle}} - RouteWatch</title>
-    <style nonce="{{.CSPNonce}}">
+    <style>
         * {
             box-sizing: border-box;
         }

internal/templates/index.html

@@ -4,7 +4,7 @@
     <meta charset="UTF-8">
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
     <title>RouteWatch - BGP Route Monitor</title>
-    <style nonce="{{.CSPNonce}}">
+    <style>
         * {
             box-sizing: border-box;
         }
@@ -167,13 +167,6 @@
             color: #95a5a6;
             margin-top: 8px;
         }
-        #asname-results p {
-            color: #7f8c8d;
-            margin-top: 12px;
-        }
-        #asname-results .search-message {
-            font-size: 13px;
-        }
 
         /* IP Lookup result */
         .ip-result {
@@ -336,7 +329,7 @@
         <span><a href="{{appGitCommitURL}}">{{appGitRevision}}</a></span>
     </footer>
 
-    <script nonce="{{.CSPNonce}}">
+    <script>
         function formatNumber(num) {
             if (num >= 1000000) {
                 return (num / 1000000).toFixed(1) + 'M';
@@ -394,7 +387,7 @@
             if (!query) return;
 
             const resultsDiv = document.getElementById('asname-results');
-            resultsDiv.innerHTML = '<p class="loading">Searching...</p>';
+            resultsDiv.innerHTML = '<p class="loading" style="color: #7f8c8d; margin-top: 12px;">Searching...</p>';
 
             // Use a simple client-side search against the asinfo data
             // For now, redirect to AS page if it looks like an ASN
@@ -404,7 +397,7 @@
             }
 
             // Show a message that server-side search is coming
-            resultsDiv.innerHTML = '<p class="search-message">AS name search coming soon. For now, try an AS number.</p>';
+            resultsDiv.innerHTML = '<p style="color: #7f8c8d; margin-top: 12px; font-size: 13px;">AS name search coming soon. For now, try an AS number.</p>';
         });
 
         // IP lookup

internal/templates/prefix_detail.html

@@ -4,7 +4,7 @@
     <meta charset="UTF-8">
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
     <title>{{.Prefix}} - RouteWatch</title>
-    <style nonce="{{.CSPNonce}}">
+    <style>
         * {
             box-sizing: border-box;
         }
@@ -221,10 +221,6 @@
             border-radius: 4px;
             border: 1px solid #e0e0e0;
         }
-        .origin-item .peer-count {
-            color: #7f8c8d;
-            margin-left: 10px;
-        }
         .empty-state {
             text-align: center;
             padding: 40px;
@@ -292,7 +288,7 @@
                     {{else}}
                     No known origin
                     {{end}}
-                    <span class="peer-count">{{.PeerCount}} peer{{if ne .PeerCount 1}}s{{end}}</span>
+                    <span style="color: #7f8c8d; margin-left: 10px;">{{.PeerCount}} peer{{if ne .PeerCount 1}}s{{end}}</span>
                 </div>
                 {{end}}
             </div>

internal/templates/prefix_length.html

@@ -4,7 +4,7 @@
     <meta charset="UTF-8">
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
     <title>Prefixes with /{{ .MaskLength }} - RouteWatch</title>
-    <style nonce="{{.CSPNonce}}">
+    <style>
         * {
             box-sizing: border-box;
         }

internal/templates/status.html

@@ -4,7 +4,7 @@
     <meta charset="UTF-8">
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
     <title>RouteWatch Status</title>
-    <style nonce="{{.CSPNonce}}">
+    <style>
         * {
             box-sizing: border-box;
         }
@@ -130,7 +130,6 @@
             color: #ef4444;
         }
         .error {
-            display: none;
             background: #fee;
             color: #c00;
             padding: 10px;
@@ -174,7 +173,7 @@
     </nav>
 
     <main class="main-content">
-    <div id="error" class="error"></div>
+    <div id="error" class="error" style="display: none;"></div>
     <div class="status-grid">
         <div class="status-card">
             <h2>RouteWatch</h2>
@@ -385,7 +384,7 @@
         <!-- Handler stats will be dynamically added here -->
     </div>
     
-    <script nonce="{{.CSPNonce}}">
+    <script>
         function formatBytes(bytes) {
             if (bytes === 0) return '0 B';
             const k = 1024;