Compare commits
2
Commits
431d1d0481
..
next
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
e0b9c2685f | ||
|
|
ad4c3d91f1 |
@@ -141,7 +141,10 @@ routewatch/
|
|||||||
- **Batched Writes**: All database operations are batched for performance
|
- **Batched Writes**: All database operations are batched for performance
|
||||||
- **Backpressure**: Probabilistic message dropping when queues exceed 50% capacity
|
- **Backpressure**: Probabilistic message dropping when queues exceed 50% capacity
|
||||||
- **Graceful Shutdown**: 60-second timeout, flushes all pending batches
|
- **Graceful Shutdown**: 60-second timeout, flushes all pending batches
|
||||||
- **Reconnection**: Exponential backoff (5s-320s) with reset after 30s of stable connection
|
- **Reconnection**: Any end of the stream other than shutdown, including RIS Live
|
||||||
|
ending the response normally, marks the feed disconnected and reconnects with
|
||||||
|
exponential backoff (5s-320s). The backoff resets after a stream that lasted
|
||||||
|
more than 30s. A stream with no line for 60s is dropped and reconnected.
|
||||||
- **IP Lookup**: the most specific live route is found by looking up the
|
- **IP Lookup**: the most specific live route is found by looking up the
|
||||||
address's prefix at each mask length, longest first, in the prefix index
|
address's prefix at each mask length, longest first, in the prefix index
|
||||||
(at most 25 lookups for IPv4, 113 for IPv6); prefixes are stored in the
|
(at most 25 lookups for IPv4, 113 for IPv6); prefixes are stored in the
|
||||||
|
|||||||
@@ -128,7 +128,7 @@ func TestLiveCountsTrackWritesInRealtime(t *testing.T) {
|
|||||||
|
|
||||||
// A withdrawal removes one route.
|
// A withdrawal removes one route.
|
||||||
if err := db.DeleteLiveRouteBatch([]LiveRouteDeletion{
|
if err := db.DeleteLiveRouteBatch([]LiveRouteDeletion{
|
||||||
{Prefix: "203.0.113.0/24", PeerIP: "192.0.2.1", IPVersion: ipVersionV4},
|
{Prefix: "203.0.113.0/24", OriginASN: 64501, PeerIP: "192.0.2.1", IPVersion: ipVersionV4},
|
||||||
}); err != nil {
|
}); err != nil {
|
||||||
t.Fatalf("DeleteLiveRouteBatch: %v", err)
|
t.Fatalf("DeleteLiveRouteBatch: %v", err)
|
||||||
}
|
}
|
||||||
@@ -327,11 +327,13 @@ func announceRoutes(db *Database, batch bool, routes []*LiveRoute) error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// withdrawRoutes removes routes in one DeleteLiveRouteBatch, or with one
|
// withdrawRoutes removes routes in one DeleteLiveRouteBatch, or with one
|
||||||
// DeleteLiveRoute each.
|
// DeleteLiveRoute each. It names each route by prefix and peer only, with no
|
||||||
|
// origin ASN, as a withdrawal from the feed does when its message carries no AS
|
||||||
|
// path.
|
||||||
func withdrawRoutes(db *Database, batch bool, routes []*LiveRoute) error {
|
func withdrawRoutes(db *Database, batch bool, routes []*LiveRoute) error {
|
||||||
if !batch {
|
if !batch {
|
||||||
for _, route := range routes {
|
for _, route := range routes {
|
||||||
if err := db.DeleteLiveRoute(route.Prefix, route.PeerIP); err != nil {
|
if err := db.DeleteLiveRoute(route.Prefix, 0, route.PeerIP); err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -228,22 +228,21 @@ func (d *Database) beginTx() (*loggingTx, error) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// A live-route upsert is an UPDATE followed, only when no row matched, by an
|
// A live-route upsert is an UPDATE followed, only when no row matched, by an
|
||||||
// INSERT. A live route is keyed by prefix and peer, so an announcement replaces
|
// INSERT. The UPDATE's rows-affected count (1 for an existing key, 0 for a new
|
||||||
// the peer's route for the prefix whatever its origin AS. The UPDATE's
|
// one) is what lets the in-memory route counters stay exact without a COUNT(*).
|
||||||
// rows-affected count (1 for an existing key, 0 for a new one) is what lets the
|
// Callers hold the database write lock, so no other writer can insert the same
|
||||||
// in-memory route counters stay exact without a COUNT(*). Callers hold the
|
// key between the two statements. The id column is set only on INSERT, so an
|
||||||
// database write lock, so no other writer can insert the same key between the
|
// updated route keeps its original id, exactly as the previous ON CONFLICT
|
||||||
// two statements. The id column is set only on INSERT, so an updated route
|
// upsert did.
|
||||||
// keeps its original id, exactly as the previous ON CONFLICT upsert did.
|
|
||||||
const (
|
const (
|
||||||
updateLiveRouteV4SQL = `UPDATE live_routes_v4 SET mask_length = ?, origin_asn = ?, as_path = ?,
|
updateLiveRouteV4SQL = `UPDATE live_routes_v4 SET mask_length = ?, as_path = ?, next_hop = ?,
|
||||||
next_hop = ?, last_updated = ? WHERE prefix = ? AND peer_ip = ?`
|
last_updated = ? WHERE prefix = ? AND origin_asn = ? AND peer_ip = ?`
|
||||||
|
|
||||||
insertLiveRouteV4SQL = `INSERT INTO live_routes_v4 (id, prefix, mask_length, origin_asn, peer_ip,
|
insertLiveRouteV4SQL = `INSERT INTO live_routes_v4 (id, prefix, mask_length, origin_asn, peer_ip,
|
||||||
as_path, next_hop, last_updated) VALUES (?, ?, ?, ?, ?, ?, ?, ?)`
|
as_path, next_hop, last_updated) VALUES (?, ?, ?, ?, ?, ?, ?, ?)`
|
||||||
|
|
||||||
updateLiveRouteV6SQL = `UPDATE live_routes_v6 SET mask_length = ?, origin_asn = ?, as_path = ?,
|
updateLiveRouteV6SQL = `UPDATE live_routes_v6 SET mask_length = ?, as_path = ?, next_hop = ?,
|
||||||
next_hop = ?, last_updated = ? WHERE prefix = ? AND peer_ip = ?`
|
last_updated = ? WHERE prefix = ? AND origin_asn = ? AND peer_ip = ?`
|
||||||
|
|
||||||
insertLiveRouteV6SQL = `INSERT INTO live_routes_v6 (id, prefix, mask_length, origin_asn, peer_ip,
|
insertLiveRouteV6SQL = `INSERT INTO live_routes_v6 (id, prefix, mask_length, origin_asn, peer_ip,
|
||||||
as_path, next_hop, last_updated) VALUES (?, ?, ?, ?, ?, ?, ?, ?)`
|
as_path, next_hop, last_updated) VALUES (?, ?, ?, ?, ?, ?, ?, ?)`
|
||||||
@@ -262,8 +261,8 @@ const (
|
|||||||
// live route for its prefix.
|
// live route for its prefix.
|
||||||
func upsertRouteRowV4(upd, ins, has *sql.Stmt, route *LiveRoute, pathJSON string) (
|
func upsertRouteRowV4(upd, ins, has *sql.Stmt, route *LiveRoute, pathJSON string) (
|
||||||
inserted, newPrefix bool, err error) {
|
inserted, newPrefix bool, err error) {
|
||||||
res, err := upd.Exec(route.MaskLength, route.OriginASN, pathJSON, route.NextHop, route.LastUpdated,
|
res, err := upd.Exec(route.MaskLength, pathJSON, route.NextHop, route.LastUpdated,
|
||||||
route.Prefix, route.PeerIP)
|
route.Prefix, route.OriginASN, route.PeerIP)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return false, false, err
|
return false, false, err
|
||||||
}
|
}
|
||||||
@@ -294,8 +293,8 @@ func upsertRouteRowV4(upd, ins, has *sql.Stmt, route *LiveRoute, pathJSON string
|
|||||||
// live route for its prefix.
|
// live route for its prefix.
|
||||||
func upsertRouteRowV6(upd, ins, has *sql.Stmt, route *LiveRoute, pathJSON string) (
|
func upsertRouteRowV6(upd, ins, has *sql.Stmt, route *LiveRoute, pathJSON string) (
|
||||||
inserted, newPrefix bool, err error) {
|
inserted, newPrefix bool, err error) {
|
||||||
res, err := upd.Exec(route.MaskLength, route.OriginASN, pathJSON, route.NextHop, route.LastUpdated,
|
res, err := upd.Exec(route.MaskLength, pathJSON, route.NextHop, route.LastUpdated,
|
||||||
route.Prefix, route.PeerIP)
|
route.Prefix, route.OriginASN, route.PeerIP)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return false, false, err
|
return false, false, err
|
||||||
}
|
}
|
||||||
@@ -442,18 +441,32 @@ func (d *Database) DeleteLiveRouteBatch(deletions []LiveRouteDeletion) error {
|
|||||||
}
|
}
|
||||||
}()
|
}()
|
||||||
|
|
||||||
// Prepare statements for both IPv4 and IPv6 tables
|
// No longer need to separate deletions since we handle them in the loop below
|
||||||
deleteV4, err := tx.Prepare(`DELETE FROM live_routes_v4 WHERE prefix = ? AND peer_ip = ?`)
|
|
||||||
if err != nil {
|
|
||||||
return fmt.Errorf("failed to prepare IPv4 delete statement: %w", err)
|
|
||||||
}
|
|
||||||
defer func() { _ = deleteV4.Close() }()
|
|
||||||
|
|
||||||
deleteV6, err := tx.Prepare(`DELETE FROM live_routes_v6 WHERE prefix = ? AND peer_ip = ?`)
|
// Prepare statements for both IPv4 and IPv6 tables
|
||||||
|
stmtV4WithOrigin, err := tx.Prepare(`DELETE FROM live_routes_v4 WHERE prefix = ? AND origin_asn = ? AND peer_ip = ?`)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to prepare IPv6 delete statement: %w", err)
|
return fmt.Errorf("failed to prepare IPv4 delete with origin statement: %w", err)
|
||||||
}
|
}
|
||||||
defer func() { _ = deleteV6.Close() }()
|
defer func() { _ = stmtV4WithOrigin.Close() }()
|
||||||
|
|
||||||
|
stmtV4WithoutOrigin, err := tx.Prepare(`DELETE FROM live_routes_v4 WHERE prefix = ? AND peer_ip = ?`)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to prepare IPv4 delete without origin statement: %w", err)
|
||||||
|
}
|
||||||
|
defer func() { _ = stmtV4WithoutOrigin.Close() }()
|
||||||
|
|
||||||
|
stmtV6WithOrigin, err := tx.Prepare(`DELETE FROM live_routes_v6 WHERE prefix = ? AND origin_asn = ? AND peer_ip = ?`)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to prepare IPv6 delete with origin statement: %w", err)
|
||||||
|
}
|
||||||
|
defer func() { _ = stmtV6WithOrigin.Close() }()
|
||||||
|
|
||||||
|
stmtV6WithoutOrigin, err := tx.Prepare(`DELETE FROM live_routes_v6 WHERE prefix = ? AND peer_ip = ?`)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to prepare IPv6 delete without origin statement: %w", err)
|
||||||
|
}
|
||||||
|
defer func() { _ = stmtV6WithoutOrigin.Close() }()
|
||||||
|
|
||||||
hasV4, err := tx.Prepare(prefixHasLiveRouteV4SQL)
|
hasV4, err := tx.Prepare(prefixHasLiveRouteV4SQL)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -472,18 +485,38 @@ func (d *Database) DeleteLiveRouteBatch(deletions []LiveRouteDeletion) error {
|
|||||||
// Mask lengths of the prefixes this batch leaves with no live route.
|
// Mask lengths of the prefixes this batch leaves with no live route.
|
||||||
var gonePrefixMaskLengthsV4, gonePrefixMaskLengthsV6 []int
|
var gonePrefixMaskLengthsV4, gonePrefixMaskLengthsV6 []int
|
||||||
for _, del := range deletions {
|
for _, del := range deletions {
|
||||||
stmt := deleteV4
|
var stmt *sql.Stmt
|
||||||
if del.IPVersion != ipVersionV4 {
|
|
||||||
stmt = deleteV6
|
// Select appropriate statement based on IP version and whether we have origin ASN
|
||||||
|
//nolint:nestif // Clear logic for selecting the right statement
|
||||||
|
if del.IPVersion == ipVersionV4 {
|
||||||
|
if del.OriginASN == 0 {
|
||||||
|
stmt = stmtV4WithoutOrigin
|
||||||
|
} else {
|
||||||
|
stmt = stmtV4WithOrigin
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
if del.OriginASN == 0 {
|
||||||
|
stmt = stmtV6WithoutOrigin
|
||||||
|
} else {
|
||||||
|
stmt = stmtV6WithOrigin
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Execute deletion
|
||||||
|
var res sql.Result
|
||||||
|
if del.OriginASN == 0 {
|
||||||
|
res, err = stmt.Exec(del.Prefix, del.PeerIP)
|
||||||
|
} else {
|
||||||
|
res, err = stmt.Exec(del.Prefix, del.OriginASN, del.PeerIP)
|
||||||
}
|
}
|
||||||
|
|
||||||
res, err := stmt.Exec(del.Prefix, del.PeerIP)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to delete route %s: %w", del.Prefix, err)
|
return fmt.Errorf("failed to delete route %s: %w", del.Prefix, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
// The feed often withdraws a route that is not live, which deletes
|
// A deletion with no origin ASN can remove several rows, so use the
|
||||||
// nothing, so the in-memory route counters use the rows-affected count.
|
// exact rows-affected count to keep the in-memory route counters right.
|
||||||
affected, err := res.RowsAffected()
|
affected, err := res.RowsAffected()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to count deleted route %s: %w", del.Prefix, err)
|
return fmt.Errorf("failed to count deleted route %s: %w", del.Prefix, err)
|
||||||
@@ -1249,8 +1282,9 @@ func (d *Database) UpsertLiveRoute(route *LiveRoute) error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// DeleteLiveRoute deletes the live route the peer has for the prefix
|
// DeleteLiveRoute deletes a live route
|
||||||
func (d *Database) DeleteLiveRoute(prefix, peerIP string) error {
|
// If originASN is 0, deletes all routes for the prefix/peer combination
|
||||||
|
func (d *Database) DeleteLiveRoute(prefix string, originASN int, peerIP string) error {
|
||||||
d.lock("DeleteLiveRoute")
|
d.lock("DeleteLiveRoute")
|
||||||
defer d.unlock()
|
defer d.unlock()
|
||||||
|
|
||||||
@@ -1275,12 +1309,22 @@ func (d *Database) DeleteLiveRoute(prefix, peerIP string) error {
|
|||||||
}()
|
}()
|
||||||
|
|
||||||
// Literal per-table queries (rather than one formatted with the table name)
|
// Literal per-table queries (rather than one formatted with the table name)
|
||||||
// so the delete carries no dynamically built SQL.
|
// so the delete carries no dynamically built SQL. A delete with no origin
|
||||||
|
// ASN can remove several rows.
|
||||||
var res sql.Result
|
var res sql.Result
|
||||||
if isV4 {
|
switch {
|
||||||
|
case isV4 && originASN == 0:
|
||||||
res, err = tx.Exec(`DELETE FROM live_routes_v4 WHERE prefix = ? AND peer_ip = ?`, prefix, peerIP)
|
res, err = tx.Exec(`DELETE FROM live_routes_v4 WHERE prefix = ? AND peer_ip = ?`, prefix, peerIP)
|
||||||
} else {
|
case isV4:
|
||||||
|
res, err = tx.Exec(
|
||||||
|
`DELETE FROM live_routes_v4 WHERE prefix = ? AND origin_asn = ? AND peer_ip = ?`,
|
||||||
|
prefix, originASN, peerIP)
|
||||||
|
case originASN == 0:
|
||||||
res, err = tx.Exec(`DELETE FROM live_routes_v6 WHERE prefix = ? AND peer_ip = ?`, prefix, peerIP)
|
res, err = tx.Exec(`DELETE FROM live_routes_v6 WHERE prefix = ? AND peer_ip = ?`, prefix, peerIP)
|
||||||
|
default:
|
||||||
|
res, err = tx.Exec(
|
||||||
|
`DELETE FROM live_routes_v6 WHERE prefix = ? AND origin_asn = ? AND peer_ip = ?`,
|
||||||
|
prefix, originASN, peerIP)
|
||||||
}
|
}
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
@@ -1588,16 +1632,17 @@ func (d *Database) GetASPeersContext(ctx context.Context, asn int) ([]ASPeer, er
|
|||||||
}
|
}
|
||||||
|
|
||||||
// GetPrefixDetails returns detailed information about a prefix
|
// GetPrefixDetails returns detailed information about a prefix
|
||||||
func (d *Database) GetPrefixDetails(prefix string) ([]LiveRoute, error) {
|
func (d *Database) GetPrefixDetails(prefix string) ([]LiveRoute, map[int]ASN, error) {
|
||||||
return d.GetPrefixDetailsContext(context.Background(), prefix)
|
return d.GetPrefixDetailsContext(context.Background(), prefix)
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetPrefixDetailsContext returns detailed information about a prefix with context support
|
// GetPrefixDetailsContext returns the live routes for a prefix and, keyed by
|
||||||
func (d *Database) GetPrefixDetailsContext(ctx context.Context, prefix string) ([]LiveRoute, error) {
|
// AS number, the handle and description of each AS that originates it.
|
||||||
|
func (d *Database) GetPrefixDetailsContext(ctx context.Context, prefix string) ([]LiveRoute, map[int]ASN, error) {
|
||||||
// Determine if it's IPv4 or IPv6 by parsing the prefix
|
// Determine if it's IPv4 or IPv6 by parsing the prefix
|
||||||
_, ipnet, err := net.ParseCIDR(prefix)
|
_, ipnet, err := net.ParseCIDR(prefix)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, fmt.Errorf("invalid prefix format: %w", err)
|
return nil, nil, fmt.Errorf("invalid prefix format: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
tableName := "live_routes_v4"
|
tableName := "live_routes_v4"
|
||||||
@@ -1619,11 +1664,12 @@ func (d *Database) GetPrefixDetailsContext(ctx context.Context, prefix string) (
|
|||||||
|
|
||||||
rows, err := d.db.QueryContext(ctx, query, prefix)
|
rows, err := d.db.QueryContext(ctx, query, prefix)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, fmt.Errorf("failed to query prefix details: %w", err)
|
return nil, nil, fmt.Errorf("failed to query prefix details: %w", err)
|
||||||
}
|
}
|
||||||
defer func() { _ = rows.Close() }()
|
defer func() { _ = rows.Close() }()
|
||||||
|
|
||||||
var routes []LiveRoute
|
var routes []LiveRoute
|
||||||
|
origins := make(map[int]ASN)
|
||||||
for rows.Next() {
|
for rows.Next() {
|
||||||
var route LiveRoute
|
var route LiveRoute
|
||||||
var pathJSON string
|
var pathJSON string
|
||||||
@@ -1646,13 +1692,18 @@ func (d *Database) GetPrefixDetailsContext(ctx context.Context, prefix string) (
|
|||||||
route.IPVersion = ipVersion
|
route.IPVersion = ipVersion
|
||||||
route.MaskLength, _ = ipnet.Mask.Size()
|
route.MaskLength, _ = ipnet.Mask.Size()
|
||||||
routes = append(routes, route)
|
routes = append(routes, route)
|
||||||
|
origins[route.OriginASN] = ASN{
|
||||||
|
ASN: route.OriginASN,
|
||||||
|
Handle: handle.String,
|
||||||
|
Description: description.String,
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if len(routes) == 0 {
|
if len(routes) == 0 {
|
||||||
return nil, fmt.Errorf("%w: %s", ErrNoRoute, prefix)
|
return nil, nil, fmt.Errorf("%w: %s", ErrNoRoute, prefix)
|
||||||
}
|
}
|
||||||
|
|
||||||
return routes, nil
|
return routes, origins, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetRandomPrefixesByLength returns a random sample of prefixes with the specified mask length
|
// GetRandomPrefixesByLength returns a random sample of prefixes with the specified mask length
|
||||||
|
|||||||
@@ -13,7 +13,6 @@ import (
|
|||||||
"git.eeqj.de/sneak/routewatch/internal/config"
|
"git.eeqj.de/sneak/routewatch/internal/config"
|
||||||
"git.eeqj.de/sneak/routewatch/internal/logger"
|
"git.eeqj.de/sneak/routewatch/internal/logger"
|
||||||
"github.com/google/uuid"
|
"github.com/google/uuid"
|
||||||
"github.com/mattn/go-sqlite3"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
// tempStoreMemory is the PRAGMA temp_store value meaning "hold temp B-trees in
|
// tempStoreMemory is the PRAGMA temp_store value meaning "hold temp B-trees in
|
||||||
@@ -123,8 +122,8 @@ func TestGetIPInfoFindsMostSpecificLiveRoute(t *testing.T) {
|
|||||||
lookup("2001:db9::1", "")
|
lookup("2001:db9::1", "")
|
||||||
|
|
||||||
err = db.DeleteLiveRouteBatch([]LiveRouteDeletion{
|
err = db.DeleteLiveRouteBatch([]LiveRouteDeletion{
|
||||||
{Prefix: "10.1.2.0/24", PeerIP: testPeerIP, IPVersion: ipVersionV4},
|
{Prefix: "10.1.2.0/24", OriginASN: 64502, PeerIP: testPeerIP, IPVersion: ipVersionV4},
|
||||||
{Prefix: "2001:db8:1:2::/64", PeerIP: testPeerIP, IPVersion: ipVersionV6},
|
{Prefix: "2001:db8:1:2::/64", OriginASN: 64502, PeerIP: testPeerIP, IPVersion: ipVersionV6},
|
||||||
})
|
})
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("DeleteLiveRouteBatch: %v", err)
|
t.Fatalf("DeleteLiveRouteBatch: %v", err)
|
||||||
@@ -206,40 +205,6 @@ func TestGetIPInfoIgnoresShortRoutes(t *testing.T) {
|
|||||||
lookup("2001:db8::1", "2001:db8::/32", 64502)
|
lookup("2001:db8::1", "2001:db8::/32", 64502)
|
||||||
}
|
}
|
||||||
|
|
||||||
// TestLiveRouteTablesHoldOneRoutePerPrefixAndPeer checks that each live route
|
|
||||||
// table refuses a second route from a peer for a prefix, even with another
|
|
||||||
// origin AS. An upsert updates the peer's route before it would insert one, so
|
|
||||||
// only an insert straight into the table shows what the table allows.
|
|
||||||
func TestLiveRouteTablesHoldOneRoutePerPrefixAndPeer(t *testing.T) {
|
|
||||||
db, err := New(&config.Config{StateDir: t.TempDir()}, logger.New())
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("failed to create database: %v", err)
|
|
||||||
}
|
|
||||||
defer func() { _ = db.Close() }()
|
|
||||||
|
|
||||||
const otherOriginASN = 64501
|
|
||||||
ts := time.Date(2026, 1, 2, 3, 4, 5, 0, time.UTC)
|
|
||||||
for _, tt := range []struct {
|
|
||||||
route *LiveRoute
|
|
||||||
insertSQL string
|
|
||||||
}{
|
|
||||||
{route: mkV4Route(t, "198.51.100.0/24", 64500, ts), insertSQL: insertLiveRouteV4SQL},
|
|
||||||
{route: mkV6Route("2001:db8::/32", 64500, ts), insertSQL: insertLiveRouteV6SQL},
|
|
||||||
} {
|
|
||||||
if err := db.UpsertLiveRoute(tt.route); err != nil {
|
|
||||||
t.Fatalf("UpsertLiveRoute(%s): %v", tt.route.Prefix, err)
|
|
||||||
}
|
|
||||||
|
|
||||||
_, err := db.db.Exec(tt.insertSQL, uuid.NewString(), tt.route.Prefix, tt.route.MaskLength,
|
|
||||||
otherOriginASN, tt.route.PeerIP, "[]", tt.route.NextHop, ts)
|
|
||||||
var sqliteErr sqlite3.Error
|
|
||||||
if !errors.As(err, &sqliteErr) || sqliteErr.ExtendedCode != sqlite3.ErrConstraintUnique {
|
|
||||||
t.Errorf("second route from peer %s for %s: error %v, want a UNIQUE constraint error",
|
|
||||||
tt.route.PeerIP, tt.route.Prefix, err)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// TestConnectionPoolPragmas holds several pooled connections open at once and
|
// TestConnectionPoolPragmas holds several pooled connections open at once and
|
||||||
// checks each one carries the per-connection settings from the DSN, plus the
|
// checks each one carries the per-connection settings from the DSN, plus the
|
||||||
// process-wide hard heap limit, and sees the new file with auto_vacuum
|
// process-wide hard heap limit, and sees the new file with auto_vacuum
|
||||||
@@ -341,6 +306,7 @@ func TestVacuumReturnsFreePages(t *testing.T) {
|
|||||||
routes = append(routes, route)
|
routes = append(routes, route)
|
||||||
deletions = append(deletions, LiveRouteDeletion{
|
deletions = append(deletions, LiveRouteDeletion{
|
||||||
Prefix: route.Prefix,
|
Prefix: route.Prefix,
|
||||||
|
OriginASN: asn,
|
||||||
PeerIP: route.PeerIP,
|
PeerIP: route.PeerIP,
|
||||||
IPVersion: ipVersionV4,
|
IPVersion: ipVersionV4,
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -55,7 +55,7 @@ type Store interface {
|
|||||||
// Live route operations
|
// Live route operations
|
||||||
UpsertLiveRoute(route *LiveRoute) error
|
UpsertLiveRoute(route *LiveRoute) error
|
||||||
UpsertLiveRouteBatch(routes []*LiveRoute) error
|
UpsertLiveRouteBatch(routes []*LiveRoute) error
|
||||||
DeleteLiveRoute(prefix, peerIP string) error
|
DeleteLiveRoute(prefix string, originASN int, peerIP string) error
|
||||||
DeleteLiveRouteBatch(deletions []LiveRouteDeletion) error
|
DeleteLiveRouteBatch(deletions []LiveRouteDeletion) error
|
||||||
GetPrefixDistribution() (ipv4 []PrefixDistribution, ipv6 []PrefixDistribution, err error)
|
GetPrefixDistribution() (ipv4 []PrefixDistribution, ipv6 []PrefixDistribution, err error)
|
||||||
GetPrefixDistributionContext(ctx context.Context) (ipv4 []PrefixDistribution, ipv6 []PrefixDistribution, err error)
|
GetPrefixDistributionContext(ctx context.Context) (ipv4 []PrefixDistribution, ipv6 []PrefixDistribution, err error)
|
||||||
@@ -76,8 +76,8 @@ type Store interface {
|
|||||||
GetASDetailsContext(ctx context.Context, asn int) (*ASN, []LiveRoute, error)
|
GetASDetailsContext(ctx context.Context, asn int) (*ASN, []LiveRoute, error)
|
||||||
GetASPeers(asn int) ([]ASPeer, error)
|
GetASPeers(asn int) ([]ASPeer, error)
|
||||||
GetASPeersContext(ctx context.Context, asn int) ([]ASPeer, error)
|
GetASPeersContext(ctx context.Context, asn int) ([]ASPeer, error)
|
||||||
GetPrefixDetails(prefix string) ([]LiveRoute, error)
|
GetPrefixDetails(prefix string) ([]LiveRoute, map[int]ASN, error)
|
||||||
GetPrefixDetailsContext(ctx context.Context, prefix string) ([]LiveRoute, error)
|
GetPrefixDetailsContext(ctx context.Context, prefix string) ([]LiveRoute, map[int]ASN, error)
|
||||||
GetRandomPrefixesByLength(maskLength, ipVersion, limit int) ([]LiveRoute, error)
|
GetRandomPrefixesByLength(maskLength, ipVersion, limit int) ([]LiveRoute, error)
|
||||||
GetRandomPrefixesByLengthContext(ctx context.Context, maskLength, ipVersion, limit int) ([]LiveRoute, error)
|
GetRandomPrefixesByLengthContext(ctx context.Context, maskLength, ipVersion, limit int) ([]LiveRoute, error)
|
||||||
|
|
||||||
|
|||||||
@@ -114,6 +114,7 @@ type IPInfo struct {
|
|||||||
// LiveRouteDeletion represents parameters for deleting a live route
|
// LiveRouteDeletion represents parameters for deleting a live route
|
||||||
type LiveRouteDeletion struct {
|
type LiveRouteDeletion struct {
|
||||||
Prefix string
|
Prefix string
|
||||||
|
OriginASN int
|
||||||
PeerIP string
|
PeerIP string
|
||||||
IPVersion int
|
IPVersion int
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -107,7 +107,7 @@ CREATE TABLE IF NOT EXISTS live_routes_v4 (
|
|||||||
as_path TEXT NOT NULL, -- JSON array
|
as_path TEXT NOT NULL, -- JSON array
|
||||||
next_hop TEXT NOT NULL,
|
next_hop TEXT NOT NULL,
|
||||||
last_updated DATETIME NOT NULL,
|
last_updated DATETIME NOT NULL,
|
||||||
UNIQUE(prefix, peer_ip) -- a peer has at most one route for a prefix
|
UNIQUE(prefix, origin_asn, peer_ip)
|
||||||
);
|
);
|
||||||
|
|
||||||
-- IPv6 routing table maintained by PrefixHandler
|
-- IPv6 routing table maintained by PrefixHandler
|
||||||
@@ -120,7 +120,7 @@ CREATE TABLE IF NOT EXISTS live_routes_v6 (
|
|||||||
as_path TEXT NOT NULL, -- JSON array
|
as_path TEXT NOT NULL, -- JSON array
|
||||||
next_hop TEXT NOT NULL,
|
next_hop TEXT NOT NULL,
|
||||||
last_updated DATETIME NOT NULL,
|
last_updated DATETIME NOT NULL,
|
||||||
UNIQUE(prefix, peer_ip) -- a peer has at most one route for a prefix
|
UNIQUE(prefix, origin_asn, peer_ip)
|
||||||
);
|
);
|
||||||
|
|
||||||
-- Indexes for live_routes_v4 table
|
-- Indexes for live_routes_v4 table
|
||||||
|
|||||||
@@ -205,7 +205,7 @@ func (m *mockStore) UpsertLiveRoute(route *database.LiveRoute) error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// DeleteLiveRoute mock implementation
|
// DeleteLiveRoute mock implementation
|
||||||
func (m *mockStore) DeleteLiveRoute(prefix, peerIP string) error {
|
func (m *mockStore) DeleteLiveRoute(prefix string, originASN int, peerIP string) error {
|
||||||
// Simple mock - just return nil
|
// Simple mock - just return nil
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
@@ -252,13 +252,15 @@ func (m *mockStore) GetASDetailsContext(ctx context.Context, asn int) (*database
|
|||||||
}
|
}
|
||||||
|
|
||||||
// GetPrefixDetails mock implementation
|
// GetPrefixDetails mock implementation
|
||||||
func (m *mockStore) GetPrefixDetails(prefix string) ([]database.LiveRoute, error) {
|
func (m *mockStore) GetPrefixDetails(prefix string) ([]database.LiveRoute, map[int]database.ASN, error) {
|
||||||
// Return empty routes for now
|
// Return empty routes for now
|
||||||
return []database.LiveRoute{}, nil
|
return []database.LiveRoute{}, map[int]database.ASN{}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetPrefixDetailsContext mock implementation with context support
|
// GetPrefixDetailsContext mock implementation with context support
|
||||||
func (m *mockStore) GetPrefixDetailsContext(ctx context.Context, prefix string) ([]database.LiveRoute, error) {
|
func (m *mockStore) GetPrefixDetailsContext(
|
||||||
|
ctx context.Context, prefix string,
|
||||||
|
) ([]database.LiveRoute, map[int]database.ASN, error) {
|
||||||
return m.GetPrefixDetails(prefix)
|
return m.GetPrefixDetails(prefix)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -108,14 +108,14 @@ func (h *PrefixHandler) HandleMessage(msg *ristypes.RISMessage) {
|
|||||||
// Withdrawals are queued before announcements, because the batch keeps
|
// Withdrawals are queued before announcements, because the batch keeps
|
||||||
// each peer's last update for a prefix: a message that lists a prefix as
|
// each peer's last update for a prefix: a message that lists a prefix as
|
||||||
// both withdrawn and announced keeps the route (RFC 4271 section 4.3).
|
// both withdrawn and announced keeps the route (RFC 4271 section 4.3).
|
||||||
// A withdrawal names only the prefix and peer: the message's AS path, and
|
|
||||||
// so its origin AS, belongs to the announced prefixes.
|
|
||||||
for _, prefix := range msg.Withdrawals {
|
for _, prefix := range msg.Withdrawals {
|
||||||
h.batch = append(h.batch, prefixUpdate{
|
h.batch = append(h.batch, prefixUpdate{
|
||||||
prefix: canonicalPrefix(prefix),
|
prefix: canonicalPrefix(prefix),
|
||||||
|
originASN: originASN, // Use the originASN from path if available
|
||||||
peer: msg.Peer,
|
peer: msg.Peer,
|
||||||
messageType: "withdrawal",
|
messageType: "withdrawal",
|
||||||
timestamp: timestamp,
|
timestamp: timestamp,
|
||||||
|
path: msg.Path,
|
||||||
})
|
})
|
||||||
// Record withdrawal in metrics
|
// Record withdrawal in metrics
|
||||||
if h.metrics != nil {
|
if h.metrics != nil {
|
||||||
@@ -221,6 +221,7 @@ func (h *PrefixHandler) flushBatchLocked() {
|
|||||||
// Create deletion record for batch delete
|
// Create deletion record for batch delete
|
||||||
routesToDelete = append(routesToDelete, database.LiveRouteDeletion{
|
routesToDelete = append(routesToDelete, database.LiveRouteDeletion{
|
||||||
Prefix: update.prefix,
|
Prefix: update.prefix,
|
||||||
|
OriginASN: update.originASN,
|
||||||
PeerIP: update.peer,
|
PeerIP: update.peer,
|
||||||
IPVersion: ipVersion,
|
IPVersion: ipVersion,
|
||||||
})
|
})
|
||||||
@@ -424,24 +425,51 @@ func (h *PrefixHandler) processAnnouncementDirect(update prefixUpdate) {
|
|||||||
// processWithdrawalDirect handles removing a route directly without prefix table
|
// processWithdrawalDirect handles removing a route directly without prefix table
|
||||||
// nolint:unused // kept for potential future use
|
// nolint:unused // kept for potential future use
|
||||||
func (h *PrefixHandler) processWithdrawalDirect(update prefixUpdate) {
|
func (h *PrefixHandler) processWithdrawalDirect(update prefixUpdate) {
|
||||||
if err := h.db.DeleteLiveRoute(update.prefix, update.peer); err != nil {
|
// For withdrawals, we need to delete the route from live_routes
|
||||||
h.logger.Error("Failed to delete live route",
|
if update.originASN > 0 {
|
||||||
"prefix", update.prefix,
|
if err := h.db.DeleteLiveRoute(update.prefix, update.originASN, update.peer); err != nil {
|
||||||
"peer", update.peer,
|
h.logger.Error("Failed to delete live route",
|
||||||
"error", err,
|
"prefix", update.prefix,
|
||||||
)
|
"origin_asn", update.originASN,
|
||||||
|
"peer", update.peer,
|
||||||
|
"error", err,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
// If no origin ASN, just delete all routes for this prefix from this peer
|
||||||
|
if err := h.db.DeleteLiveRoute(update.prefix, 0, update.peer); err != nil {
|
||||||
|
h.logger.Error("Failed to delete live route (no origin ASN)",
|
||||||
|
"prefix", update.prefix,
|
||||||
|
"peer", update.peer,
|
||||||
|
"error", err,
|
||||||
|
)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// processWithdrawal handles removing a route from the live routing table
|
// processWithdrawal handles removing a route from the live routing table
|
||||||
// nolint:unused // kept for potential future use
|
// nolint:unused // kept for potential future use
|
||||||
func (h *PrefixHandler) processWithdrawal(_ *database.Prefix, update prefixUpdate) {
|
func (h *PrefixHandler) processWithdrawal(_ *database.Prefix, update prefixUpdate) {
|
||||||
if err := h.db.DeleteLiveRoute(update.prefix, update.peer); err != nil {
|
// For withdrawals, we need to delete the route from live_routes
|
||||||
h.logger.Error("Failed to delete live route",
|
// Since we have the origin ASN from the update, we can delete the specific route
|
||||||
"prefix", update.prefix,
|
if update.originASN > 0 {
|
||||||
"peer", update.peer,
|
if err := h.db.DeleteLiveRoute(update.prefix, update.originASN, update.peer); err != nil {
|
||||||
"error", err,
|
h.logger.Error("Failed to delete live route",
|
||||||
)
|
"prefix", update.prefix,
|
||||||
|
"origin_asn", update.originASN,
|
||||||
|
"peer", update.peer,
|
||||||
|
"error", err,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
// If no origin ASN, just delete all routes for this prefix from this peer
|
||||||
|
if err := h.db.DeleteLiveRoute(update.prefix, 0, update.peer); err != nil {
|
||||||
|
h.logger.Error("Failed to delete live route (no origin ASN)",
|
||||||
|
"prefix", update.prefix,
|
||||||
|
"peer", update.peer,
|
||||||
|
"error", err,
|
||||||
|
)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -3,7 +3,6 @@ package routewatch
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"errors"
|
"errors"
|
||||||
"fmt"
|
|
||||||
"slices"
|
"slices"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
@@ -171,7 +170,7 @@ func TestPrefixHandlerAppliesEachPeersLastUpdateInABatch(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
ctx := context.Background()
|
ctx := context.Background()
|
||||||
routes, err := db.GetPrefixDetailsContext(ctx, prefix)
|
routes, _, err := db.GetPrefixDetailsContext(ctx, prefix)
|
||||||
if err != nil && !errors.Is(err, database.ErrNoRoute) {
|
if err != nil && !errors.Is(err, database.ErrNoRoute) {
|
||||||
t.Fatalf("GetPrefixDetailsContext: %v", err)
|
t.Fatalf("GetPrefixDetailsContext: %v", err)
|
||||||
}
|
}
|
||||||
@@ -183,155 +182,32 @@ func TestPrefixHandlerAppliesEachPeersLastUpdateInABatch(t *testing.T) {
|
|||||||
t.Errorf("peers with a live route for %s = %v, want %v", prefix, gotPeers, tt.wantPeers)
|
t.Errorf("peers with a live route for %s = %v, want %v", prefix, gotPeers, tt.wantPeers)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
stats, err := db.GetStatsContext(ctx)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("GetStatsContext: %v", err)
|
||||||
|
}
|
||||||
|
tableRoutesV4, _, err := db.GetLiveRouteCountsContext(ctx)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("GetLiveRouteCountsContext: %v", err)
|
||||||
|
}
|
||||||
|
if stats.IPv4Routes != len(tt.wantPeers) || tableRoutesV4 != len(tt.wantPeers) {
|
||||||
|
t.Errorf("IPv4 live routes: %d in memory, %d in the table, want %d",
|
||||||
|
stats.IPv4Routes, tableRoutesV4, len(tt.wantPeers))
|
||||||
|
}
|
||||||
|
|
||||||
var wantDistribution []database.PrefixDistribution
|
var wantDistribution []database.PrefixDistribution
|
||||||
if len(tt.wantPeers) > 0 {
|
if len(tt.wantPeers) > 0 {
|
||||||
wantDistribution = []database.PrefixDistribution{{MaskLength: prefixMaskLength, Count: 1}}
|
wantDistribution = []database.PrefixDistribution{{MaskLength: prefixMaskLength, Count: 1}}
|
||||||
}
|
}
|
||||||
assertCounts(t, db, ipv4Version, len(tt.wantPeers), wantDistribution)
|
queryDistributionV4, _, err := db.GetPrefixDistributionContext(ctx)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("GetPrefixDistributionContext: %v", err)
|
||||||
|
}
|
||||||
|
if !slices.Equal(stats.IPv4PrefixDistribution, wantDistribution) ||
|
||||||
|
!slices.Equal(queryDistributionV4, wantDistribution) {
|
||||||
|
t.Errorf("IPv4 prefix distribution: %v in memory, %v from the table, want %v",
|
||||||
|
stats.IPv4PrefixDistribution, queryDistributionV4, wantDistribution)
|
||||||
|
}
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// TestPrefixHandlerKeepsOneRoutePerPrefixAndPeer runs updates from one peer
|
|
||||||
// through the prefix handler into a real database, flushing each message as its
|
|
||||||
// own batch, once with IPv4 prefixes and once with IPv6 prefixes. A peer has at
|
|
||||||
// most one route for a prefix: a later announcement replaces it whatever its
|
|
||||||
// origin AS, and a withdrawal removes it whatever AS the message's AS path ends
|
|
||||||
// in. The in-memory route count and prefix distribution must match the route
|
|
||||||
// table.
|
|
||||||
func TestPrefixHandlerKeepsOneRoutePerPrefixAndPeer(t *testing.T) {
|
|
||||||
families := []struct {
|
|
||||||
ipVersion int
|
|
||||||
prefix, otherPrefix string
|
|
||||||
// The mask length of both prefixes.
|
|
||||||
maskLength int
|
|
||||||
}{
|
|
||||||
{ipVersion: ipv4Version, prefix: "198.51.100.0/24", otherPrefix: "203.0.113.0/24", maskLength: 24},
|
|
||||||
{ipVersion: ipv6Version, prefix: "2001:db8:1::/48", otherPrefix: "2001:db8:2::/48", maskLength: 48},
|
|
||||||
}
|
|
||||||
|
|
||||||
ts := time.Date(2026, 1, 2, 3, 4, 5, 0, time.UTC)
|
|
||||||
announce := func(path ristypes.ASPath, announced string) *ristypes.RISMessage {
|
|
||||||
return &ristypes.RISMessage{
|
|
||||||
Peer: testPeerIP,
|
|
||||||
Path: path,
|
|
||||||
ParsedTimestamp: ts,
|
|
||||||
Announcements: []ristypes.RISAnnouncement{{NextHop: testPeerIP, Prefixes: []string{announced}}},
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
for _, family := range families {
|
|
||||||
prefix, otherPrefix := family.prefix, family.otherPrefix
|
|
||||||
|
|
||||||
// One message that announces otherPrefix with origin AS testASNB and
|
|
||||||
// withdraws prefix.
|
|
||||||
announceOtherAndWithdraw := announce(ristypes.ASPath{testASNA, testASNB}, otherPrefix)
|
|
||||||
announceOtherAndWithdraw.Withdrawals = []string{prefix}
|
|
||||||
|
|
||||||
tests := []struct {
|
|
||||||
name string
|
|
||||||
messages []*ristypes.RISMessage
|
|
||||||
// The origin AS of the peer's live route for each prefix. A prefix
|
|
||||||
// left out must have no live route.
|
|
||||||
wantOrigins map[string]int
|
|
||||||
}{
|
|
||||||
{
|
|
||||||
name: "the peer announces the prefix with a new origin AS",
|
|
||||||
messages: []*ristypes.RISMessage{
|
|
||||||
announce(ristypes.ASPath{testASNA}, prefix),
|
|
||||||
announce(ristypes.ASPath{testASNA, testASNB}, prefix),
|
|
||||||
},
|
|
||||||
wantOrigins: map[string]int{prefix: testASNB},
|
|
||||||
},
|
|
||||||
{
|
|
||||||
name: "one message announces a prefix with another origin AS and withdraws the prefix",
|
|
||||||
messages: []*ristypes.RISMessage{
|
|
||||||
announce(ristypes.ASPath{testASNA}, prefix),
|
|
||||||
announceOtherAndWithdraw,
|
|
||||||
},
|
|
||||||
wantOrigins: map[string]int{otherPrefix: testASNB},
|
|
||||||
},
|
|
||||||
}
|
|
||||||
|
|
||||||
for _, tt := range tests {
|
|
||||||
t.Run(fmt.Sprintf("IPv%d %s", family.ipVersion, tt.name), func(t *testing.T) {
|
|
||||||
db, err := database.New(&config.Config{StateDir: t.TempDir()}, logger.New())
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("failed to create database: %v", err)
|
|
||||||
}
|
|
||||||
defer func() { _ = db.Close() }()
|
|
||||||
|
|
||||||
// Built without NewPrefixHandler's flush timer, so the test flushes itself.
|
|
||||||
h := &PrefixHandler{db: db, logger: logger.New()}
|
|
||||||
for _, msg := range tt.messages {
|
|
||||||
h.HandleMessage(msg)
|
|
||||||
h.mu.Lock()
|
|
||||||
h.flushBatchLocked()
|
|
||||||
h.mu.Unlock()
|
|
||||||
}
|
|
||||||
|
|
||||||
for _, p := range []string{prefix, otherPrefix} {
|
|
||||||
routes, err := db.GetPrefixDetailsContext(context.Background(), p)
|
|
||||||
if err != nil && !errors.Is(err, database.ErrNoRoute) {
|
|
||||||
t.Fatalf("GetPrefixDetailsContext(%s): %v", p, err)
|
|
||||||
}
|
|
||||||
var gotOrigins []int
|
|
||||||
for _, route := range routes {
|
|
||||||
gotOrigins = append(gotOrigins, route.OriginASN)
|
|
||||||
}
|
|
||||||
var wantOrigins []int
|
|
||||||
if origin, ok := tt.wantOrigins[p]; ok {
|
|
||||||
wantOrigins = []int{origin}
|
|
||||||
}
|
|
||||||
if !slices.Equal(gotOrigins, wantOrigins) {
|
|
||||||
t.Errorf("origin ASes of the live routes for %s = %v, want %v", p, gotOrigins, wantOrigins)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
wantDistribution := []database.PrefixDistribution{
|
|
||||||
{MaskLength: family.maskLength, Count: len(tt.wantOrigins)},
|
|
||||||
}
|
|
||||||
assertCounts(t, db, family.ipVersion, len(tt.wantOrigins), wantDistribution)
|
|
||||||
})
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// assertCounts checks that the live route count and prefix distribution of one
|
|
||||||
// IP version are wantRoutes and wantDistribution, both as held in memory and as
|
|
||||||
// read from the route table.
|
|
||||||
func assertCounts(t *testing.T, db *database.Database, ipVersion, wantRoutes int,
|
|
||||||
wantDistribution []database.PrefixDistribution) {
|
|
||||||
t.Helper()
|
|
||||||
|
|
||||||
ctx := context.Background()
|
|
||||||
stats, err := db.GetStatsContext(ctx)
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("GetStatsContext: %v", err)
|
|
||||||
}
|
|
||||||
tableRoutesV4, tableRoutesV6, err := db.GetLiveRouteCountsContext(ctx)
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("GetLiveRouteCountsContext: %v", err)
|
|
||||||
}
|
|
||||||
queryDistributionV4, queryDistributionV6, err := db.GetPrefixDistributionContext(ctx)
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("GetPrefixDistributionContext: %v", err)
|
|
||||||
}
|
|
||||||
|
|
||||||
memoryRoutes, tableRoutes := stats.IPv4Routes, tableRoutesV4
|
|
||||||
memoryDistribution, queryDistribution := stats.IPv4PrefixDistribution, queryDistributionV4
|
|
||||||
if ipVersion == ipv6Version {
|
|
||||||
memoryRoutes, tableRoutes = stats.IPv6Routes, tableRoutesV6
|
|
||||||
memoryDistribution, queryDistribution = stats.IPv6PrefixDistribution, queryDistributionV6
|
|
||||||
}
|
|
||||||
|
|
||||||
if memoryRoutes != wantRoutes || tableRoutes != wantRoutes {
|
|
||||||
t.Errorf("IPv%d live routes: %d in memory, %d in the table, want %d",
|
|
||||||
ipVersion, memoryRoutes, tableRoutes, wantRoutes)
|
|
||||||
}
|
|
||||||
if !slices.Equal(memoryDistribution, wantDistribution) ||
|
|
||||||
!slices.Equal(queryDistribution, wantDistribution) {
|
|
||||||
t.Errorf("IPv%d prefix distribution: %v in memory, %v from the table, want %v",
|
|
||||||
ipVersion, memoryDistribution, queryDistribution, wantDistribution)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -759,7 +759,7 @@ func (s *Server) handlePrefixDetailJSON() http.HandlerFunc {
|
|||||||
}
|
}
|
||||||
prefix := parsed.Masked().String()
|
prefix := parsed.Masked().String()
|
||||||
|
|
||||||
routes, err := s.db.GetPrefixDetailsContext(r.Context(), prefix)
|
routes, _, err := s.db.GetPrefixDetailsContext(r.Context(), prefix)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
if errors.Is(err, database.ErrNoRoute) {
|
if errors.Is(err, database.ErrNoRoute) {
|
||||||
writeJSONError(w, http.StatusNotFound, err.Error())
|
writeJSONError(w, http.StatusNotFound, err.Error())
|
||||||
@@ -930,7 +930,7 @@ func (s *Server) handlePrefixDetail() http.HandlerFunc {
|
|||||||
}
|
}
|
||||||
prefix := parsed.Masked().String()
|
prefix := parsed.Masked().String()
|
||||||
|
|
||||||
routes, err := s.db.GetPrefixDetailsContext(r.Context(), prefix)
|
routes, originASNs, err := s.db.GetPrefixDetailsContext(r.Context(), prefix)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
if errors.Is(err, database.ErrNoRoute) {
|
if errors.Is(err, database.ErrNoRoute) {
|
||||||
http.Error(w, "Prefix not found", http.StatusNotFound)
|
http.Error(w, "Prefix not found", http.StatusNotFound)
|
||||||
@@ -952,18 +952,10 @@ func (s *Server) handlePrefixDetail() http.HandlerFunc {
|
|||||||
originMap := make(map[int]*ASNInfo)
|
originMap := make(map[int]*ASNInfo)
|
||||||
for _, route := range routes {
|
for _, route := range routes {
|
||||||
if _, exists := originMap[route.OriginASN]; !exists {
|
if _, exists := originMap[route.OriginASN]; !exists {
|
||||||
// Get AS info from database
|
|
||||||
asInfo, _, _ := s.db.GetASDetailsContext(r.Context(), route.OriginASN)
|
|
||||||
handle := ""
|
|
||||||
description := ""
|
|
||||||
if asInfo != nil {
|
|
||||||
handle = asInfo.Handle
|
|
||||||
description = asInfo.Description
|
|
||||||
}
|
|
||||||
originMap[route.OriginASN] = &ASNInfo{
|
originMap[route.OriginASN] = &ASNInfo{
|
||||||
ASN: route.OriginASN,
|
ASN: route.OriginASN,
|
||||||
Handle: handle,
|
Handle: originASNs[route.OriginASN].Handle,
|
||||||
Description: description,
|
Description: originASNs[route.OriginASN].Description,
|
||||||
PeerCount: 0,
|
PeerCount: 0,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -3,10 +3,13 @@ package server
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
|
"html"
|
||||||
"net/http"
|
"net/http"
|
||||||
"net/http/httptest"
|
"net/http/httptest"
|
||||||
"runtime"
|
"runtime"
|
||||||
"slices"
|
"slices"
|
||||||
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
@@ -15,6 +18,7 @@ import (
|
|||||||
"git.eeqj.de/sneak/routewatch/internal/logger"
|
"git.eeqj.de/sneak/routewatch/internal/logger"
|
||||||
"git.eeqj.de/sneak/routewatch/internal/metrics"
|
"git.eeqj.de/sneak/routewatch/internal/metrics"
|
||||||
"git.eeqj.de/sneak/routewatch/internal/streamer"
|
"git.eeqj.de/sneak/routewatch/internal/streamer"
|
||||||
|
"git.eeqj.de/sneak/routewatch/pkg/asinfo"
|
||||||
"github.com/google/uuid"
|
"github.com/google/uuid"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -200,6 +204,72 @@ func TestPrefixDetailHandlersParsePrefix(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// failingASDetailsDB wraps a real store and fails every AS details lookup.
|
||||||
|
type failingASDetailsDB struct {
|
||||||
|
database.Store
|
||||||
|
}
|
||||||
|
|
||||||
|
func (failingASDetailsDB) GetASDetailsContext(_ context.Context, _ int) (*database.ASN, []database.LiveRoute, error) {
|
||||||
|
return nil, nil, errors.New("AS details lookup failed")
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestPrefixDetailShowsOriginNames checks that the prefix page shows each
|
||||||
|
// origin AS's handle and description without looking up the AS's details,
|
||||||
|
// which also read every route the AS originates. Before the fix the page did
|
||||||
|
// that lookup once per origin, so with it failing the names were missing
|
||||||
|
// (https://git.eeqj.de/sneak/routewatch/issues/67). The AS path column shows
|
||||||
|
// handles too, so the test looks for the origin list's "(handle)" form.
|
||||||
|
func TestPrefixDetailShowsOriginNames(t *testing.T) {
|
||||||
|
db, err := database.New(&config.Config{StateDir: t.TempDir()}, logger.New())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("database.New: %v", err)
|
||||||
|
}
|
||||||
|
t.Cleanup(func() { _ = db.Close() })
|
||||||
|
|
||||||
|
ts := time.Date(2026, 1, 2, 3, 4, 5, 0, time.UTC)
|
||||||
|
origins := []int{15169, 13335}
|
||||||
|
for _, asn := range origins {
|
||||||
|
if _, err := db.GetOrCreateASN(asn, ts); err != nil {
|
||||||
|
t.Fatalf("GetOrCreateASN(%d): %v", asn, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if err := db.UpsertLiveRouteBatch([]*database.LiveRoute{
|
||||||
|
{
|
||||||
|
ID: uuid.New(), Prefix: "192.0.2.0/24", MaskLength: 24, IPVersion: 4,
|
||||||
|
OriginASN: origins[0], PeerIP: "198.51.100.1", ASPath: []int{origins[0]}, NextHop: "198.51.100.1",
|
||||||
|
LastUpdated: ts,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
ID: uuid.New(), Prefix: "192.0.2.0/24", MaskLength: 24, IPVersion: 4,
|
||||||
|
OriginASN: origins[1], PeerIP: "198.51.100.2", ASPath: []int{origins[1]}, NextHop: "198.51.100.2",
|
||||||
|
LastUpdated: ts,
|
||||||
|
},
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatalf("UpsertLiveRouteBatch: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
s := New(failingASDetailsDB{db}, streamer.New(logger.New(), metrics.New()), logger.New(), &config.Config{})
|
||||||
|
rec := httptest.NewRecorder()
|
||||||
|
s.router.ServeHTTP(rec, httptest.NewRequest(http.MethodGet, "/prefix/192.0.2.0/24", nil))
|
||||||
|
if rec.Code != http.StatusOK {
|
||||||
|
t.Fatalf("status %d, want %d; body %s", rec.Code, http.StatusOK, rec.Body)
|
||||||
|
}
|
||||||
|
|
||||||
|
page := rec.Body.String()
|
||||||
|
for _, asn := range origins {
|
||||||
|
info, ok := asinfo.Get(asn)
|
||||||
|
if !ok {
|
||||||
|
t.Fatalf("AS%d is not in the AS info data", asn)
|
||||||
|
}
|
||||||
|
if want := "(" + html.EscapeString(info.Handle) + ")"; !strings.Contains(page, want) {
|
||||||
|
t.Errorf("page does not show AS%d's handle %q", asn, want)
|
||||||
|
}
|
||||||
|
if want := html.EscapeString(info.Description); !strings.Contains(page, want) {
|
||||||
|
t.Errorf("page does not show AS%d's description %q", asn, want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// settledGoroutineCount lets transient goroutines finish, then reports the
|
// settledGoroutineCount lets transient goroutines finish, then reports the
|
||||||
// current count.
|
// current count.
|
||||||
func settledGoroutineCount() int {
|
func settledGoroutineCount() int {
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ import (
|
|||||||
"compress/gzip"
|
"compress/gzip"
|
||||||
"context"
|
"context"
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
"io"
|
"io"
|
||||||
"math"
|
"math"
|
||||||
@@ -48,6 +49,7 @@ const (
|
|||||||
metricsUpdateRate = time.Second
|
metricsUpdateRate = time.Second
|
||||||
minBackoffDelay = 5 * time.Second
|
minBackoffDelay = 5 * time.Second
|
||||||
maxBackoffDelay = 320 * time.Second
|
maxBackoffDelay = 320 * time.Second
|
||||||
|
streamIdleTimeout = 60 * time.Second // Reconnect when no line arrives for this long
|
||||||
metricsLogInterval = 10 * time.Second
|
metricsLogInterval = 10 * time.Second
|
||||||
bytesPerKB = 1024
|
bytesPerKB = 1024
|
||||||
bytesPerMB = 1024 * 1024
|
bytesPerMB = 1024 * 1024
|
||||||
@@ -58,6 +60,9 @@ const (
|
|||||||
backpressureSlope = 2.0 // Slope for linear drop probability increase
|
backpressureSlope = 2.0 // Slope for linear drop probability increase
|
||||||
)
|
)
|
||||||
|
|
||||||
|
// errStreamEnded is returned by stream when RIS Live ends the response.
|
||||||
|
var errStreamEnded = errors.New("RIS Live ended the stream")
|
||||||
|
|
||||||
// MessageHandler defines the interface for processing RIS messages.
|
// MessageHandler defines the interface for processing RIS messages.
|
||||||
// Implementations must specify which message types they want to receive,
|
// Implementations must specify which message types they want to receive,
|
||||||
// how to process messages, and their desired queue capacity.
|
// how to process messages, and their desired queue capacity.
|
||||||
@@ -107,6 +112,8 @@ type Streamer struct {
|
|||||||
logger *logger.Logger
|
logger *logger.Logger
|
||||||
client *http.Client
|
client *http.Client
|
||||||
url string
|
url string
|
||||||
|
idleTimeout time.Duration // Drop the connection when no line arrives for this long
|
||||||
|
minBackoff time.Duration // First wait before reconnecting; doubles up to maxBackoffDelay
|
||||||
handlers []*handlerInfo
|
handlers []*handlerInfo
|
||||||
rawHandler RawMessageHandler
|
rawHandler RawMessageHandler
|
||||||
mu sync.RWMutex
|
mu sync.RWMutex
|
||||||
@@ -124,8 +131,10 @@ type Streamer struct {
|
|||||||
// The metrics tracker is used to record message counts, bytes received, and connection status.
|
// The metrics tracker is used to record message counts, bytes received, and connection status.
|
||||||
func New(logger *logger.Logger, metrics *metrics.Tracker) *Streamer {
|
func New(logger *logger.Logger, metrics *metrics.Tracker) *Streamer {
|
||||||
return &Streamer{
|
return &Streamer{
|
||||||
logger: logger,
|
logger: logger,
|
||||||
url: risLiveURL,
|
url: risLiveURL,
|
||||||
|
idleTimeout: streamIdleTimeout,
|
||||||
|
minBackoff: minBackoffDelay,
|
||||||
client: &http.Client{
|
client: &http.Client{
|
||||||
Timeout: 0, // No timeout for streaming
|
Timeout: 0, // No timeout for streaming
|
||||||
Transport: &http.Transport{
|
Transport: &http.Transport{
|
||||||
@@ -405,7 +414,7 @@ func (s *Streamer) updateMetrics(messageBytes int) {
|
|||||||
|
|
||||||
// streamWithReconnect handles streaming with automatic reconnection and exponential backoff
|
// streamWithReconnect handles streaming with automatic reconnection and exponential backoff
|
||||||
func (s *Streamer) streamWithReconnect(ctx context.Context) {
|
func (s *Streamer) streamWithReconnect(ctx context.Context) {
|
||||||
backoffDelay := minBackoffDelay
|
backoffDelay := s.minBackoff
|
||||||
consecutiveFailures := 0
|
consecutiveFailures := 0
|
||||||
|
|
||||||
for {
|
for {
|
||||||
@@ -422,8 +431,9 @@ func (s *Streamer) streamWithReconnect(ctx context.Context) {
|
|||||||
err := s.stream(ctx)
|
err := s.stream(ctx)
|
||||||
streamDuration := time.Since(startTime)
|
streamDuration := time.Since(startTime)
|
||||||
|
|
||||||
if err == nil {
|
// Only Stop ends the streamer. A stream that ends any other way,
|
||||||
// Clean exit (context cancelled)
|
// with or without an error, is a disconnect and is reconnected.
|
||||||
|
if ctx.Err() != nil {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -434,17 +444,13 @@ func (s *Streamer) streamWithReconnect(ctx context.Context) {
|
|||||||
"stream_duration", streamDuration)
|
"stream_duration", streamDuration)
|
||||||
s.metrics.SetConnected(false)
|
s.metrics.SetConnected(false)
|
||||||
|
|
||||||
// Check if context is cancelled
|
// A stream that lasted more than 30 seconds resets the backoff. That
|
||||||
if ctx.Err() != nil {
|
// includes a stream dropped after streamIdleTimeout with no line, so
|
||||||
return
|
// a silent feed is retried after the first backoff delay every time.
|
||||||
}
|
|
||||||
|
|
||||||
// If we streamed for more than 30 seconds, reset the backoff
|
|
||||||
// This indicates we had a successful connection that received data
|
|
||||||
if streamDuration > 30*time.Second {
|
if streamDuration > 30*time.Second {
|
||||||
s.logger.Info("Resetting backoff delay due to successful connection",
|
s.logger.Info("Resetting backoff delay due to successful connection",
|
||||||
"stream_duration", streamDuration)
|
"stream_duration", streamDuration)
|
||||||
backoffDelay = minBackoffDelay
|
backoffDelay = s.minBackoff
|
||||||
consecutiveFailures = 0
|
consecutiveFailures = 0
|
||||||
} else {
|
} else {
|
||||||
// Increment consecutive failures
|
// Increment consecutive failures
|
||||||
@@ -477,7 +483,13 @@ func (s *Streamer) stream(ctx context.Context) error {
|
|||||||
connCtx, connCancel := context.WithCancel(ctx)
|
connCtx, connCancel := context.WithCancel(ctx)
|
||||||
defer connCancel()
|
defer connCancel()
|
||||||
|
|
||||||
req, err := http.NewRequestWithContext(ctx, "GET", s.url, nil)
|
// The idle timer drops the connection, by cancelling connCtx, when no
|
||||||
|
// line arrives for s.idleTimeout. Each line read starts it over. It
|
||||||
|
// also covers the wait for the server to answer.
|
||||||
|
idleTimer := time.AfterFunc(s.idleTimeout, connCancel)
|
||||||
|
defer idleTimer.Stop()
|
||||||
|
|
||||||
|
req, err := http.NewRequestWithContext(connCtx, "GET", s.url, nil)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to create request: %w", err)
|
return fmt.Errorf("failed to create request: %w", err)
|
||||||
}
|
}
|
||||||
@@ -559,6 +571,8 @@ func (s *Streamer) stream(ctx context.Context) error {
|
|||||||
scanner := bufio.NewScanner(reader)
|
scanner := bufio.NewScanner(reader)
|
||||||
|
|
||||||
for scanner.Scan() {
|
for scanner.Scan() {
|
||||||
|
idleTimer.Reset(s.idleTimeout)
|
||||||
|
|
||||||
select {
|
select {
|
||||||
case <-ctx.Done():
|
case <-ctx.Done():
|
||||||
s.logger.Info("Stream stopped by context")
|
s.logger.Info("Stream stopped by context")
|
||||||
@@ -707,11 +721,19 @@ func (s *Streamer) stream(ctx context.Context) error {
|
|||||||
s.mu.RUnlock()
|
s.mu.RUnlock()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if ctx.Err() != nil {
|
||||||
|
return ctx.Err()
|
||||||
|
}
|
||||||
|
|
||||||
|
if connCtx.Err() != nil {
|
||||||
|
return fmt.Errorf("no line received for %s", s.idleTimeout)
|
||||||
|
}
|
||||||
|
|
||||||
if err := scanner.Err(); err != nil {
|
if err := scanner.Err(); err != nil {
|
||||||
return fmt.Errorf("scanner error: %w", err)
|
return fmt.Errorf("scanner error: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
return nil
|
return errStreamEnded
|
||||||
}
|
}
|
||||||
|
|
||||||
// shouldDropForBackpressure determines if a message should be dropped based on queue utilization
|
// shouldDropForBackpressure determines if a message should be dropped based on queue utilization
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ import (
|
|||||||
"net/http"
|
"net/http"
|
||||||
"net/http/httptest"
|
"net/http/httptest"
|
||||||
"runtime"
|
"runtime"
|
||||||
|
"sync/atomic"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
@@ -39,6 +40,14 @@ func TestNewStreamer(t *testing.T) {
|
|||||||
if s.metrics != metricsTracker {
|
if s.metrics != metricsTracker {
|
||||||
t.Error("metrics tracker not set correctly")
|
t.Error("metrics tracker not set correctly")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if s.idleTimeout != streamIdleTimeout {
|
||||||
|
t.Errorf("idleTimeout = %s, want %s", s.idleTimeout, streamIdleTimeout)
|
||||||
|
}
|
||||||
|
|
||||||
|
if s.minBackoff != minBackoffDelay {
|
||||||
|
t.Errorf("minBackoff = %s, want %s", s.minBackoff, minBackoffDelay)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// TestStreamDoesNotLeakTickersAcrossReconnects drives many short-lived
|
// TestStreamDoesNotLeakTickersAcrossReconnects drives many short-lived
|
||||||
@@ -57,8 +66,8 @@ func TestStreamDoesNotLeakTickersAcrossReconnects(t *testing.T) {
|
|||||||
|
|
||||||
// One warm-up connection so any persistent HTTP transport goroutine exists
|
// One warm-up connection so any persistent HTTP transport goroutine exists
|
||||||
// before we take the baseline.
|
// before we take the baseline.
|
||||||
if err := s.stream(context.Background()); err != nil {
|
if err := s.stream(context.Background()); !errors.Is(err, errStreamEnded) {
|
||||||
t.Fatalf("warm-up stream returned error: %v", err)
|
t.Fatalf("warm-up stream returned %v, want %v", err, errStreamEnded)
|
||||||
}
|
}
|
||||||
s.client.CloseIdleConnections()
|
s.client.CloseIdleConnections()
|
||||||
|
|
||||||
@@ -66,8 +75,8 @@ func TestStreamDoesNotLeakTickersAcrossReconnects(t *testing.T) {
|
|||||||
|
|
||||||
const reconnects = 20
|
const reconnects = 20
|
||||||
for range reconnects {
|
for range reconnects {
|
||||||
if err := s.stream(context.Background()); err != nil {
|
if err := s.stream(context.Background()); !errors.Is(err, errStreamEnded) {
|
||||||
t.Fatalf("stream returned error: %v", err)
|
t.Fatalf("stream returned %v, want %v", err, errStreamEnded)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
s.client.CloseIdleConnections()
|
s.client.CloseIdleConnections()
|
||||||
@@ -78,23 +87,35 @@ func TestStreamDoesNotLeakTickersAcrossReconnects(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// updateHandler wants UPDATE messages and does nothing with them.
|
// updateLine is one UPDATE message as RIS Live sends it.
|
||||||
type updateHandler struct{}
|
const updateLine = `{"type":"ris_message","data":{"type":"UPDATE","peer":"192.0.2.1",` +
|
||||||
|
`"peer_asn":"64496","timestamp":1700000000}}` + "\n"
|
||||||
|
|
||||||
|
// updateHandler wants UPDATE messages. For each one it handles it sends on
|
||||||
|
// handled if there is room, and otherwise does nothing; a nil handled is
|
||||||
|
// never sent on.
|
||||||
|
type updateHandler struct {
|
||||||
|
handled chan struct{}
|
||||||
|
}
|
||||||
|
|
||||||
func (updateHandler) WantsMessage(messageType string) bool { return messageType == "UPDATE" }
|
func (updateHandler) WantsMessage(messageType string) bool { return messageType == "UPDATE" }
|
||||||
func (updateHandler) HandleMessage(*ristypes.RISMessage) {}
|
|
||||||
func (updateHandler) QueueCapacity() int { return 10 }
|
func (updateHandler) QueueCapacity() int { return 10 }
|
||||||
|
|
||||||
|
func (h updateHandler) HandleMessage(*ristypes.RISMessage) {
|
||||||
|
select {
|
||||||
|
case h.handled <- struct{}{}:
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// TestStopBeforeMessageReachesQueues stops the streamer after the read loop
|
// TestStopBeforeMessageReachesQueues stops the streamer after the read loop
|
||||||
// has checked for cancellation but before it hands the message to the handler
|
// has checked for cancellation but before it hands the message to the handler
|
||||||
// queues. That is the gap a stop from another goroutine can land in, and it
|
// queues. That is the gap a stop from another goroutine can land in, and it
|
||||||
// used to end in "send on closed channel". The raw handler runs in that gap on
|
// used to end in "send on closed channel". The raw handler runs in that gap on
|
||||||
// the read loop itself, so calling Stop from it hits the gap every time.
|
// the read loop itself, so calling Stop from it hits the gap every time.
|
||||||
func TestStopBeforeMessageReachesQueues(t *testing.T) {
|
func TestStopBeforeMessageReachesQueues(t *testing.T) {
|
||||||
const line = `{"type":"ris_message","data":{"type":"UPDATE","peer":"192.0.2.1",` +
|
|
||||||
`"peer_asn":"64496","timestamp":1700000000}}` + "\n"
|
|
||||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
||||||
_, _ = io.WriteString(w, line)
|
_, _ = io.WriteString(w, updateLine)
|
||||||
}))
|
}))
|
||||||
defer srv.Close()
|
defer srv.Close()
|
||||||
|
|
||||||
@@ -117,6 +138,117 @@ func TestStopBeforeMessageReachesQueues(t *testing.T) {
|
|||||||
s.Stop()
|
s.Stop()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// TestReconnectWhenStreamEnds has the server end the first response
|
||||||
|
// normally, as when RIS Live restarts. The streamer must treat that as a
|
||||||
|
// disconnect and connect again.
|
||||||
|
func TestReconnectWhenStreamEnds(t *testing.T) {
|
||||||
|
endResponse := func(http.ResponseWriter, *http.Request) {}
|
||||||
|
checkReconnect(t, endResponse, streamIdleTimeout)
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestReconnectWhenStreamGoesIdle has the server hold the first response
|
||||||
|
// open without sending anything. The streamer must drop it once the idle
|
||||||
|
// timeout passes and connect again.
|
||||||
|
func TestReconnectWhenStreamGoesIdle(t *testing.T) {
|
||||||
|
const idleTimeout = 50 * time.Millisecond
|
||||||
|
holdResponse := func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
w.(http.Flusher).Flush()
|
||||||
|
<-r.Context().Done()
|
||||||
|
}
|
||||||
|
checkReconnect(t, holdResponse, idleTimeout)
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestReconnectWhenServerNeverAnswers has the server accept the first
|
||||||
|
// request and never answer it, not even with headers. The streamer must give
|
||||||
|
// up on it once the idle timeout passes and connect again.
|
||||||
|
func TestReconnectWhenServerNeverAnswers(t *testing.T) {
|
||||||
|
const idleTimeout = 50 * time.Millisecond
|
||||||
|
neverAnswer := func(_ http.ResponseWriter, r *http.Request) {
|
||||||
|
<-r.Context().Done()
|
||||||
|
}
|
||||||
|
checkReconnect(t, neverAnswer, idleTimeout)
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestStreamNotDroppedWhileLinesArrive has the server send lines well within
|
||||||
|
// the idle timeout for several times the timeout, then end the response. Each
|
||||||
|
// line must start the idle timeout over, so the stream lasts until the server
|
||||||
|
// ends it instead of being dropped as idle.
|
||||||
|
func TestStreamNotDroppedWhileLinesArrive(t *testing.T) {
|
||||||
|
const (
|
||||||
|
idleTimeout = 100 * time.Millisecond
|
||||||
|
lineInterval = idleTimeout / 10
|
||||||
|
sendFor = 5 * idleTimeout
|
||||||
|
)
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
||||||
|
deadline := time.Now().Add(sendFor)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
_, _ = io.WriteString(w, updateLine)
|
||||||
|
w.(http.Flusher).Flush()
|
||||||
|
time.Sleep(lineInterval)
|
||||||
|
}
|
||||||
|
}))
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
s := New(logger.New(), metrics.New())
|
||||||
|
s.url = srv.URL
|
||||||
|
s.idleTimeout = idleTimeout
|
||||||
|
|
||||||
|
if err := s.stream(context.Background()); !errors.Is(err, errStreamEnded) {
|
||||||
|
t.Fatalf("stream returned %v, want %v", err, errStreamEnded)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// checkReconnect runs a streamer against a fake RIS Live server. The first
|
||||||
|
// response is served by firstResponse; every later one carries one UPDATE
|
||||||
|
// line and then stays open. The streamer must come back for a second
|
||||||
|
// response, must not be marked connected when it does, and must handle the
|
||||||
|
// UPDATE in it.
|
||||||
|
func checkReconnect(t *testing.T, firstResponse http.HandlerFunc, idleTimeout time.Duration) {
|
||||||
|
t.Helper()
|
||||||
|
|
||||||
|
const maxWait = 5 * time.Second
|
||||||
|
|
||||||
|
tracker := metrics.New()
|
||||||
|
connectedAtReconnect := make(chan bool, 1)
|
||||||
|
var requests atomic.Int32
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
if requests.Add(1) == 1 {
|
||||||
|
firstResponse(w, r)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case connectedAtReconnect <- tracker.IsConnected():
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
_, _ = io.WriteString(w, updateLine)
|
||||||
|
w.(http.Flusher).Flush()
|
||||||
|
<-r.Context().Done()
|
||||||
|
}))
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
s := New(logger.New(), tracker)
|
||||||
|
s.url = srv.URL
|
||||||
|
s.idleTimeout = idleTimeout
|
||||||
|
s.minBackoff = time.Millisecond
|
||||||
|
handler := updateHandler{handled: make(chan struct{}, 1)}
|
||||||
|
s.RegisterHandler(handler)
|
||||||
|
if err := s.Start(); err != nil {
|
||||||
|
t.Fatalf("Start returned error: %v", err)
|
||||||
|
}
|
||||||
|
defer s.Stop()
|
||||||
|
|
||||||
|
select {
|
||||||
|
case <-handler.handled:
|
||||||
|
case <-time.After(maxWait):
|
||||||
|
t.Fatalf("no message from a second response handled within %s", maxWait)
|
||||||
|
}
|
||||||
|
|
||||||
|
if <-connectedAtReconnect {
|
||||||
|
t.Error("streamer was still marked connected when it came back for a second response")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// settledGoroutineCount lets transient goroutines finish, then reports the
|
// settledGoroutineCount lets transient goroutines finish, then reports the
|
||||||
// current count.
|
// current count.
|
||||||
func settledGoroutineCount() int {
|
func settledGoroutineCount() int {
|
||||||
|
|||||||
@@ -283,6 +283,7 @@
|
|||||||
<div class="origin-item">
|
<div class="origin-item">
|
||||||
<a href="/as/{{.ASN}}" class="as-link">AS{{.ASN}}</a>
|
<a href="/as/{{.ASN}}" class="as-link">AS{{.ASN}}</a>
|
||||||
{{if .Handle}} ({{.Handle}}){{end}}
|
{{if .Handle}} ({{.Handle}}){{end}}
|
||||||
|
{{if .Description}} {{.Description}}{{end}}
|
||||||
<span style="color: #7f8c8d; margin-left: 10px;">{{.PeerCount}} peer{{if ne .PeerCount 1}}s{{end}}</span>
|
<span style="color: #7f8c8d; margin-left: 10px;">{{.PeerCount}} peer{{if ne .PeerCount 1}}s{{end}}</span>
|
||||||
</div>
|
</div>
|
||||||
{{end}}
|
{{end}}
|
||||||
|
|||||||
Reference in New Issue
Block a user