Never move last seen back or first seen forward (closes #162)

Some RIS collectors send updates days old while they catch up on a
backlog. Every update to a stored AS, peering or peer set last_seen to
the update's time, even an older one, and never lowered first_seen. An
AS page could then list a peer first seen after it was last seen.

The update statements for asns, peerings and bgp_peers now keep the
earlier of the stored and new first_seen and the later of the stored
and new last_seen, with MIN and MAX in the SQL. The batch and the
single-row writes share each statement. GetOrCreateASN returns the
times the row now holds. Route times are unchanged.

Model: opus-5-5

internal/database/database_internal_test.go

@@ -1965,16 +1965,10 @@ func TestUpdatePeerBatchStoresTheEarliestAndLatestTimesOfANewPeer(
 // of first_seen and last_seen, as when a collector catches up on a backlog.
 const backlogAge = 24 * time.Hour
 
-// batchSpan is how much earlier a batch's First is than its Last in the tests
-// of first_seen and last_seen.
-const batchSpan = time.Hour
-
 // TestOlderWriteKeepsLastSeenAndLowersFirstSeen writes a row of each of asns,
 // peerings and bgp_peers through each function that writes one: first at a
 // newer time, then at an older one. Each row keeps the newer last_seen and
-// takes the older first_seen. Each function writes a row of its own. A batch
+// takes the older first_seen. Each function writes a row of its own.
-// write's First is batchSpan before its Last, so the test catches the two
-// swapped. A single-row write takes one time.
 func TestOlderWriteKeepsLastSeenAndLowersFirstSeen(t *testing.T) {
 	t.Parallel()
 
@@ -1994,57 +1988,53 @@ func TestOlderWriteKeepsLastSeenAndLowersFirstSeen(t *testing.T) {
 			"WHERE peer_ip = ?"
 	)
 
-	checkOlderWrite(t, db, func(seen SeenTimes) error {
+	checkOlderWrite(t, db, func(at time.Time) error {
-		return db.GetOrCreateASNBatch(map[int]SeenTimes{batchASN: seen})
+		return db.GetOrCreateASNBatch(
-	}, batchSpan, asnQuery, batchASN)
+			map[int]SeenTimes{batchASN: {First: at, Last: at}})
+	}, asnQuery, batchASN)
 
-	checkOlderWrite(t, db, func(seen SeenTimes) error {
+	checkOlderWrite(t, db, func(at time.Time) error {
-		_, err := db.GetOrCreateASN(singleASN, seen.Last)
+		_, err := db.GetOrCreateASN(singleASN, at)
 
 		return err
-	}, 0, asnQuery, singleASN)
+	}, asnQuery, singleASN)
 
-	checkOlderWrite(t, db, func(seen SeenTimes) error {
+	checkOlderWrite(t, db, func(at time.Time) error {
-		return db.RecordPeering(batchASN, singleASN, seen)
+		return db.RecordPeering(batchASN, singleASN,
-	}, batchSpan, peeringQuery, batchASN, singleASN)
+			SeenTimes{First: at, Last: at})
+	}, peeringQuery, batchASN, singleASN)
 
-	checkOlderWrite(t, db, func(seen SeenTimes) error {
+	checkOlderWrite(t, db, func(at time.Time) error {
 		return db.UpdatePeerBatch(map[string]PeerUpdate{
 			testV4PeerIP: {
 				PeerIP: testV4PeerIP, PeerASN: peerASN,
 				MessageType: ristypes.MessageTypeUpdate,
-				Seen:        seen,
+				Seen:        SeenTimes{First: at, Last: at},
 			},
 		})
-	}, batchSpan, peerQuery, testV4PeerIP)
+	}, peerQuery, testV4PeerIP)
 
-	checkOlderWrite(t, db, func(seen SeenTimes) error {
+	checkOlderWrite(t, db, func(at time.Time) error {
-		return db.UpdatePeer(testPeerIP, peerASN, ristypes.MessageTypeUpdate,
+		return db.UpdatePeer(testPeerIP, peerASN, ristypes.MessageTypeUpdate, at)
-			seen.Last)
+	}, peerQuery, testPeerIP)
-	}, 0, peerQuery, testPeerIP)
 }
 
-// checkOlderWrite calls write twice, each time with First span before Last:
+// checkOlderWrite calls write at a newer time, then at a time backlogAge older.
-// first at newer times, then at times backlogAge older. It checks that query,
+// It checks that query, given args, reads first_seen at the older time and
-// given args, reads the older write's First as first_seen and the newer write's
+// last_seen at the newer one.
-// Last as last_seen.
 func checkOlderWrite(
-	t *testing.T, db *Database, write func(seen SeenTimes) error,
+	t *testing.T, db *Database, write func(at time.Time) error,
-	span time.Duration, query string, args ...any,
+	query string, args ...any,
 ) {
 	t.Helper()
 
-	newerLast := time.Date(2026, 1, 2, 3, 4, 5, 0, time.UTC)
+	newer := time.Date(2026, 1, 2, 3, 4, 5, 0, time.UTC)
-	newer := SeenTimes{First: newerLast.Add(-span), Last: newerLast}
+	older := newer.Add(-backlogAge)
-	older := SeenTimes{
-		First: newer.First.Add(-backlogAge),
-		Last:  newer.Last.Add(-backlogAge),
-	}
 
-	for _, seen := range []SeenTimes{newer, older} {
+	for _, at := range []time.Time{newer, older} {
-		err := write(seen)
+		err := write(at)
 		if err != nil {
-			t.Fatalf("writing first %s, last %s: %v", seen.First, seen.Last, err)
+			t.Fatalf("writing at %s: %v", at, err)
 		}
 	}
 
@@ -2056,9 +2046,9 @@ func checkOlderWrite(
 		t.Fatalf("reading the row: %v", err)
 	}
 
-	if !firstSeen.Equal(older.First) || !lastSeen.Equal(newer.Last) {
+	if !firstSeen.Equal(older) || !lastSeen.Equal(newer) {
 		t.Errorf("first seen %s, last seen %s; want %s, %s",
-			firstSeen, lastSeen, older.First, newer.Last)
+			firstSeen, lastSeen, older, newer)
 	}
 }