Remove RoutingTableHandler and snapshotter, use database for route stats

- Remove RoutingTableHandler as PrefixHandler maintains live_routes table
- Update server to get route counts from database instead of in-memory routing table
- Add GetLiveRouteCounts method to database for IPv4/IPv6 route counts
- Use metrics tracker in PrefixHandler for route update rates
- Remove snapshotter entirely as database contains all information
- Update tests to work without routing table

internal/routewatch/app.go

@@ -5,7 +5,6 @@ package routewatch
 import (
 	"context"
 	"fmt"
-	"os"
 	"sync"
 	"time"
 
@@ -13,38 +12,28 @@ import (
 	"git.eeqj.de/sneak/routewatch/internal/database"
 	"git.eeqj.de/sneak/routewatch/internal/logger"
 	"git.eeqj.de/sneak/routewatch/internal/metrics"
-	"git.eeqj.de/sneak/routewatch/internal/routingtable"
 	"git.eeqj.de/sneak/routewatch/internal/server"
-	"git.eeqj.de/sneak/routewatch/internal/snapshotter"
 	"git.eeqj.de/sneak/routewatch/internal/streamer"
 
 	"go.uber.org/fx"
 )
 
-const (
-	// routingTableStatsInterval is how often we log routing table statistics
-	routingTableStatsInterval = 15 * time.Second
-)
-
 // Dependencies contains all dependencies for RouteWatch
 type Dependencies struct {
 	fx.In
 
-	DB           database.Store
-	RoutingTable *routingtable.RoutingTable
-	Streamer     *streamer.Streamer
-	Server       *server.Server
-	Logger       *logger.Logger
-	Config       *config.Config
+	DB       database.Store
+	Streamer *streamer.Streamer
+	Server   *server.Server
+	Logger   *logger.Logger
+	Config   *config.Config
 }
 
 // RouteWatch represents the main application instance
 type RouteWatch struct {
 	db             database.Store
-	routingTable   *routingtable.RoutingTable
 	streamer       *streamer.Streamer
 	server         *server.Server
-	snapshotter    *snapshotter.Snapshotter
 	logger         *logger.Logger
 	maxRuntime     time.Duration
 	shutdown       bool
@@ -56,38 +45,15 @@ type RouteWatch struct {
 	peeringHandler *PeeringHandler
 }
 
-// isTruthy returns true if the value is considered truthy
-// Empty string, "0", and "false" are considered falsy, everything else is truthy
-func isTruthy(value string) bool {
-	return value != "" && value != "0" && value != "false"
-}
-
-// isSnapshotterEnabled checks if the snapshotter should be enabled based on environment variable
-func isSnapshotterEnabled() bool {
-	return !isTruthy(os.Getenv("ROUTEWATCH_DISABLE_SNAPSHOTTER"))
-}
-
 // New creates a new RouteWatch instance
 func New(deps Dependencies) *RouteWatch {
 	rw := &RouteWatch{
-		db:           deps.DB,
-		routingTable: deps.RoutingTable,
-		streamer:     deps.Streamer,
-		server:       deps.Server,
-		logger:       deps.Logger,
-		maxRuntime:   deps.Config.MaxRuntime,
-		config:       deps.Config,
-	}
-
-	// Create snapshotter if enabled
-	if isSnapshotterEnabled() {
-		snap, err := snapshotter.New(deps.RoutingTable, deps.Config, deps.Logger)
-		if err != nil {
-			deps.Logger.Error("Failed to create snapshotter", "error", err)
-			// Continue without snapshotter
-		} else {
-			rw.snapshotter = snap
-		}
+		db:         deps.DB,
+		streamer:   deps.Streamer,
+		server:     deps.Server,
+		logger:     deps.Logger,
+		maxRuntime: deps.Config.MaxRuntime,
+		config:     deps.Config,
 	}
 
 	return rw
@@ -131,17 +97,7 @@ func (rw *RouteWatch) Run(ctx context.Context) error {
 		return fmt.Errorf("non-batched handlers not implemented")
 	}
 
-	// Register routing table handler to maintain in-memory routing table
-	rtHandler := NewRoutingTableHandler(rw.routingTable, rw.logger)
-	rw.streamer.RegisterHandler(rtHandler)
-
-	// Start periodic routing table stats logging
-	go rw.logRoutingTableStats(ctx)
-
-	// Start snapshotter if available
-	if rw.snapshotter != nil {
-		rw.snapshotter.Start(ctx)
-	}
+	// No longer need routing table handler - PrefixHandler maintains live_routes table
 
 	// Start streaming
 	if err := rw.streamer.Start(); err != nil {
@@ -187,9 +143,6 @@ func (rw *RouteWatch) Shutdown() {
 	// Stop services
 	rw.streamer.Stop()
 
-	// Stop routing table expiration
-	rw.routingTable.Stop()
-
 	// Stop HTTP server with a timeout
 	const serverStopTimeout = 5 * time.Second
 	stopCtx, cancel := context.WithTimeout(context.Background(), serverStopTimeout)
@@ -208,43 +161,6 @@ func (rw *RouteWatch) Shutdown() {
 		"duration", time.Since(metrics.ConnectedSince),
 	)
 
-	// Take final snapshot before shutdown if snapshotter is available
-	if rw.snapshotter != nil {
-		rw.logger.Info("Taking final snapshot before shutdown")
-		if err := rw.snapshotter.Shutdown(); err != nil {
-			rw.logger.Error("Failed to shutdown snapshotter", "error", err)
-		} else {
-			rw.logger.Info("Final snapshot completed")
-		}
-	} else {
-		rw.logger.Info("No snapshotter available")
-	}
-}
-
-// logRoutingTableStats periodically logs routing table statistics
-func (rw *RouteWatch) logRoutingTableStats(ctx context.Context) {
-	// Log stats periodically
-	ticker := time.NewTicker(routingTableStatsInterval)
-	defer ticker.Stop()
-
-	for {
-		select {
-		case <-ctx.Done():
-			return
-		case <-ticker.C:
-			stats := rw.routingTable.GetDetailedStats()
-			rw.logger.Info("Routing table statistics",
-				"ipv4_routes", stats.IPv4Routes,
-				"ipv6_routes", stats.IPv6Routes,
-				"ipv4_updates_per_sec", fmt.Sprintf("%.2f", stats.IPv4UpdatesRate),
-				"ipv6_updates_per_sec", fmt.Sprintf("%.2f", stats.IPv6UpdatesRate),
-				"total_routes", stats.TotalRoutes,
-				"unique_prefixes", stats.UniquePrefixes,
-				"unique_origins", stats.UniqueOrigins,
-				"unique_peers", stats.UniquePeers,
-			)
-		}
-	}
 }
 
 // getModule provides all fx dependencies
@@ -258,7 +174,6 @@ func getModule() fx.Option {
 				database.New,
 				fx.As(new(database.Store)),
 			),
-			routingtable.New,
 			streamer.New,
 			server.New,
 			New,