Fix the third review of the origin changes

The prune test gains a third prefix with more than 500 rows newer than 72
hours, and checks every newer row survives and every older one is deleted, in
a helper shared by the three prefixes. The prefix page test uses an origin AS
the routing table does not carry. README's limit list says the routing table
drops the oldest waiting origin changes past 100,000, and the prefix page
entry says the page shows at most the newest 5,000. The tests read 5,000 and
100,000 from named limits instead of bare numbers, so the routing table's
waiting cap is now exported for them.

Model: deepseek-v4-pro

internal/server/prefix_originchanges_internal_test.go

@@ -1,6 +1,7 @@
 package server
 
 import (
+	"fmt"
 	"net/http"
 	"net/http/httptest"
 	"net/netip"
@@ -16,6 +17,11 @@ import (
 	"git.eeqj.de/sneak/routewatch/internal/streamer"
 )
 
+// testUncarriedASN is an origin AS the prefix page test's routing table does
+// not carry for the prefix, so the AS link the page shows comes from the
+// origin changes table.
+const testUncarriedASN = 64501
+
 // newPrefixDetailServer returns a server whose routing table holds testPrefixV4
 // with origin AS 64500, and whose database holds the given origin changes.
 func newPrefixDetailServer(
@@ -44,17 +50,18 @@ func newPrefixDetailServer(
 
 // TestPrefixDetailShowsOriginChanges checks that the prefix page shows the
 // origin changes newest first, with the announced and withdrawn rows and the
-// AS link.
+// AS link. The rows use an AS the routing table does not carry for the
+// prefix, so the link comes from the origin changes table.
 func TestPrefixDetailShowsOriginChanges(t *testing.T) {
 	t.Parallel()
 
 	prefix := netip.MustParsePrefix(testPrefixV4)
 
 	s := newPrefixDetailServer(t, []routetable.OriginChange{
-		{Prefix: prefix, OriginASN: 64500, Announced: true, PeerCount: 1,
-			Time: testRouteTime(1)},
-		{Prefix: prefix, OriginASN: 64500, Announced: false, PeerCount: 0,
-			Time: testRouteTime(2)},
+		{Prefix: prefix, OriginASN: testUncarriedASN, Announced: true,
+			PeerCount: 1, Time: testRouteTime(1)},
+		{Prefix: prefix, OriginASN: testUncarriedASN, Announced: false,
+			PeerCount: 0, Time: testRouteTime(2)},
 	})
 
 	rec := httptest.NewRecorder()
@@ -79,8 +86,8 @@ func TestPrefixDetailShowsOriginChanges(t *testing.T) {
 		t.Errorf("the withdrawn row is not shown before the announced row")
 	}
 
-	if !strings.Contains(page, `href="/as/64500"`) {
-		t.Errorf("page does not link to AS64500")
+	if !strings.Contains(page, `href="/as/64501"`) {
+		t.Errorf("page does not link to AS64501")
 	}
 }
 
@@ -115,15 +122,16 @@ func TestPrefixDetailShowsOriginZeroAsNoKnownOrigin(t *testing.T) {
 	}
 }
 
-// TestPrefixDetailSaysWhenMoreThan5000Changes checks that the prefix page says
-// so when a prefix has more than 5,000 origin changes.
-func TestPrefixDetailSaysWhenMoreThan5000Changes(t *testing.T) {
+// TestPrefixDetailSaysWhenThereAreMoreChangesThanItShows checks that the
+// prefix page says so when a prefix has more origin changes than the page's
+// limit.
+func TestPrefixDetailSaysWhenThereAreMoreChangesThanItShows(t *testing.T) {
 	t.Parallel()
 
 	prefix := netip.MustParsePrefix(testPrefixV4)
 
-	changes := make([]routetable.OriginChange, 0, 5001)
-	for i := range 5001 {
+	changes := make([]routetable.OriginChange, 0, maxOriginChangesOnPage+1)
+	for i := range maxOriginChangesOnPage + 1 {
 		changes = append(changes, routetable.OriginChange{
 			Prefix: prefix, OriginASN: 64500, Announced: true, PeerCount: 1,
 			Time: testRouteTime(i),
@@ -142,24 +150,27 @@ func TestPrefixDetailSaysWhenMoreThan5000Changes(t *testing.T) {
 
 	page := rec.Body.String()
 
-	if !strings.Contains(page, "more than 5000 changes") {
-		t.Errorf("page does not say there are more than 5000 changes")
+	note := fmt.Sprintf("more than %d changes", maxOriginChangesOnPage)
+	if !strings.Contains(page, note) {
+		t.Errorf("page does not say there are more than %d changes",
+			maxOriginChangesOnPage)
 	}
 
-	if got := strings.Count(page, "<td>Announced</td>"); got != 5000 {
-		t.Errorf("page shows %d change rows, want 5000", got)
+	if got := strings.Count(page, "<td>Announced</td>"); got != maxOriginChangesOnPage {
+		t.Errorf("page shows %d change rows, want %d", got,
+			maxOriginChangesOnPage)
 	}
 }
 
-// TestPrefixDetailShowsNoNoteAtExactly5000Changes checks that a prefix with
-// exactly 5,000 origin changes shows all 5,000 and no note.
-func TestPrefixDetailShowsNoNoteAtExactly5000Changes(t *testing.T) {
+// TestPrefixDetailShowsNoNoteAtTheLimit checks that a prefix with exactly the
+// page's limit of origin changes shows all of them and no note.
+func TestPrefixDetailShowsNoNoteAtTheLimit(t *testing.T) {
 	t.Parallel()
 
 	prefix := netip.MustParsePrefix(testPrefixV4)
 
-	changes := make([]routetable.OriginChange, 0, 5000)
-	for i := range 5000 {
+	changes := make([]routetable.OriginChange, 0, maxOriginChangesOnPage)
+	for i := range maxOriginChangesOnPage {
 		changes = append(changes, routetable.OriginChange{
 			Prefix: prefix, OriginASN: 64500, Announced: true, PeerCount: 1,
 			Time: testRouteTime(i),
@@ -179,11 +190,13 @@ func TestPrefixDetailShowsNoNoteAtExactly5000Changes(t *testing.T) {
 	page := rec.Body.String()
 
 	if strings.Contains(page, "more than") {
-		t.Errorf("page says there are more changes, but a prefix has 5000")
+		t.Errorf("page says there are more changes, but a prefix has %d",
+			maxOriginChangesOnPage)
 	}
 
-	if got := strings.Count(page, "<td>Announced</td>"); got != 5000 {
-		t.Errorf("page shows %d change rows, want 5000", got)
+	if got := strings.Count(page, "<td>Announced</td>"); got != maxOriginChangesOnPage {
+		t.Errorf("page shows %d change rows, want %d", got,
+			maxOriginChangesOnPage)
 	}
 }