Drain the handler queues before stopping the handlers on shutdown (closes #69)
check / check (push) Canceled after 0s

Shutdown stopped the handlers before the streamer, so updates still in the
handler queues, up to 20,000 per queue, were not written, and a lost
withdrawal left its route in the table after a restart.

Shutdown now stops the streamer first. Streamer.Stop queues the STATE
messages it holds for a full queue, closes the queues and returns once
every worker has handed its handler everything on its queue; then each
handler writes what it holds before its Stop returns. PeeringHandler.Stop
now waits for its loop's final write instead of running a second one
beside it.

Model: opus-5-5
This commit was merged in pull request #95.
This commit is contained in:
2026-10-19 13:08:48 +02:00
parent 2712183f21
commit 28df9f8d49
6 changed files with 235 additions and 26 deletions
+10 -6
View File
@@ -47,6 +47,7 @@ type PeeringHandler struct {
droppedPaths int // paths dropped because the map was full
stopCh chan struct{}
wg sync.WaitGroup
}
// NewPeeringHandler creates and initializes a new PeeringHandler with the
@@ -62,6 +63,8 @@ func NewPeeringHandler(db database.Store, logger *logger.Logger) *PeeringHandler
}
// Start the periodic processing goroutine
h.wg.Add(1)
go h.processLoop()
return h
@@ -130,17 +133,18 @@ func (h *PeeringHandler) ProcessPeeringsNow() {
}
// Stop gracefully shuts down the handler by signaling the background
// goroutine to stop and performing a final synchronous processing of
// any remaining AS paths. This ensures no peering data is lost during
// shutdown.
// goroutine to stop and waiting while it processes the remaining AS paths,
// so no peering data is lost during shutdown.
func (h *PeeringHandler) Stop() {
close(h.stopCh)
// Process any remaining peerings synchronously
h.processPeerings()
h.wg.Wait()
}
// processLoop runs periodically to process AS paths into peerings
// processLoop runs periodically to process AS paths into peerings, and once
// more on Stop.
func (h *PeeringHandler) processLoop() {
defer h.wg.Done()
ticker := time.NewTicker(peeringProcessInterval)
defer ticker.Stop()