sneak
5ba9fe8f66
.golangci.yml is the prompts-repo standard verbatim plus one approved
exception (paralleltest, sneak 2026-07-06). Roughly 1,500 findings
fixed:
- autofix sweep (wsl_v5/nlreturn/intrange/modernize formatting), with
the misspell autofix REVERTED where it rewrote authentic C game text
("missle vanishes" stays, with nolint and a comment)
- error handling: errcheck sites get real handling — saveFile now
closes explicitly and removes corrupt saves, scoreboard writes are
documented best-effort, err113 sentinel errors (ErrSaveOutOfDate,
ErrScreenTooSmall); panics allowed for unrecoverable states per
MEMORY.md policy
- gosec: real fixes (ParseInt for SEED, 0600 scorefile) and justified
per-line nolints for provably-bounded conversions (randomMonsterLetter
helper collapses eight rnd(26)+'A' sites)
- API tidying from linters: pointer receivers on flag types
(recvcheck), msg helpers renamed addmsgf/doaddf/Printwf/MvPrintwf
(goprintffuncname), myExit()/findFloor(monst)/mkGameInput(t) drop
always-constant params (unparam), gameEnd carries no status
- gocritic/staticcheck: if-else chains to switches, the pack.c
inventory filter untangled into matchesFilter, main.go split so
defers run before exit (exitAfterDefer, funlen)
- revive doc comments on all exported flag types/consts/methods
Remaining findings are confined to linters pending sneak's exception
decision (mnd, gochecknoglobals, cyclop, nestif, gocognit, exhaustive,
goconst, testpackage); TODO.md records the state. MEMORY.md added at
repo root as the project's agent working notes.
68 lines
1.4 KiB
Go
68 lines
1.4 KiB
Go
package game
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
)
|
|
|
|
// Rogue expresses damage as strings like "1x4/3x6": one attack rolling
|
|
// 1d4 and a second rolling 3d6. The C code re-parsed these with atoi on
|
|
// every swing (fight.c roll_em); the port parses them once, at table
|
|
// definition or item creation, into a DiceSpec.
|
|
|
|
// DiceRoll is one attack's dice: Count rolls of a Sides-sided die.
|
|
type DiceRoll struct {
|
|
Count int
|
|
Sides int
|
|
}
|
|
|
|
// DiceSpec is the sequence of attacks a damage string described.
|
|
type DiceSpec []DiceRoll
|
|
|
|
// ParseDice parses a C damage string with the exact semantics of the
|
|
// roll_em loop: leading digits (C atoi) before and after each 'x', attacks
|
|
// separated by '/'. Junk like the bestiary's "%%%x0" placeholder parses as
|
|
// a single 0x0 attack, as it did in C.
|
|
func ParseDice(s string) DiceSpec {
|
|
var spec DiceSpec
|
|
|
|
for s != "" {
|
|
count := cAtoi(s)
|
|
|
|
xi := strings.IndexByte(s, 'x')
|
|
if xi < 0 {
|
|
break
|
|
}
|
|
|
|
s = s[xi+1:]
|
|
spec = append(spec, DiceRoll{Count: count, Sides: cAtoi(s)})
|
|
|
|
si := strings.IndexByte(s, '/')
|
|
if si < 0 {
|
|
break
|
|
}
|
|
|
|
s = s[si+1:]
|
|
}
|
|
|
|
return spec
|
|
}
|
|
|
|
// dice is the table-definition shorthand for ParseDice.
|
|
func dice(s string) DiceSpec { return ParseDice(s) }
|
|
|
|
// String renders the spec back in the classic "NxM/NxM" form.
|
|
func (d DiceSpec) String() string {
|
|
var sb strings.Builder
|
|
|
|
for i, r := range d {
|
|
if i > 0 {
|
|
sb.WriteByte('/')
|
|
}
|
|
|
|
fmt.Fprintf(&sb, "%dx%d", r.Count, r.Sides)
|
|
}
|
|
|
|
return sb.String()
|
|
}
|