sneak/rgoue
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

Docs and test comments point at C reference branches that no longer exist #49

New Issue
Open
opened 2026-10-03 14:27:50 +02:00 by clawbot · 0 comments
clawbot commented 2026-10-03 14:27:50 +02:00
Collaborator
Copy Link
Copy Source

Problem

The remote has only main and next. The branches c-master, master and modern-rogue are gone, but the repo still sends readers to them for the C reference sources:

  • README.md (the C reference "lives on the master and modern-rogue branches")
  • ARCHITECTURE.md (near the top, and the "C reference implementation lives on" sentence later on)
  • TODO.md Status paragraph ("reference sources on c-master/modern-rogue")
  • game/testdata/README.md (golden regeneration runs git archive modern-rogue, which now fails)
  • test comments in game/dispatch_test.go, game/rings_test.go, game/traps_test.go, game/wizard_test.go (origin/c-master) and game/seedcompat_test.go (modern-rogue)

Anyone following these to check a transcribed value against C cannot.

The C sources are still in main's own history, which is never rewritten:

  • cf9bd26 ("Rogue - version 5.4.4") is the unmodified 5.4.4 tree, the one the docs call c-master/master.
  • 41fc104, the last commit before "Make the rgoue branch Go-only" (c0b533e), carries the modernised C tree (ncurses and C23 fixes) that the docs call modern-rogue. It differs from cf9bd26 in daemon.c, extern.h, main.c, potions.c, rip.c, rogue.h and state.c.

Definition of done

  1. Every reference above names the commit instead of the branch, e.g. "git show cf9bd26:wizard.c" or "git archive 41fc104". Verify the mapping yourself before writing it: confirm which tree each test's transcribed values actually match, rather than taking this issue's word for it.
  2. game/testdata/README.md's regeneration steps work as written against 41fc104.
  3. Historical entries in TODO.md Completed Steps stay as written; they record what was true then.
  4. Comments and markdown only, zero behaviour change. make fmt run; make check green.
  5. TODO.md Completed Steps entry in the same commit; do not rotate "Next Step".
  6. Commit title ends (closes #N).

This replaces item 1 of #16, which asked for the README to say c-master, a branch that no longer exists either.

Model: opus-5-5

## Problem The remote has only `main` and `next`. The branches `c-master`, `master` and `modern-rogue` are gone, but the repo still sends readers to them for the C reference sources: - `README.md` (the C reference "lives on the `master` and `modern-rogue` branches") - `ARCHITECTURE.md` (near the top, and the "C reference implementation lives on" sentence later on) - `TODO.md` Status paragraph ("reference sources on c-master/modern-rogue") - `game/testdata/README.md` (golden regeneration runs `git archive modern-rogue`, which now fails) - test comments in `game/dispatch_test.go`, `game/rings_test.go`, `game/traps_test.go`, `game/wizard_test.go` (`origin/c-master`) and `game/seedcompat_test.go` (`modern-rogue`) Anyone following these to check a transcribed value against C cannot. The C sources are still in `main`'s own history, which is never rewritten: - `cf9bd26` ("Rogue - version 5.4.4") is the unmodified 5.4.4 tree, the one the docs call `c-master`/`master`. - `41fc104`, the last commit before "Make the rgoue branch Go-only" (`c0b533e`), carries the modernised C tree (ncurses and C23 fixes) that the docs call `modern-rogue`. It differs from `cf9bd26` in `daemon.c`, `extern.h`, `main.c`, `potions.c`, `rip.c`, `rogue.h` and `state.c`. ## Definition of done 1. Every reference above names the commit instead of the branch, e.g. "`git show cf9bd26:wizard.c`" or "`git archive 41fc104`". Verify the mapping yourself before writing it: confirm which tree each test's transcribed values actually match, rather than taking this issue's word for it. 2. `game/testdata/README.md`'s regeneration steps work as written against `41fc104`. 3. Historical entries in `TODO.md` Completed Steps stay as written; they record what was true then. 4. Comments and markdown only, zero behaviour change. `make fmt` run; `make check` green. 5. `TODO.md` Completed Steps entry in the same commit; do not rotate "Next Step". 6. Commit title ends ` (closes #N)`. This replaces item 1 of https://git.eeqj.de/sneak/rgoue/issues/16, which asked for the README to say `c-master`, a branch that no longer exists either. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
Review passed and gate is green; ready to merge
 needs-checks
make check is failing on this PR
 needs-rebase
PR conflicts with main and must be rebased
 needs-review
PR awaiting independent adversarial review
 needs-rework
Review found problems; author must rework
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/rgoue#49