rgoue

sneak/rgoue

Fork 0

Commit Graph

Author	SHA1	Message	Date
sneak	5ba9fe8f66	Adopt house golangci-lint config; fix all approved-linter findings .golangci.yml is the prompts-repo standard verbatim plus one approved exception (paralleltest, sneak 2026-07-06). Roughly 1,500 findings fixed: - autofix sweep (wsl_v5/nlreturn/intrange/modernize formatting), with the misspell autofix REVERTED where it rewrote authentic C game text ("missle vanishes" stays, with nolint and a comment) - error handling: errcheck sites get real handling — saveFile now closes explicitly and removes corrupt saves, scoreboard writes are documented best-effort, err113 sentinel errors (ErrSaveOutOfDate, ErrScreenTooSmall); panics allowed for unrecoverable states per MEMORY.md policy - gosec: real fixes (ParseInt for SEED, 0600 scorefile) and justified per-line nolints for provably-bounded conversions (randomMonsterLetter helper collapses eight rnd(26)+'A' sites) - API tidying from linters: pointer receivers on flag types (recvcheck), msg helpers renamed addmsgf/doaddf/Printwf/MvPrintwf (goprintffuncname), myExit()/findFloor(monst)/mkGameInput(t) drop always-constant params (unparam), gameEnd carries no status - gocritic/staticcheck: if-else chains to switches, the pack.c inventory filter untangled into matchesFilter, main.go split so defers run before exit (exitAfterDefer, funlen) - revive doc comments on all exported flag types/consts/methods Remaining findings are confined to linters pending sneak's exception decision (mnd, gochecknoglobals, cyclop, nestif, gocognit, exhaustive, goconst, testpackage); TODO.md records the state. MEMORY.md added at repo root as the project's agent working notes.	2026-07-07 00:03:45 +02:00
sneak	3c5add87cd	go: port combat, chase driver, traps, zapping, death and scores - fight.c in full: fight/attack with all eight special monster attacks (aquator rust, ice freeze, rattlesnake poison, wraith/vampire drains, flytrap hold, leprechaun/nymph theft), swing, roll_em dice parsing (with a C-semantics atoi — Go's strconv rejects '1x4/...'), hit/miss message variants, killed, remove_mon - chase.c completed: runners, move_monst, relocate, do_chase with dragon breath, chase target selection (C's dead oroom comparison in relocate is preserved as-is) - move.c in full: do_move with passgo turning, all eight traps, rndmove, rust_armor - sticks.c completed: do_zap (all 14 sticks), drain, fire_bolt with wall bounces; weapons.c completed: missile/do_motion/fall/wield - rip.c: death tombstone, total_winner, killname; C exit() becomes a gameEnd panic that Run will recover - score.go: top-ten scoreboard as a gob file with lock-file protocol replacing the XOR-encrypted C format - wizard.c: whatis/set_know/teleport; daemons.c stomach - monster bestiary moved to per-game state (C mutates the flytrap damage string during play) Tests: combat math, kill/removal bookkeeping, monster chase pursuit, death unwinding, scripted-input headless terminal.	2026-07-06 19:23:45 +02:00

Author

SHA1

Message

Date

sneak

5ba9fe8f66

Adopt house golangci-lint config; fix all approved-linter findings

.golangci.yml is the prompts-repo standard verbatim plus one approved
exception (paralleltest, sneak 2026-07-06). Roughly 1,500 findings
fixed:

- autofix sweep (wsl_v5/nlreturn/intrange/modernize formatting), with
  the misspell autofix REVERTED where it rewrote authentic C game text
  ("missle vanishes" stays, with nolint and a comment)
- error handling: errcheck sites get real handling — saveFile now
  closes explicitly and removes corrupt saves, scoreboard writes are
  documented best-effort, err113 sentinel errors (ErrSaveOutOfDate,
  ErrScreenTooSmall); panics allowed for unrecoverable states per
  MEMORY.md policy
- gosec: real fixes (ParseInt for SEED, 0600 scorefile) and justified
  per-line nolints for provably-bounded conversions (randomMonsterLetter
  helper collapses eight rnd(26)+'A' sites)
- API tidying from linters: pointer receivers on flag types
  (recvcheck), msg helpers renamed addmsgf/doaddf/Printwf/MvPrintwf
  (goprintffuncname), myExit()/findFloor(monst)/mkGameInput(t) drop
  always-constant params (unparam), gameEnd carries no status
- gocritic/staticcheck: if-else chains to switches, the pack.c
  inventory filter untangled into matchesFilter, main.go split so
  defers run before exit (exitAfterDefer, funlen)
- revive doc comments on all exported flag types/consts/methods

Remaining findings are confined to linters pending sneak's exception
decision (mnd, gochecknoglobals, cyclop, nestif, gocognit, exhaustive,
goconst, testpackage); TODO.md records the state. MEMORY.md added at
repo root as the project's agent working notes.

2026-07-07 00:03:45 +02:00

sneak

3c5add87cd

go: port combat, chase driver, traps, zapping, death and scores

- fight.c in full: fight/attack with all eight special monster attacks
  (aquator rust, ice freeze, rattlesnake poison, wraith/vampire drains,
  flytrap hold, leprechaun/nymph theft), swing, roll_em dice parsing
  (with a C-semantics atoi — Go's strconv rejects '1x4/...'), hit/miss
  message variants, killed, remove_mon
- chase.c completed: runners, move_monst, relocate, do_chase with
  dragon breath, chase target selection (C's dead oroom comparison in
  relocate is preserved as-is)
- move.c in full: do_move with passgo turning, all eight traps,
  rndmove, rust_armor
- sticks.c completed: do_zap (all 14 sticks), drain, fire_bolt with
  wall bounces; weapons.c completed: missile/do_motion/fall/wield
- rip.c: death tombstone, total_winner, killname; C exit() becomes a
  gameEnd panic that Run will recover
- score.go: top-ten scoreboard as a gob file with lock-file protocol
  replacing the XOR-encrypted C format
- wizard.c: whatis/set_know/teleport; daemons.c stomach
- monster bestiary moved to per-game state (C mutates the flytrap
  damage string during play)

Tests: combat math, kill/removal bookkeeping, monster chase pursuit,
death unwinding, scripted-input headless terminal.

2026-07-06 19:23:45 +02:00

2 Commits