Update modernization log: add dates and cleanup whitespace

- Update date from placeholder to 2025-11-07 in MODERNIZATION_LOG.md
- Mark function prototype warnings as fixed in pending issues
- Remove trailing whitespace in daemon.c, rogue.h, state.c
- Clean up formatting in MODERNIZATION_LOG.md
This commit is contained in:
David Silva
2025-11-07 15:36:58 +00:00
parent a0c66a6078
commit f564a46c1c
4 changed files with 151 additions and 177 deletions

View File

@@ -126,37 +126,11 @@ move(oy, ox); /* Use public API instead of internal structure access */
## Pending Issues ## Pending Issues
Issues identified but not yet fixed: Issues identified but not yet fixed (low priority - build works correctly):
### 1. Function Prototype Warnings (C23 Compatibility) ### 1. ~~Function Prototype Warnings (C23 Compatibility)~~ ✅ FIXED
**Severity**: Medium (warnings only, build succeeds) **Status**: All function prototype warnings have been resolved in Iteration 2.
**Issue**: Multiple functions declared without prototypes in `extern.h`, causing C23 compatibility warnings.
**Affected Functions**:
- `fatal()` - declared as `void fatal();` but defined as `void fatal(char *s)`
- `my_exit()` - declared as `void my_exit();` but defined as `void my_exit(int st)`
- `set_order()` - declared as `void set_order();` but defined as `void set_order(int *order, int numthings)`
- Function pointer calls in `daemon.c` - `(*dev->d_func)(dev->d_arg)` without prototype
**Impact**:
- Build succeeds but generates warnings
- Will fail to compile with C23 standard
- Function calls may have incorrect argument checking
**Files Affected**:
- `extern.h` - function declarations
- `main.c` - calls to `fatal()` and `my_exit()`
- `daemon.c` - function pointer calls
- `state.c` - call to `new_item()`
- `things.c` - call to `set_order()`
- `rip.c` - call to `my_exit()`
**Solution Approach**:
1. Add proper function prototypes to `extern.h` with correct parameter types
2. Ensure all function definitions match their declarations
3. Fix function pointer type definitions in daemon structures
### 2. Deprecated `register` Keyword ### 2. Deprecated `register` Keyword