Rename constants to descriptive names (refactor step 1)

Pure rename, no behavior change; the full suite (RNG goldens,
generation invariants, scripted sessions, save round trip) is
unchanged and green.

- Creature flags: IsHuh→Confused, IsHalu→Hallucinating,
  CanHuh→CanConfuse, CanSee→CanSeeInvisible, IsRun→Awake,
  SeeMonst→SenseMonsters, IsCanc→Cancelled, IsLevit→Levitating,
  IsBlind/IsGreed/IsHaste/IsTarget/IsHeld/IsInvis/IsMean/IsRegen/
  IsFly/IsSlow → Blind/Greedy/Hasted/Targeted/Held/Invisible/Mean/
  Regenerates/Flying/Slowed, IsFound→Found
- Object flags: IsCursed→Cursed, IsKnow→Known, IsMissl→Missile,
  IsMany→Stackable, ObjIsFound→WasFound, IsProt→Protected
- Room flags: IsDark/IsGone/IsMaze → Dark/Gone/Maze; place flags:
  FPass→FPassage, FPNum→FPassNum, FTMask→FTrapMask
- Trap types: TDoor→TrapDoor ... TMyst→TrapMystery
- Item subtypes: P*→Potion* (PLSD→PotionLSD, PMFind→
  PotionDetectMonsters, ...), S*→Scroll* (SIDRorS→
  ScrollIdentifyRingOrStick, ...), R*→Ring* (RAddHit→RingDexterity,
  RNop→RingAdornment, ...), Ws*→Wand* (WsElect→WandLightning, ...),
  weapons (TwoSword→WeaponTwoHandedSword, Shiraken→WeaponShuriken,
  ...), armor (RingMail→ArmorRingMail, ...)
- Counts: Max{Potions,Scrolls,Rings,Sticks,Weapons,Armors} →
  Num{Potion,Scroll,Ring,Wand,Weapon,Armor}Types; NTraps→NumTrapTypes
- Level.NTraps field → TrapCount (also in the save snapshot)
- Original C constant names preserved as comment breadcrumbs in
  types.go so the lineage stays greppable

TODO.md: step 1 moved to Completed, step 2 (typed kinds) promoted to
Next Step.

game/passages.go

@@ -110,24 +110,24 @@ func (g *RogueGame) conn(r1, r2 int) {
 	var del, turnDelta, spos, epos Coord
 	var distance, turnDistance int
 	if direc == 'd' {
-		rmt := rm + 3               // room # of dest
-		rpt = &g.Level.Rooms[rmt]   // room pointer of dest
-		del = Coord{X: 0, Y: 1}     // direction of move
-		spos = rpf.Pos              // start of move
-		epos = rpt.Pos              // end of move
-		if !rpf.Flags.Has(IsGone) { // if not gone pick door pos
+		rmt := rm + 3             // room # of dest
+		rpt = &g.Level.Rooms[rmt] // room pointer of dest
+		del = Coord{X: 0, Y: 1}   // direction of move
+		spos = rpf.Pos            // start of move
+		epos = rpt.Pos            // end of move
+		if !rpf.Flags.Has(Gone) { // if not gone pick door pos
 			for {
 				spos.X = rpf.Pos.X + g.rnd(rpf.Max.X-2) + 1
 				spos.Y = rpf.Pos.Y + rpf.Max.Y - 1
-				if !(rpf.Flags.Has(IsMaze) && !g.Level.FlagsAt(spos.Y, spos.X).Has(FPass)) {
+				if !(rpf.Flags.Has(Maze) && !g.Level.FlagsAt(spos.Y, spos.X).Has(FPassage)) {
 					break
 				}
 			}
 		}
-		if !rpt.Flags.Has(IsGone) {
+		if !rpt.Flags.Has(Gone) {
 			for {
 				epos.X = rpt.Pos.X + g.rnd(rpt.Max.X-2) + 1
-				if !(rpt.Flags.Has(IsMaze) && !g.Level.FlagsAt(epos.Y, epos.X).Has(FPass)) {
+				if !(rpt.Flags.Has(Maze) && !g.Level.FlagsAt(epos.Y, epos.X).Has(FPassage)) {
 					break
 				}
 			}
@@ -146,19 +146,19 @@ func (g *RogueGame) conn(r1, r2 int) {
 		del = Coord{X: 1, Y: 0}
 		spos = rpf.Pos
 		epos = rpt.Pos
-		if !rpf.Flags.Has(IsGone) {
+		if !rpf.Flags.Has(Gone) {
 			for {
 				spos.X = rpf.Pos.X + rpf.Max.X - 1
 				spos.Y = rpf.Pos.Y + g.rnd(rpf.Max.Y-2) + 1
-				if !(rpf.Flags.Has(IsMaze) && !g.Level.FlagsAt(spos.Y, spos.X).Has(FPass)) {
+				if !(rpf.Flags.Has(Maze) && !g.Level.FlagsAt(spos.Y, spos.X).Has(FPassage)) {
 					break
 				}
 			}
 		}
-		if !rpt.Flags.Has(IsGone) {
+		if !rpt.Flags.Has(Gone) {
 			for {
 				epos.Y = rpt.Pos.Y + g.rnd(rpt.Max.Y-2) + 1
-				if !(rpt.Flags.Has(IsMaze) && !g.Level.FlagsAt(epos.Y, epos.X).Has(FPass)) {
+				if !(rpt.Flags.Has(Maze) && !g.Level.FlagsAt(epos.Y, epos.X).Has(FPassage)) {
 					break
 				}
 			}
@@ -177,12 +177,12 @@ func (g *RogueGame) conn(r1, r2 int) {
 
 	// Draw in the doors on either side of the passage or just put #'s if
 	// the rooms are gone.
-	if !rpf.Flags.Has(IsGone) {
+	if !rpf.Flags.Has(Gone) {
 		g.door(rpf, spos)
 	} else {
 		g.putpass(spos)
 	}
-	if !rpt.Flags.Has(IsGone) {
+	if !rpt.Flags.Has(Gone) {
 		g.door(rpt, epos)
 	} else {
 		g.putpass(epos)
@@ -216,7 +216,7 @@ func (g *RogueGame) conn(r1, r2 int) {
 // putpass).
 func (g *RogueGame) putpass(cp Coord) {
 	pp := g.Level.At(cp.Y, cp.X)
-	pp.Flags.Set(FPass)
+	pp.Flags.Set(FPassage)
 	if g.rnd(10)+1 < g.Depth && g.rnd(40) == 0 {
 		pp.Flags.Clear(FReal)
 	} else {
@@ -229,7 +229,7 @@ func (g *RogueGame) putpass(cp Coord) {
 func (g *RogueGame) door(rm *Room, cp Coord) {
 	rm.Exits = append(rm.Exits, cp)
 
-	if rm.Flags.Has(IsMaze) {
+	if rm.Flags.Has(Maze) {
 		return
 	}
 
@@ -252,10 +252,10 @@ func (g *RogueGame) addPass() {
 	for y := 1; y < NumLines-1; y++ {
 		for x := 0; x < NumCols; x++ {
 			pp := g.Level.At(y, x)
-			if pp.Flags.Has(FPass) || pp.Ch == Door ||
+			if pp.Flags.Has(FPassage) || pp.Ch == Door ||
 				(!pp.Flags.Has(FReal) && (pp.Ch == '|' || pp.Ch == '-')) {
 				ch := pp.Ch
-				if pp.Flags.Has(FPass) {
+				if pp.Flags.Has(FPassage) {
 					ch = Passage
 				}
 				pp.Flags.Set(FSeen)
@@ -266,7 +266,7 @@ func (g *RogueGame) addPass() {
 					g.addch(ch)
 				} else {
 					g.standout()
-					if pp.Flags.Has(FPass) {
+					if pp.Flags.Has(FPassage) {
 						g.addch(Passage)
 					} else {
 						g.addch(Door)
@@ -301,7 +301,7 @@ func (g *RogueGame) numpass(y, x int) {
 		return
 	}
 	fp := g.Level.FlagsAt(y, x)
-	if fp.Has(FPNum) {
+	if fp.Has(FPassNum) {
 		return
 	}
 	if g.newpnum {
@@ -314,7 +314,7 @@ func (g *RogueGame) numpass(y, x int) {
 		(!fp.Has(FReal) && (ch == '|' || ch == '-')) {
 		rp := &g.Level.Passages[g.pnum]
 		rp.Exits = append(rp.Exits, Coord{Y: y, X: x})
-	} else if !fp.Has(FPass) {
+	} else if !fp.Has(FPassage) {
 		return
 	}
 	*fp |= PlaceFlags(g.pnum)