Move all package-level vars into gameData; finish lint adoption
gochecknoglobals: all 37 package-level tables consolidated into the gameData struct (game/tables.go), built by newGameData() and carried on RogueGame as g.data (set in NewGame and Restore). ObjectKind Glyph()/objectKindForGlyph are now switches; the table-reading subtype Stringer methods are gone; isMagic is a RogueGame method. goconst: repeated words named (potionName/scrollName/ringName/goldName in object.go, wandName/staffName in sticks.go, ripWall in tables.go). exhaustive, testpackage: disabled in .golangci.yml with sneak's approval (2026-07-07). Also reverts misspell's silent corruption of the "ther" scroll-name syllable (it had become "there", changing generated scroll names vs C). Remaining red: cyclop/gocognit/nestif until refactor step 7; mnd awaits a ruling. TODO.md rotated; MEMORY.md lint notes updated.
This commit is contained in:
@@ -16,6 +16,9 @@ linters:
|
||||
- varnamelen # Short names like db, id are idiomatic Go
|
||||
# Repo-specific exceptions approved by sneak (2026-07-06)
|
||||
- paralleltest # Requires t.Parallel() in every test
|
||||
# Approved by sneak 2026-07-07
|
||||
- testpackage # Tests use internal package game to reach unexported state
|
||||
- exhaustive # C-faithful switches handle only the cases C handled
|
||||
|
||||
linters-settings:
|
||||
lll:
|
||||
|
||||
Reference in New Issue
Block a user