Disable mnd with sneak's approval (2026-07-07)
The 289 findings are C-faithful gameplay literals (probability rolls, damage spreads, screen coordinates); naming them would invent constants the C never had and hurt greppability against the reference sources.
This commit is contained in:
@@ -19,6 +19,7 @@ linters:
|
|||||||
# Approved by sneak 2026-07-07
|
# Approved by sneak 2026-07-07
|
||||||
- testpackage # Tests use internal package game to reach unexported state
|
- testpackage # Tests use internal package game to reach unexported state
|
||||||
- exhaustive # C-faithful switches handle only the cases C handled
|
- exhaustive # C-faithful switches handle only the cases C handled
|
||||||
|
- mnd # C-faithful gameplay literals; naming them hurts C-greppability
|
||||||
|
|
||||||
linters-settings:
|
linters-settings:
|
||||||
lll:
|
lll:
|
||||||
|
|||||||
@@ -20,10 +20,10 @@ The .golangci.yml is the house standard and may only be modified with
|
|||||||
sneak's explicit permission. To disable a linter, ask, explaining what
|
sneak's explicit permission. To disable a linter, ask, explaining what
|
||||||
the linter does; he approves specific exceptions, which are recorded
|
the linter does; he approves specific exceptions, which are recorded
|
||||||
in the config's "Repo-specific exceptions" block with the approval
|
in the config's "Repo-specific exceptions" block with the approval
|
||||||
date. Approved so far: paralleltest (2026-07-06); testpackage and
|
date. Approved so far: paralleltest (2026-07-06); testpackage,
|
||||||
exhaustive (2026-07-07). Complexity linters (cyclop, gocognit, nestif)
|
exhaustive, and mnd (2026-07-07). Complexity linters (cyclop, gocognit,
|
||||||
stay enabled and red until refactor step 7 fixes the findings, per
|
nestif) stay enabled and red until refactor step 7 fixes the findings,
|
||||||
sneak 2026-07-07. mnd findings await a ruling. Line-level //nolint
|
per sneak 2026-07-07. Line-level //nolint
|
||||||
with a reason is used sparingly for C-faithfulness (e.g. the authentic
|
with a reason is used sparingly for C-faithfulness (e.g. the authentic
|
||||||
"missle" message spellings) and provably-safe gosec conversions; each
|
"missle" message spellings) and provably-safe gosec conversions; each
|
||||||
needs a justifying comment.
|
needs a justifying comment.
|
||||||
|
|||||||
6
TODO.md
6
TODO.md
@@ -45,9 +45,9 @@ dispatch, and saveGame in favor of loops and helpers.
|
|||||||
fixed with named word constants (potionName, goldName, staffName,
|
fixed with named word constants (potionName, goldName, staffName,
|
||||||
ripWall, ...); testpackage and exhaustive disabled in .golangci.yml
|
ripWall, ...); testpackage and exhaustive disabled in .golangci.yml
|
||||||
with sneak's approval (2026-07-07); misspell's corruption of the
|
with sneak's approval (2026-07-07); misspell's corruption of the
|
||||||
"ther" scroll syllable reverted. Remaining red: cyclop (36), nestif
|
"ther" scroll syllable reverted. mnd disabled with sneak's approval
|
||||||
(30), gocognit (23) stay until step 7 fixes them per sneak's ruling,
|
(2026-07-07, follow-up commit). Remaining red: cyclop (36), nestif
|
||||||
and mnd (289) still awaits a ruling.
|
(30), gocognit (23) stay until step 7 fixes them per sneak's ruling.
|
||||||
- 2026-07-06 Lint adoption bulk (refactor/lint-adoption, 5ba9fe8):
|
- 2026-07-06 Lint adoption bulk (refactor/lint-adoption, 5ba9fe8):
|
||||||
.golangci.yml copied verbatim from the prompts repo (plus the
|
.golangci.yml copied verbatim from the prompts repo (plus the
|
||||||
sneak-approved paralleltest exception, 2026-07-06); ~1,500 findings
|
sneak-approved paralleltest exception, 2026-07-06); ~1,500 findings
|
||||||
|
|||||||
Reference in New Issue
Block a user