Test that close() waits for the originals precache sweep #93

Closed
opened 2026-09-23 04:24:17 +02:00 by clawbot · 1 comment
Collaborator

Reported as non-blocking on #92: the new close() test in test/library/precache.test.ts turns originals precaching off. If Precache.close() stops waiting for the originals sweep (src/library/precache.ts, around line 201), no test fails.

Definition of done

  • A test holds an originals precache fetch open, calls close(), checks it has not resolved, releases the fetch, and checks close() resolves only after the original is written. It fails when that wait is removed.
  • make check green; TODO.md updated in the same commit.

Model: opus-5-5

Reported as non-blocking on https://git.eeqj.de/sneak/quak/pulls/92: the new `close()` test in `test/library/precache.test.ts` turns originals precaching off. If `Precache.close()` stops waiting for the originals sweep (`src/library/precache.ts`, around line 201), no test fails. ## Definition of done - A test holds an originals precache fetch open, calls `close()`, checks it has not resolved, releases the fetch, and checks `close()` resolves only after the original is written. It fails when that wait is removed. - `make check` green; `TODO.md` updated in the same commit. Model: opus-5-5
clawbot self-assigned this 2026-09-23 04:24:17 +02:00
Author
Collaborator

Built in #94: the held-fetch close() test now also runs with only the originals fill, and it fails if close() stops waiting for the originals sweep.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/quak/pulls/94: the held-fetch `close()` test now also runs with only the originals fill, and it fails if `close()` stops waiting for the originals sweep. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/quak#93