Content-similarity search surface over the CLIP index #50
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/quak#50
Reference in New Issue
Block a user
Cache/API implementation (#36), phase 4.
Depends on the ML-data/index unit.
Goal
The content-similarity surface over the CLIP index, in RAM.
Scope
lib.mldata.forFile({ fileID })→ the storedMLDatapayload or undefined.lib.mldata.similar({ fileID, limit? })→ nearest fileIDs by CLIP embedding(cosine), RAM only.
lib.mldata.searchByEmbedding({ embedding, limit? })→ cosine similarity overthe index, RAM only. quak has no text encoder; the caller (the app, or a later
unit) supplies the query vector — do not bundle a model here (owner-deferred;
a bundled CLIP text model + ONNX runtime is its own future issue).
Float32Arrayindex of ~50k×512 must be a plain, fast loop; nonew dependency.
Definition of done
forFile/similar/searchByEmbeddingreturn correct rankings on a smallfixture index; RAM only, no network.
make checkgreen.Grounding
src/library/. Depends on the ML-data/index unit.Dispatch notes: TDD; no scripted edits; no interactive questions; plain language.
Squash subject ends
(closes #<this issue>). End every message withModel: opus-4-8.Model: opus-4-8
Implemented in PR #67 (branch
issue-50-ml-search, basenext).Added
lib.mldataover the #49 CLIP index:forFile({ fileID })— the stored ML payload from disk, or undefined.similar({ fileID, limit? })— nearest files by cosine over CLIP embeddings, the file itself excluded.searchByEmbedding({ embedding, limit? })— nearest files to a caller-supplied query vector; no text encoder is bundled (owner-deferred).Cosine is one plain loop over the packed
Float32Arrayindex, RAM only, no new dependency.similar/searchByEmbeddingreturn{ fileID, score }[]descending, ties broken by ascending fileID — a judgement call to include the score alongside the id.make checkis green.Model: opus-4-8
Reopened. The first implementation (PR #67) was reverted from next (#69): src/library/mlsearch.ts failed tsc under noUncheckedIndexedAccess, which make check does not catch (make check runs test/lint/fmt-check, not make build) — so it passed review but reddened next in the CI docker build. Redo: same scope, but the implementer AND reviewer must run make build (or script/cibuild) in addition to make check, and fix the index-access typing in the cosine loops (query[k]/embeddings[base+k]/fileIDs[i] are number|undefined under the strict config).
Model: opus-4-8
Redone in PR #72 (branch
issue-50-ml-search-redo, basenext), same scope as the reverted first cut.The revert cause is fixed: under
noUncheckedIndexedAccessthe cosine loops readquery[k]/embeddings[base+k]/fileIDs[i]asnumber | undefined, whichtscrejects. Each read is in range by the surrounding bounds (query length equals the embedding length, the buffer is packed), so they are asserted non-null in the hot loop. Verified green on bothmake checkandmake build(the tsc build thatmake checkdoes not run).Model: opus-4-8