lint-once: sh -c indirection is not followed by the invocation walk #34

New Issue

clawbot · 2026-09-04T14:12:21+02:00

clawbot commented

2026-09-04 14:12:21 +02:00

Spun out of #31 under its final-round rule: found during review of that PR, recorded rather than fixed there.

test/packaging/lint-once.test.ts walks the invocation graph from make check and .gitea/workflows/check.yml and asserts prettier runs exactly once from each. A command reached through sh -c is not followed — the header names this as a limitation, so it is disclosed rather than an overclaim, and it is not currently a false green in this repo because nothing here invokes prettier that way.

It is worth closing anyway: sh -c 'yarn run prettier --check .' added to a script or a Dockerfile RUN would run a second prettier pass while the suite stayed green, which is the exact failure mode #30 and #31 exist to prevent.

Whoever takes this: the standard #31 was held to is that the header must match the code exactly, in both directions — no claim beyond what the code does, and no disclosed limitation that no longer exists. If you follow sh -c, delete it from the not-followed list. Prove the fix by mutation, not by reading: add the invocation, confirm the suite goes red, revert.

PR #31 for context and for the mutation technique.

Spun out of #31 under its final-round rule: found during review of that PR, recorded rather than fixed there. `test/packaging/lint-once.test.ts` walks the invocation graph from `make check` and `.gitea/workflows/check.yml` and asserts prettier runs exactly once from each. A command reached through `sh -c` is not followed — the header names this as a limitation, so it is disclosed rather than an overclaim, and it is **not** currently a false green in this repo because nothing here invokes prettier that way. It is worth closing anyway: `sh -c 'yarn run prettier --check .'` added to a script or a Dockerfile `RUN` would run a second prettier pass while the suite stayed green, which is the exact failure mode #30 and #31 exist to prevent. Whoever takes this: the standard #31 was held to is that **the header must match the code exactly, in both directions** — no claim beyond what the code does, and no disclosed limitation that no longer exists. If you follow `sh -c`, delete it from the not-followed list. Prove the fix by mutation, not by reading: add the invocation, confirm the suite goes red, revert. PR #31 for context and for the mutation technique.

~~clawbot referenced this issue 2026-09-04 14:12:41 +02:00~~

Run all linting in Docker via Dockerfile.lint (closes #30) #31

clawbot commented

2026-09-05 11:32:54 +02:00

Closed at sneak's instruction, 2026-09-05: this was opened by an agent running on another machine outside the managed fleet, under superseded rules. Reopen if the content is wanted.

Model: fable-5-1

Closed at sneak's instruction, 2026-09-05: this was opened by an agent running on another machine outside the managed fleet, under superseded rules. Reopen if the content is wanted. Model: fable-5-1

clawbot closed this issue

2026-09-05 11:32:54 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sneak/quak#34

lint-once: sh -c indirection is not followed by the invocation walk #34

lint-once: `sh -c` indirection is not followed by the invocation walk #34