Names quak builds from server data can be over 255 bytes: backup-metadata album folders, quak get defaults, long extensions in a save path
#205
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/quak#205
Reference in New Issue
Block a user
Severity: low
Where: names built from an album name or a file title, outside the album folders and links of
quak backup:runMetadataBackupinsrc/metadata-backup.ts: the album folderID-NAME(mkdirSync(colDir, ...), outside anytry);originalNameandthumbnailNameinsrc/cli-output.ts: the default output names ofquak getandquak get-thumb;downloadFileanddownloadThumbnailinsrc/download/index.ts: the same defaults for a library caller that passes nooutPath;safeExtensioninsrc/filename.ts: the extension of the save pathYYYY-MM-DD.FILEID.EXT, which has no length limit.Problem: a file system refuses a file name over 255 bytes. An album name of that length makes
backup-metadatastop at that album withquak: ENAMETOOLONG: ...and exit 1, before the albums after it and before any file's metadata is written. A title of that length makesquak getandquak get-thumbfail unless--outis given;thumb_before a title of 250 bytes, a name its own system accepted, is already too long. A title whose extension is a long run of letters and digits (b.followed by 300es) gives a save path whose name is over 255 bytes, soquak backuprecords that original as failed on every run and never stores it. #204 fixes this for the album folders and links ofquak backupand addsshortenToBytesandMAX_NAME_BYTEStosrc/filename.ts; these names were left out of that change.Done when:
backup-metadataand the default names ofquak get,quak get-thumb,downloadFileanddownloadThumbnailare cut short withshortenToBytesso that each fits inMAX_NAME_BYTESwith everything added to it (ID-,thumb_), keeping the extension when it fits;safeExtensiongives.binfor an extension of more than 16 letters and digits, as it does for one holding anything else, and the README's "Backup layout" says so;backup-metadata, a 300-byte title forquak getandquak get-thumb, and theb.plus 300es title forquak backup, each checking the name written and the exit code.Starts after #204 is on
next.Model: opus-5-5
`backup-metadata`, `quak get` and `quak get-thumb` build names from server data that can be over 255 bytesto Names quak builds from server data can be over 255 bytes: `backup-metadata` album folders, `quak get` defaults, long extensions in a save pathPlan. Ready to start: the change it builds on (#204) is on
next.src/filename.ts, whose doc covers file names from server data and already holdsshortenToBytesandMAX_NAME_BYTES, gets one function that shortens a name to fit in a number of bytes while keeping its extension when the extension fits (cut short otherwise).withIDinuniqueNamesinsrc/backup.tsdoes the same inside its own rule. The new function is written sowithIDcan call it, andwithIDdoes so.safeExtensiongives.binfor an extension of more than 16 letters and digits.runMetadataBackupinsrc/metadata-backup.ts: the album folder isID-plus the name shortened to fitMAX_NAME_BYTES. The ID alone keeps folders apart, so no further rule is needed.originalNameandthumbnailNameinsrc/cli-output.ts, and the defaults indownloadFileanddownloadThumbnailinsrc/download/index.ts: the default names are shortened with the new function,thumb_included in the count.quak getandbackup-metadatatexts where they describe the names.Model: opus-5-5