sneak
9733cb7833
check / check (push) Waiting to run
Moves the pin to v2.15.0 and enables canonicalheader again, because that release fixes the random misses behind #105. The depguard exemption reached every directory below one ending in test, and a whole checkout under such a directory. It now covers only the files directly inside, and the directory a repository is cloned into does not count. gomodguard_v2 also blocks github.com/go-redis/redis/v9, whose pre-releases can still be imported. uniq-by-line is now false, so a line that trips two linters reports both findings. Three comments are corrected. A new comment says the file has no formatters section, so golangci-lint run does not run gofmt. Model: opus-5-5
123 lines
5.0 KiB
YAML
123 lines
5.0 KiB
YAML
version: "2"
|
|
|
|
# Config schema uses the golangci-lint v2 layout (settings live under
|
|
# linters.settings, not top-level linters-settings) so that the
|
|
# thresholds below are actually applied by golangci-lint >= v2.
|
|
#
|
|
# This file has no formatters section, so golangci-lint run does not run
|
|
# gofmt. A repository's script/fmt-check runs it, on the host.
|
|
|
|
run:
|
|
timeout: 5m
|
|
modules-download-mode: readonly
|
|
|
|
linters:
|
|
default: all
|
|
enable:
|
|
# Successor to the deprecated gomodguard. Named explicitly, rather than
|
|
# left to `default: all`, because it carries the module policy below.
|
|
- gomodguard_v2
|
|
disable:
|
|
# Genuinely incompatible with project patterns
|
|
- exhaustruct_v5 # Requires all struct fields
|
|
- godot # Requires comments to end with periods
|
|
- wrapcheck # Too verbose for internal packages
|
|
- varnamelen # Short names like db, id are idiomatic Go
|
|
# Deprecated: the warning is attached to the old name, so it is
|
|
# silenced by disabling that name, not by enabling the successor.
|
|
- exhaustruct # Deprecated, replaced by exhaustruct_v5
|
|
- wsl # Deprecated, replaced by wsl_v5
|
|
- gomodguard # Deprecated, replaced by gomodguard_v2
|
|
settings:
|
|
lll:
|
|
line-length: 88
|
|
funlen:
|
|
lines: 80
|
|
statements: 50
|
|
cyclop:
|
|
max-complexity: 15
|
|
dupl:
|
|
threshold: 100
|
|
depguard:
|
|
# Test-support code must not be compiled into the shipped binary. A
|
|
# test-support package exists to hand a test privileges the program
|
|
# itself must never have, so a file that is not a test must not import
|
|
# one. Test files, and the files inside a package whose directory name
|
|
# ends in `test`, are where that code belongs, and are exempt. A package
|
|
# in a subdirectory of that directory is not exempt. `${base-path}` is
|
|
# the directory holding this file, so the name of the directory a
|
|
# repository is cloned into does not count.
|
|
#
|
|
# The deny list below is the one part of this file a repository is
|
|
# expected to extend, and the only part it may. depguard matches an
|
|
# import path against a list of prefixes, so it cannot be told "any path
|
|
# whose last segment ends in test"; a repository's own test-support
|
|
# packages have to be named here one at a time, by full import path,
|
|
# under a module path that differs from repository to repository. Add
|
|
# them; change nothing else.
|
|
rules:
|
|
test-support:
|
|
list-mode: lax
|
|
files:
|
|
- "$all"
|
|
- "!$test"
|
|
- "!${base-path}**/*test/*"
|
|
deny:
|
|
- pkg: net/http/httptest
|
|
desc: >-
|
|
Test-support code belongs in test files and in packages whose
|
|
directory name ends in test, not in the shipped binary.
|
|
# Each entry names a module not to use and what to use instead. Every
|
|
# entry matches the module path exactly.
|
|
gomodguard_v2:
|
|
blocked:
|
|
- module: github.com/rs/zerolog
|
|
recommendations:
|
|
- log/slog
|
|
reason: "Structured logging is stdlib log/slog."
|
|
# These entries cover only the github.com/go-redis/redis module paths,
|
|
# one entry per path, because the later releases are separate paths.
|
|
# A prefix match would be shorter but would also reach
|
|
# github.com/go-redis/redismock/v9, the test double for the successor
|
|
# these entries recommend.
|
|
- module: github.com/go-redis/redis
|
|
recommendations:
|
|
- github.com/redis/go-redis/v9
|
|
reason: "Pre-fork module; use the maintained go-redis v9."
|
|
- module: github.com/go-redis/redis/v7
|
|
recommendations:
|
|
- github.com/redis/go-redis/v9
|
|
reason: "Pre-fork module; use the maintained go-redis v9."
|
|
- module: github.com/go-redis/redis/v8
|
|
recommendations:
|
|
- github.com/redis/go-redis/v9
|
|
reason: "Pre-fork module; use the maintained go-redis v9."
|
|
- module: github.com/go-redis/redis/v9
|
|
recommendations:
|
|
- github.com/redis/go-redis/v9
|
|
reason: "Pre-fork module; use the maintained go-redis v9."
|
|
- module: github.com/sergi/go-diff
|
|
recommendations:
|
|
- github.com/aymanbagabas/go-udiff
|
|
reason: "No unified diff output; use go-udiff."
|
|
- module: github.com/hexops/gotextdiff
|
|
recommendations:
|
|
- github.com/aymanbagabas/go-udiff
|
|
reason: "Unmaintained fork; use go-udiff."
|
|
exclusions:
|
|
rules:
|
|
# homoicon keeps a local copy of sobek, its JavaScript engine, as sneak
|
|
# decided in
|
|
# https://git.eeqj.de/sneak/homoicon/issues/1759#issuecomment-153261.
|
|
# This is an exclusion because gomoddirectives does not check its
|
|
# replace-allow-list for a replace that points at a local path.
|
|
- path: ^go\.mod$
|
|
linters:
|
|
- gomoddirectives
|
|
text: '^local replacement are not allowed: github\.com/grafana/sobek$'
|
|
|
|
issues:
|
|
max-issues-per-linter: 0
|
|
max-same-issues: 0
|
|
uniq-by-line: false
|